* [PATCH -next] power: supply: Make bd9995x_chip_reset static
@ 2020-05-11 11:12 Samuel Zou
2020-05-11 11:22 ` Vaittinen, Matti
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Zou @ 2020-05-11 11:12 UTC (permalink / raw)
To: sre
Cc: andriy.shevchenko, matti.vaittinen, linux-pm, linux-kernel, Samuel Zou
Fix the following sparse warning:
drivers/power/supply/bd99954-charger.c:1028:6: warning: symbol 'bd9995x_chip_reset' was not declared.
The bd9995x_chip_reset() has only one call site within bd99954-charger.c
It should be static
Fixes: 0902f8366491 ("power: supply: Support ROHM bd99954 charger")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
---
drivers/power/supply/bd99954-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/bd99954-charger.c b/drivers/power/supply/bd99954-charger.c
index 3da39c7..ffd8bfa 100644
--- a/drivers/power/supply/bd99954-charger.c
+++ b/drivers/power/supply/bd99954-charger.c
@@ -1025,7 +1025,7 @@ static int bd9995x_fw_probe(struct bd9995x_device *bd)
return 0;
}
-void bd9995x_chip_reset(void *bd)
+static void bd9995x_chip_reset(void *bd)
{
__bd9995x_chip_reset(bd);
}
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] power: supply: Make bd9995x_chip_reset static
2020-05-11 11:12 [PATCH -next] power: supply: Make bd9995x_chip_reset static Samuel Zou
@ 2020-05-11 11:22 ` Vaittinen, Matti
2020-05-28 17:07 ` sre@kernel.org
0 siblings, 1 reply; 3+ messages in thread
From: Vaittinen, Matti @ 2020-05-11 11:22 UTC (permalink / raw)
To: sre, zou_wei; +Cc: andriy.shevchenko, linux-pm, linux-kernel
On Mon, 2020-05-11 at 19:12 +0800, Samuel Zou wrote:
> Fix the following sparse warning:
>
> drivers/power/supply/bd99954-charger.c:1028:6: warning: symbol
> 'bd9995x_chip_reset' was not declared.
>
> The bd9995x_chip_reset() has only one call site within bd99954-
> charger.c
> It should be static
>
> Fixes: 0902f8366491 ("power: supply: Support ROHM bd99954 charger")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> drivers/power/supply/bd99954-charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bd99954-charger.c
> b/drivers/power/supply/bd99954-charger.c
> index 3da39c7..ffd8bfa 100644
> --- a/drivers/power/supply/bd99954-charger.c
> +++ b/drivers/power/supply/bd99954-charger.c
> @@ -1025,7 +1025,7 @@ static int bd9995x_fw_probe(struct
> bd9995x_device *bd)
> return 0;
> }
>
> -void bd9995x_chip_reset(void *bd)
> +static void bd9995x_chip_reset(void *bd)
> {
> __bd9995x_chip_reset(bd);
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] power: supply: Make bd9995x_chip_reset static
2020-05-11 11:22 ` Vaittinen, Matti
@ 2020-05-28 17:07 ` sre@kernel.org
0 siblings, 0 replies; 3+ messages in thread
From: sre@kernel.org @ 2020-05-28 17:07 UTC (permalink / raw)
To: Vaittinen, Matti; +Cc: zou_wei, andriy.shevchenko, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]
Hi,
On Mon, May 11, 2020 at 11:22:26AM +0000, Vaittinen, Matti wrote:
> On Mon, 2020-05-11 at 19:12 +0800, Samuel Zou wrote:
> > Fix the following sparse warning:
> >
> > drivers/power/supply/bd99954-charger.c:1028:6: warning: symbol
> > 'bd9995x_chip_reset' was not declared.
> >
> > The bd9995x_chip_reset() has only one call site within bd99954-
> > charger.c
> > It should be static
> >
> > Fixes: 0902f8366491 ("power: supply: Support ROHM bd99954 charger")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Samuel Zou <zou_wei@huawei.com>
>
> Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Thanks, queued.
-- Sebastian
> > ---
> > drivers/power/supply/bd99954-charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/bd99954-charger.c
> > b/drivers/power/supply/bd99954-charger.c
> > index 3da39c7..ffd8bfa 100644
> > --- a/drivers/power/supply/bd99954-charger.c
> > +++ b/drivers/power/supply/bd99954-charger.c
> > @@ -1025,7 +1025,7 @@ static int bd9995x_fw_probe(struct
> > bd9995x_device *bd)
> > return 0;
> > }
> >
> > -void bd9995x_chip_reset(void *bd)
> > +static void bd9995x_chip_reset(void *bd)
> > {
> > __bd9995x_chip_reset(bd);
> > }
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-28 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 11:12 [PATCH -next] power: supply: Make bd9995x_chip_reset static Samuel Zou
2020-05-11 11:22 ` Vaittinen, Matti
2020-05-28 17:07 ` sre@kernel.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).