* [PATCH] arm64: dts: allwinner: orangepi-zero-plus: fix PHY mode
@ 2021-11-17 9:47 Robert Marko
2021-11-17 13:27 ` Samuel Holland
0 siblings, 1 reply; 2+ messages in thread
From: Robert Marko @ 2021-11-17 9:47 UTC (permalink / raw)
To: robh+dt, mripard, wens, jernej.skrabec, devicetree,
linux-arm-kernel, linux-sunxi, linux-kernel
Cc: Robert Marko, Ron Goossens
Orange Pi Zero Plus uses a Realtek RTL8211E RGMII Gigabit PHY, but its
currently set to plain RGMII mode meaning that it doesn't introduce
delays.
With this setup, TX packets are completely lost and changing the mode to
RGMII-ID so the PHY will add delays internally fixes the issue.
Tested-by: Ron Goossens <rgoossens@gmail.com>
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts
index d13980ed7a79..7ec5ac850a0d 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts
@@ -69,7 +69,7 @@ &emac {
pinctrl-0 = <&emac_rgmii_pins>;
phy-supply = <®_gmac_3v3>;
phy-handle = <&ext_rgmii_phy>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};
--
2.33.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: orangepi-zero-plus: fix PHY mode
2021-11-17 9:47 [PATCH] arm64: dts: allwinner: orangepi-zero-plus: fix PHY mode Robert Marko
@ 2021-11-17 13:27 ` Samuel Holland
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Holland @ 2021-11-17 13:27 UTC (permalink / raw)
To: Robert Marko, robh+dt, mripard, wens, jernej.skrabec, devicetree,
linux-arm-kernel, linux-sunxi, linux-kernel
Cc: Ron Goossens
On 11/17/21 3:47 AM, Robert Marko wrote:
> Orange Pi Zero Plus uses a Realtek RTL8211E RGMII Gigabit PHY, but its
> currently set to plain RGMII mode meaning that it doesn't introduce
> delays.
>
> With this setup, TX packets are completely lost and changing the mode to
> RGMII-ID so the PHY will add delays internally fixes the issue.
>
> Tested-by: Ron Goossens <rgoossens@gmail.com>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Tested-by: Samuel Holland <samuel@sholland.org>
Also please add:
Fixes: a7affb13b271 ("arm64: allwinner: H5: Add Xunlong Orange Pi Zero
Plus")
so this will get backported to stable releases.
Regards,
Samuel
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts
> index d13980ed7a79..7ec5ac850a0d 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-zero-plus.dts
> @@ -69,7 +69,7 @@ &emac {
> pinctrl-0 = <&emac_rgmii_pins>;
> phy-supply = <®_gmac_3v3>;
> phy-handle = <&ext_rgmii_phy>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> status = "okay";
> };
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-17 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 9:47 [PATCH] arm64: dts: allwinner: orangepi-zero-plus: fix PHY mode Robert Marko
2021-11-17 13:27 ` Samuel Holland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).