* [PATCH] fuse: check whether fuse_request_alloc returns NULL in fuse_simple_request
@ 2020-10-22 13:13 Zhiqiang Liu
2020-10-27 9:24 ` Zhiqiang Liu
2020-11-05 1:33 ` Zhiqiang Liu
0 siblings, 2 replies; 4+ messages in thread
From: Zhiqiang Liu @ 2020-10-22 13:13 UTC (permalink / raw)
To: miklos; +Cc: mszeredi, linux-fsdevel, linux-kernel, linfeilong, lihaotian
In fuse_simple_request func, we will call fuse_request_alloc func to alloc
one request from fuse_req_cachep when args->force is true. However, the
return value of fuse_request_alloc func is not checked whether it is NULL.
If allocating request fails, access-NULL-pointer problem will occur.
Here, we check the return value of fuse_request_alloc func.
Fixes: 7213394c4e18 ("fuse: simplify request allocation")
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Signed-off-by: Haotian Li <lihaotian9@huawei.com>
---
fs/fuse/dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 02b3c36b3676..f7dd33ae8e31 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -481,6 +481,8 @@ ssize_t fuse_simple_request(struct fuse_conn *fc, struct fuse_args *args)
if (args->force) {
atomic_inc(&fc->num_waiting);
req = fuse_request_alloc(GFP_KERNEL | __GFP_NOFAIL);
+ if (!req)
+ return -ENOMEM;
if (!args->nocreds)
fuse_force_creds(fc, req);
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fuse: check whether fuse_request_alloc returns NULL in fuse_simple_request
2020-10-22 13:13 [PATCH] fuse: check whether fuse_request_alloc returns NULL in fuse_simple_request Zhiqiang Liu
@ 2020-10-27 9:24 ` Zhiqiang Liu
2020-11-05 1:33 ` Zhiqiang Liu
1 sibling, 0 replies; 4+ messages in thread
From: Zhiqiang Liu @ 2020-10-27 9:24 UTC (permalink / raw)
To: miklos
Cc: mszeredi, linux-fsdevel, linux-kernel, linfeilong, lihaotian,
fuse-devel, Nikolaus, kschalk, dhowells
friendly ping...
On 2020/10/22 21:13, Zhiqiang Liu wrote:
>
> In fuse_simple_request func, we will call fuse_request_alloc func to alloc
> one request from fuse_req_cachep when args->force is true. However, the
> return value of fuse_request_alloc func is not checked whether it is NULL.
> If allocating request fails, access-NULL-pointer problem will occur.
>
> Here, we check the return value of fuse_request_alloc func.
>
> Fixes: 7213394c4e18 ("fuse: simplify request allocation")
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> Signed-off-by: Haotian Li <lihaotian9@huawei.com>
> ---
> fs/fuse/dev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
> index 02b3c36b3676..f7dd33ae8e31 100644
> --- a/fs/fuse/dev.c
> +++ b/fs/fuse/dev.c
> @@ -481,6 +481,8 @@ ssize_t fuse_simple_request(struct fuse_conn *fc, struct fuse_args *args)
> if (args->force) {
> atomic_inc(&fc->num_waiting);
> req = fuse_request_alloc(GFP_KERNEL | __GFP_NOFAIL);
> + if (!req)
> + return -ENOMEM;
>
> if (!args->nocreds)
> fuse_force_creds(fc, req);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fuse: check whether fuse_request_alloc returns NULL in fuse_simple_request
2020-10-22 13:13 [PATCH] fuse: check whether fuse_request_alloc returns NULL in fuse_simple_request Zhiqiang Liu
2020-10-27 9:24 ` Zhiqiang Liu
@ 2020-11-05 1:33 ` Zhiqiang Liu
2020-11-05 2:09 ` Zhiqiang Liu
1 sibling, 1 reply; 4+ messages in thread
From: Zhiqiang Liu @ 2020-11-05 1:33 UTC (permalink / raw)
To: miklos, mszeredi, Miklos Szeredi
Cc: linux-fsdevel, linux-kernel, linfeilong, lihaotian
ping ...
On 2020/10/22 21:13, Zhiqiang Liu wrote:
>
> In fuse_simple_request func, we will call fuse_request_alloc func to alloc
> one request from fuse_req_cachep when args->force is true. However, the
> return value of fuse_request_alloc func is not checked whether it is NULL.
> If allocating request fails, access-NULL-pointer problem will occur.
>
> Here, we check the return value of fuse_request_alloc func.
>
> Fixes: 7213394c4e18 ("fuse: simplify request allocation")
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> Signed-off-by: Haotian Li <lihaotian9@huawei.com>
> ---
> fs/fuse/dev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
> index 02b3c36b3676..f7dd33ae8e31 100644
> --- a/fs/fuse/dev.c
> +++ b/fs/fuse/dev.c
> @@ -481,6 +481,8 @@ ssize_t fuse_simple_request(struct fuse_conn *fc, struct fuse_args *args)
> if (args->force) {
> atomic_inc(&fc->num_waiting);
> req = fuse_request_alloc(GFP_KERNEL | __GFP_NOFAIL);
> + if (!req)
> + return -ENOMEM;
>
> if (!args->nocreds)
> fuse_force_creds(fc, req);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fuse: check whether fuse_request_alloc returns NULL in fuse_simple_request
2020-11-05 1:33 ` Zhiqiang Liu
@ 2020-11-05 2:09 ` Zhiqiang Liu
0 siblings, 0 replies; 4+ messages in thread
From: Zhiqiang Liu @ 2020-11-05 2:09 UTC (permalink / raw)
To: miklos, mszeredi, Miklos Szeredi
Cc: linux-fsdevel, linux-kernel, linfeilong, lihaotian
Sorry for ignoring __GFP_NOFAIL flag.
Please ignore this patch.
On 2020/11/5 9:33, Zhiqiang Liu wrote:
> ping ...
>
> On 2020/10/22 21:13, Zhiqiang Liu wrote:
>>
>> In fuse_simple_request func, we will call fuse_request_alloc func to alloc
>> one request from fuse_req_cachep when args->force is true. However, the
>> return value of fuse_request_alloc func is not checked whether it is NULL.
>> If allocating request fails, access-NULL-pointer problem will occur.
>>
>> Here, we check the return value of fuse_request_alloc func.
>>
>> Fixes: 7213394c4e18 ("fuse: simplify request allocation")
>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>> Signed-off-by: Haotian Li <lihaotian9@huawei.com>
>> ---
>> fs/fuse/dev.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
>> index 02b3c36b3676..f7dd33ae8e31 100644
>> --- a/fs/fuse/dev.c
>> +++ b/fs/fuse/dev.c
>> @@ -481,6 +481,8 @@ ssize_t fuse_simple_request(struct fuse_conn *fc, struct fuse_args *args)
>> if (args->force) {
>> atomic_inc(&fc->num_waiting);
>> req = fuse_request_alloc(GFP_KERNEL | __GFP_NOFAIL);
>> + if (!req)
>> + return -ENOMEM;
>>
>> if (!args->nocreds)
>> fuse_force_creds(fc, req);
>>
>
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-05 2:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-22 13:13 [PATCH] fuse: check whether fuse_request_alloc returns NULL in fuse_simple_request Zhiqiang Liu
2020-10-27 9:24 ` Zhiqiang Liu
2020-11-05 1:33 ` Zhiqiang Liu
2020-11-05 2:09 ` Zhiqiang Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).