linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dirk Gouders <dirk@gouders.net>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: WARN_ONCE triggered: tpm_tis: Add a check for invalid status
Date: Wed, 14 Oct 2020 21:54:30 +0200	[thread overview]
Message-ID: <gho8l4shvt.fsf@gouders.net> (raw)
In-Reply-To: <7729a41ac22dab84a785bc7a6228af28b814a33a.camel@HansenPartnership.com> (James Bottomley's message of "Wed, 14 Oct 2020 11:24:08 -0700")

James Bottomley <James.Bottomley@HansenPartnership.com> writes:

> On Wed, 2020-10-14 at 19:57 +0200, Dirk Gouders wrote:
>> On my laptop the check introduced with 55707d531af62b (tpm_tis: Add a
>> check for invalid status) triggered the warning (output below).
>> 
>> So, my laptop seems to be a candidate for testing.
>
> I'm afraid this is a known problem on a wide range of TIS TPMs ... it's
> fixed by the patch set I'm trying to get upstream:
>
> https://lore.kernel.org/linux-integrity/20201001180925.13808-1-James.Bottomley@HansenPartnership.com/
>
> But in the meantime, it's harmless.  The TIS code at the point in the
> trace is trying to send a TPM2_GetCapability() command which fails
> because the locality isn't listening, but the design of that command is
> only to trigger an interrupt to probe the interrupt handling nothing
> else depends on it succeeding.

Thank you for the explanation and sorry for the noise.  It seems I
misunderstood the commit message.  I will watch the ongoing discussion
you pointed me to.

Dirk

      reply	other threads:[~2020-10-14 19:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 17:57 WARN_ONCE triggered: tpm_tis: Add a check for invalid status Dirk Gouders
2020-10-14 18:24 ` James Bottomley
2020-10-14 19:54   ` Dirk Gouders [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gho8l4shvt.fsf@gouders.net \
    --to=dirk@gouders.net \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).