* [PATCH v8 0/2] Logitech HID++ Bluetooth LE support
@ 2019-10-27 17:44 Mazin Rezk
2019-11-24 21:05 ` Mazin Rezk
0 siblings, 1 reply; 4+ messages in thread
From: Mazin Rezk @ 2019-10-27 17:44 UTC (permalink / raw)
To: linux-input
Cc: Benjamin Tissoires, jikos, linux-kernel, Filipe Laíns,
adrian, mnrzk
This series allows hid-logitech-hidpp to support Bluetooth LE HID++
devices. Only the MX Master (b012 and b01e) is added right now but more
HID++ Bluetooth LE devices can be added once they are tested.
Changes since [v7]:
- Squashed "HID: logitech-hidpp: Support MX Master (b012, b01e)
over Bluetooth" into "HID: logitech-hidpp: Support translations
from short to long reports"
Changes since [v6]:
- Based patch on "HID: logitech-hidpp: rework device validation"
- Removed the need for additional quirks
Changes since [v5]:
- Fixed bug where added quirks would overflow an unsigned long
- Changed the reserved quirk class bits from 0..20 to 0..15
Changes since [v4]:
- Omitted "HID: logitech: Add feature 0x0001: FeatureSet"
- Stored WirelessDeviceStatus feature index in hidpp_device
- Made Bluetooth quirk class alias quirks instead of vice versa
- Omitted non-tested devices
Changes since [v3]:
- Renamed hidpp20_featureset_get_feature to
hidpp20_featureset_get_feature_id.
- Re-ordered hidpp20_featureset_get_count and
hidpp20_featureset_get_feature_id based on their command IDs.
- Made feature_count initialize to 0 before running
hidpp20_get_features.
Changes since [v2]:
- Split up the single patch into a series
Changes since [v1]:
- Added WirelessDeviceStatus support
[v7] https://lore.kernel.org/lkml/t5LOL-A4W7aknqQdC-3TavitC94BY_Ra1qyxCZMh_nprrDNSl4UF-jYpWtaDSU-0oQ5xzRyAo9o_mvSnA78bib_p6I3ePSJnTrp3Eb0X_yg=@protonmail.com
[v6] https://lore.kernel.org/lkml/ggKipcQplIlTFmoP3hPnrQ-7_5-C0PKGd5feFymts3uenIBA8zOwz47YmKheD34H1rpkguDAGdx5YbS9UqpwfjT5Ir0Lji941liLVp--QtQ=@protonmail.com
[v5] https://lore.kernel.org/lkml/Mbf4goGxXZTfWwWtQQUke_rNf8kezpNOS9DVEVHf6RnnmjS1oRtMOJf4r14WfCC6GRYVs7gi0uZcIJ18Va2OJowzSbyMUGwLrl6I5fjW48o=@protonmail.com
[v4] https://lore.kernel.org/lkml/uBbIS3nFJ1jdYNLHcqjW5wxQAwmZv0kmYEoeoPrxNhfzi6cHwmCOY-ewdqe7S1hNEj-p4Hd9D0_Y3PymUTdh_6WFXuMmIYUkV2xaKCPMYz0=@protonmail.com
[v3] https://lore.kernel.org/lkml/l7xYjnA9EGfZe03FsrFhnH2aMq8qS8plWhHVvOtY_l4ShZ1NV6HA6hn9aI-jAzbLYUGFCIQCIKkx9z42Uoj4-AZDwBfRcAecYIn-0ZA5upE=@protonmail.com
[v2] https://www.spinics.net/lists/linux-input/msg63467.html
[v1] https://www.spinics.net/lists/linux-input/msg63317.html
Mazin Rezk (2):
HID: logitech-hidpp: Support translations from short to long reports
HID: logitech-hidpp: Support WirelessDeviceStatus connect events
drivers/hid/hid-logitech-hidpp.c | 69 +++++++++++++++++++++++++++-----
1 file changed, 59 insertions(+), 10 deletions(-)
--
2.23.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v8 0/2] Logitech HID++ Bluetooth LE support
2019-10-27 17:44 [PATCH v8 0/2] Logitech HID++ Bluetooth LE support Mazin Rezk
@ 2019-11-24 21:05 ` Mazin Rezk
2019-12-18 14:44 ` Benjamin Tissoires
0 siblings, 1 reply; 4+ messages in thread
From: Mazin Rezk @ 2019-11-24 21:05 UTC (permalink / raw)
To: linux-input
Cc: Benjamin Tissoires, jikos, linux-kernel, Filipe Laíns, mnrzk
On Sunday, October 27, 2019 1:44 PM, Mazin Rezk <mnrzk@protonmail.com> wrote:
> This series allows hid-logitech-hidpp to support Bluetooth LE HID++
> devices. Only the MX Master (b012 and b01e) is added right now but more
> HID++ Bluetooth LE devices can be added once they are tested.
>
> Changes since [v7]:
> - Squashed "HID: logitech-hidpp: Support MX Master (b012, b01e)
> over Bluetooth" into "HID: logitech-hidpp: Support translations
> from short to long reports"
>
> Changes since [v6]:
>
> - Based patch on "HID: logitech-hidpp: rework device validation"
>
> - Removed the need for additional quirks
>
> Changes since [v5]:
>
> - Fixed bug where added quirks would overflow an unsigned long
>
> - Changed the reserved quirk class bits from 0..20 to 0..15
>
> Changes since [v4]:
>
> - Omitted "HID: logitech: Add feature 0x0001: FeatureSet"
>
> - Stored WirelessDeviceStatus feature index in hidpp_device
>
> - Made Bluetooth quirk class alias quirks instead of vice versa
>
> - Omitted non-tested devices
>
> Changes since [v3]:
>
> - Renamed hidpp20_featureset_get_feature to
> hidpp20_featureset_get_feature_id.
>
> - Re-ordered hidpp20_featureset_get_count and
> hidpp20_featureset_get_feature_id based on their command IDs.
>
> - Made feature_count initialize to 0 before running
> hidpp20_get_features.
>
> Changes since [v2]:
>
> - Split up the single patch into a series
>
> Changes since [v1]:
>
> - Added WirelessDeviceStatus support
>
> [v7] https://lore.kernel.org/lkml/t5LOL-A4W7aknqQdC-3TavitC94BY_Ra1qyxCZMh_nprrDNSl4UF-jYpWtaDSU-0oQ5xzRyAo9o_mvSnA78bib_p6I3ePSJnTrp3Eb0X_yg=@protonmail.com
> [v6] https://lore.kernel.org/lkml/ggKipcQplIlTFmoP3hPnrQ-7_5-C0PKGd5feFymts3uenIBA8zOwz47YmKheD34H1rpkguDAGdx5YbS9UqpwfjT5Ir0Lji941liLVp--QtQ=@protonmail.com
> [v5] https://lore.kernel.org/lkml/Mbf4goGxXZTfWwWtQQUke_rNf8kezpNOS9DVEVHf6RnnmjS1oRtMOJf4r14WfCC6GRYVs7gi0uZcIJ18Va2OJowzSbyMUGwLrl6I5fjW48o=@protonmail.com
> [v4] https://lore.kernel.org/lkml/uBbIS3nFJ1jdYNLHcqjW5wxQAwmZv0kmYEoeoPrxNhfzi6cHwmCOY-ewdqe7S1hNEj-p4Hd9D0_Y3PymUTdh_6WFXuMmIYUkV2xaKCPMYz0=@protonmail.com
> [v3] https://lore.kernel.org/lkml/l7xYjnA9EGfZe03FsrFhnH2aMq8qS8plWhHVvOtY_l4ShZ1NV6HA6hn9aI-jAzbLYUGFCIQCIKkx9z42Uoj4-AZDwBfRcAecYIn-0ZA5upE=@protonmail.com
> [v2] https://www.spinics.net/lists/linux-input/msg63467.html
> [v1] https://www.spinics.net/lists/linux-input/msg63317.html
>
> Mazin Rezk (2):
> HID: logitech-hidpp: Support translations from short to long reports
> HID: logitech-hidpp: Support WirelessDeviceStatus connect events
>
> drivers/hid/hid-logitech-hidpp.c | 69 +++++++++++++++++++++++++++-----
> 1 file changed, 59 insertions(+), 10 deletions(-)
>
> ---
> 2.23.0
I recently saw "HID: logitech-hidpp: Silence intermittent
get_battery_capacity errors" get applied into the kernel, would I need to
rebase this patch on top of https://patchwork.kernel.org/patch/11243871/
Thanks,
Mazin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v8 0/2] Logitech HID++ Bluetooth LE support
2019-11-24 21:05 ` Mazin Rezk
@ 2019-12-18 14:44 ` Benjamin Tissoires
2019-12-18 15:49 ` Benjamin Tissoires
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Tissoires @ 2019-12-18 14:44 UTC (permalink / raw)
To: Mazin Rezk; +Cc: linux-input, jikos, linux-kernel, Filipe Laíns
Hi Mazin,
On Sun, Nov 24, 2019 at 10:05 PM Mazin Rezk <mnrzk@protonmail.com> wrote:
>
> On Sunday, October 27, 2019 1:44 PM, Mazin Rezk <mnrzk@protonmail.com> wrote:
>
> > This series allows hid-logitech-hidpp to support Bluetooth LE HID++
> > devices. Only the MX Master (b012 and b01e) is added right now but more
> > HID++ Bluetooth LE devices can be added once they are tested.
> >
> > Changes since [v7]:
> > - Squashed "HID: logitech-hidpp: Support MX Master (b012, b01e)
> > over Bluetooth" into "HID: logitech-hidpp: Support translations
> > from short to long reports"
> >
> > Changes since [v6]:
> >
> > - Based patch on "HID: logitech-hidpp: rework device validation"
> >
> > - Removed the need for additional quirks
> >
> > Changes since [v5]:
> >
> > - Fixed bug where added quirks would overflow an unsigned long
> >
> > - Changed the reserved quirk class bits from 0..20 to 0..15
> >
> > Changes since [v4]:
> >
> > - Omitted "HID: logitech: Add feature 0x0001: FeatureSet"
> >
> > - Stored WirelessDeviceStatus feature index in hidpp_device
> >
> > - Made Bluetooth quirk class alias quirks instead of vice versa
> >
> > - Omitted non-tested devices
> >
> > Changes since [v3]:
> >
> > - Renamed hidpp20_featureset_get_feature to
> > hidpp20_featureset_get_feature_id.
> >
> > - Re-ordered hidpp20_featureset_get_count and
> > hidpp20_featureset_get_feature_id based on their command IDs.
> >
> > - Made feature_count initialize to 0 before running
> > hidpp20_get_features.
> >
> > Changes since [v2]:
> >
> > - Split up the single patch into a series
> >
> > Changes since [v1]:
> >
> > - Added WirelessDeviceStatus support
> >
> > [v7] https://lore.kernel.org/lkml/t5LOL-A4W7aknqQdC-3TavitC94BY_Ra1qyxCZMh_nprrDNSl4UF-jYpWtaDSU-0oQ5xzRyAo9o_mvSnA78bib_p6I3ePSJnTrp3Eb0X_yg=@protonmail.com
> > [v6] https://lore.kernel.org/lkml/ggKipcQplIlTFmoP3hPnrQ-7_5-C0PKGd5feFymts3uenIBA8zOwz47YmKheD34H1rpkguDAGdx5YbS9UqpwfjT5Ir0Lji941liLVp--QtQ=@protonmail.com
> > [v5] https://lore.kernel.org/lkml/Mbf4goGxXZTfWwWtQQUke_rNf8kezpNOS9DVEVHf6RnnmjS1oRtMOJf4r14WfCC6GRYVs7gi0uZcIJ18Va2OJowzSbyMUGwLrl6I5fjW48o=@protonmail.com
> > [v4] https://lore.kernel.org/lkml/uBbIS3nFJ1jdYNLHcqjW5wxQAwmZv0kmYEoeoPrxNhfzi6cHwmCOY-ewdqe7S1hNEj-p4Hd9D0_Y3PymUTdh_6WFXuMmIYUkV2xaKCPMYz0=@protonmail.com
> > [v3] https://lore.kernel.org/lkml/l7xYjnA9EGfZe03FsrFhnH2aMq8qS8plWhHVvOtY_l4ShZ1NV6HA6hn9aI-jAzbLYUGFCIQCIKkx9z42Uoj4-AZDwBfRcAecYIn-0ZA5upE=@protonmail.com
> > [v2] https://www.spinics.net/lists/linux-input/msg63467.html
> > [v1] https://www.spinics.net/lists/linux-input/msg63317.html
> >
> > Mazin Rezk (2):
> > HID: logitech-hidpp: Support translations from short to long reports
> > HID: logitech-hidpp: Support WirelessDeviceStatus connect events
> >
> > drivers/hid/hid-logitech-hidpp.c | 69 +++++++++++++++++++++++++++-----
> > 1 file changed, 59 insertions(+), 10 deletions(-)
> >
> > ---
> > 2.23.0
>
> I recently saw "HID: logitech-hidpp: Silence intermittent
> get_battery_capacity errors" get applied into the kernel, would I need to
> rebase this patch on top of https://patchwork.kernel.org/patch/11243871/
No worries, your series still applies cleanly (git magic).
I am in the process of doing some final tests for this series, and I
plan to merge it for 5.6. Sorry we missed 5.5.
Cheers,
Benjamin
>
> Thanks,
> Mazin
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v8 0/2] Logitech HID++ Bluetooth LE support
2019-12-18 14:44 ` Benjamin Tissoires
@ 2019-12-18 15:49 ` Benjamin Tissoires
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Tissoires @ 2019-12-18 15:49 UTC (permalink / raw)
To: Mazin Rezk; +Cc: linux-input, jikos, linux-kernel, Filipe Laíns
On Wed, Dec 18, 2019 at 3:44 PM Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
>
> Hi Mazin,
>
> On Sun, Nov 24, 2019 at 10:05 PM Mazin Rezk <mnrzk@protonmail.com> wrote:
> >
> > On Sunday, October 27, 2019 1:44 PM, Mazin Rezk <mnrzk@protonmail.com> wrote:
> >
> > > This series allows hid-logitech-hidpp to support Bluetooth LE HID++
> > > devices. Only the MX Master (b012 and b01e) is added right now but more
> > > HID++ Bluetooth LE devices can be added once they are tested.
> > >
> > > Changes since [v7]:
> > > - Squashed "HID: logitech-hidpp: Support MX Master (b012, b01e)
> > > over Bluetooth" into "HID: logitech-hidpp: Support translations
> > > from short to long reports"
> > >
> > > Changes since [v6]:
> > >
> > > - Based patch on "HID: logitech-hidpp: rework device validation"
> > >
> > > - Removed the need for additional quirks
> > >
> > > Changes since [v5]:
> > >
> > > - Fixed bug where added quirks would overflow an unsigned long
> > >
> > > - Changed the reserved quirk class bits from 0..20 to 0..15
> > >
> > > Changes since [v4]:
> > >
> > > - Omitted "HID: logitech: Add feature 0x0001: FeatureSet"
> > >
> > > - Stored WirelessDeviceStatus feature index in hidpp_device
> > >
> > > - Made Bluetooth quirk class alias quirks instead of vice versa
> > >
> > > - Omitted non-tested devices
> > >
> > > Changes since [v3]:
> > >
> > > - Renamed hidpp20_featureset_get_feature to
> > > hidpp20_featureset_get_feature_id.
> > >
> > > - Re-ordered hidpp20_featureset_get_count and
> > > hidpp20_featureset_get_feature_id based on their command IDs.
> > >
> > > - Made feature_count initialize to 0 before running
> > > hidpp20_get_features.
> > >
> > > Changes since [v2]:
> > >
> > > - Split up the single patch into a series
> > >
> > > Changes since [v1]:
> > >
> > > - Added WirelessDeviceStatus support
> > >
> > > [v7] https://lore.kernel.org/lkml/t5LOL-A4W7aknqQdC-3TavitC94BY_Ra1qyxCZMh_nprrDNSl4UF-jYpWtaDSU-0oQ5xzRyAo9o_mvSnA78bib_p6I3ePSJnTrp3Eb0X_yg=@protonmail.com
> > > [v6] https://lore.kernel.org/lkml/ggKipcQplIlTFmoP3hPnrQ-7_5-C0PKGd5feFymts3uenIBA8zOwz47YmKheD34H1rpkguDAGdx5YbS9UqpwfjT5Ir0Lji941liLVp--QtQ=@protonmail.com
> > > [v5] https://lore.kernel.org/lkml/Mbf4goGxXZTfWwWtQQUke_rNf8kezpNOS9DVEVHf6RnnmjS1oRtMOJf4r14WfCC6GRYVs7gi0uZcIJ18Va2OJowzSbyMUGwLrl6I5fjW48o=@protonmail.com
> > > [v4] https://lore.kernel.org/lkml/uBbIS3nFJ1jdYNLHcqjW5wxQAwmZv0kmYEoeoPrxNhfzi6cHwmCOY-ewdqe7S1hNEj-p4Hd9D0_Y3PymUTdh_6WFXuMmIYUkV2xaKCPMYz0=@protonmail.com
> > > [v3] https://lore.kernel.org/lkml/l7xYjnA9EGfZe03FsrFhnH2aMq8qS8plWhHVvOtY_l4ShZ1NV6HA6hn9aI-jAzbLYUGFCIQCIKkx9z42Uoj4-AZDwBfRcAecYIn-0ZA5upE=@protonmail.com
> > > [v2] https://www.spinics.net/lists/linux-input/msg63467.html
> > > [v1] https://www.spinics.net/lists/linux-input/msg63317.html
> > >
> > > Mazin Rezk (2):
> > > HID: logitech-hidpp: Support translations from short to long reports
> > > HID: logitech-hidpp: Support WirelessDeviceStatus connect events
> > >
> > > drivers/hid/hid-logitech-hidpp.c | 69 +++++++++++++++++++++++++++-----
> > > 1 file changed, 59 insertions(+), 10 deletions(-)
> > >
> > > ---
> > > 2.23.0
> >
> > I recently saw "HID: logitech-hidpp: Silence intermittent
> > get_battery_capacity errors" get applied into the kernel, would I need to
> > rebase this patch on top of https://patchwork.kernel.org/patch/11243871/
>
> No worries, your series still applies cleanly (git magic).
>
> I am in the process of doing some final tests for this series, and I
> plan to merge it for 5.6. Sorry we missed 5.5.
And done.
Applied to for-5.6/logitech, sorry for the delay.
Cheers,
Benjamin
>
> Cheers,
> Benjamin
>
> >
> > Thanks,
> > Mazin
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-18 15:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-27 17:44 [PATCH v8 0/2] Logitech HID++ Bluetooth LE support Mazin Rezk
2019-11-24 21:05 ` Mazin Rezk
2019-12-18 14:44 ` Benjamin Tissoires
2019-12-18 15:49 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).