From: Bandan Das <bsd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Dave Jones" <dsj@fb.com>,
"Linux Kernel" <linux-kernel@vger.kernel.org>,
"Radim Krčmář" <rkrcmar@redhat.com>,
kvm@vger.kernel.org
Subject: Re: RFC: silencing kvm unimplemented msr spew.
Date: Fri, 22 Jul 2016 12:37:58 -0400 [thread overview]
Message-ID: <jpgbn1py6ft.fsf@linux.bootlegged.copy> (raw)
In-Reply-To: <1171934212.9737926.1469204427109.JavaMail.zimbra@redhat.com> (Paolo Bonzini's message of "Fri, 22 Jul 2016 12:20:27 -0400 (EDT)")
Paolo Bonzini <pbonzini@redhat.com> writes:
>> >> Paolo, would you prefer this, or the other approach you already ack'd ?
>> >
>> > I think I prefer the other, because vcpu_debug is not ratelimited.
>> > If the guest can trigger a printk it should always be ratelimited.
>>
>> Agree with rate limiting, but making this the default for everything doesn't
>> sound right IMO, especially for ignore_msrs=1. vcpu_unimpl is already rate
>> limited.
>
> The problem is that your patch removes rate limiting whenever it now
> uses vcpu_debug.
I was suggesting Dave to do something like what I posted but with a new
vcpu_debug_ratelimited.
> Paolo
next prev parent reply other threads:[~2016-07-22 16:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 19:27 RFC: silencing kvm unimplemented msr spew Dave Jones
2016-07-18 15:26 ` Paolo Bonzini
2016-07-19 19:58 ` Dave Jones
2016-07-19 20:24 ` Bandan Das
2016-07-21 20:24 ` Dave Jones
2016-07-21 20:41 ` Bandan Das
2016-07-22 8:48 ` Paolo Bonzini
2016-07-22 16:04 ` Bandan Das
2016-07-22 16:20 ` Paolo Bonzini
2016-07-22 16:37 ` Bandan Das [this message]
2016-07-19 22:12 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jpgbn1py6ft.fsf@linux.bootlegged.copy \
--to=bsd@redhat.com \
--cc=dsj@fb.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).