* [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix
@ 2014-09-08 22:06 Mel Gorman
2014-09-08 22:14 ` Tejun Heo
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Mel Gorman @ 2014-09-08 22:06 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Tejun Heo, LKML
A commit in linux-next was causing boot to fail and bisection identified
the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_".
The commit ID is worthless as it's a linux-next commit. One of the changes
in that patch looks very suspicious. Reverting the full patch fixes boot
as does this fixlet.
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
arch/x86/kernel/apic/x2apic_cluster.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/apic/x2apic_cluster.c b/arch/x86/kernel/apic/x2apic_cluster.c
index 1f5d5f2..e658f21 100644
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -43,6 +43,7 @@ __x2apic_send_IPI_mask(const struct cpumask *mask, int vector, int apic_dest)
* and be sure it's manipulated with irq off.
*/
ipi_mask_ptr = this_cpu_cpumask_var_ptr(ipi_mask);
+ cpumask_copy(ipi_mask_ptr, mask);
/*
* The idea is to send one IPI per cluster.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix
2014-09-08 22:06 [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix Mel Gorman
@ 2014-09-08 22:14 ` Tejun Heo
2014-09-08 23:46 ` Christoph Lameter
2014-09-09 0:21 ` David Rientjes
2 siblings, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2014-09-08 22:14 UTC (permalink / raw)
To: Mel Gorman; +Cc: Christoph Lameter, LKML
On Mon, Sep 08, 2014 at 11:06:54PM +0100, Mel Gorman wrote:
> A commit in linux-next was causing boot to fail and bisection identified
> the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_".
> The commit ID is worthless as it's a linux-next commit. One of the changes
It is actually a stable commit ID. I'll add the commit ID in the
change log.
> in that patch looks very suspicious. Reverting the full patch fixes boot
> as does this fixlet.
Applying to percpu/for-3.18-consistent-ops.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix
2014-09-08 22:06 [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix Mel Gorman
2014-09-08 22:14 ` Tejun Heo
@ 2014-09-08 23:46 ` Christoph Lameter
2014-09-09 0:35 ` Tejun Heo
2014-09-09 0:21 ` David Rientjes
2 siblings, 1 reply; 6+ messages in thread
From: Christoph Lameter @ 2014-09-08 23:46 UTC (permalink / raw)
To: Mel Gorman; +Cc: Tejun Heo, LKML
On Mon, 8 Sep 2014, Mel Gorman wrote:
> A commit in linux-next was causing boot to fail and bisection identified
> the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_".
> The commit ID is worthless as it's a linux-next commit. One of the changes
> in that patch looks very suspicious. Reverting the full patch fixes boot
> as does this fixlet.
I already acked a patch like this today.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix
2014-09-08 22:06 [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix Mel Gorman
2014-09-08 22:14 ` Tejun Heo
2014-09-08 23:46 ` Christoph Lameter
@ 2014-09-09 0:21 ` David Rientjes
2 siblings, 0 replies; 6+ messages in thread
From: David Rientjes @ 2014-09-09 0:21 UTC (permalink / raw)
To: Mel Gorman; +Cc: Christoph Lameter, Tejun Heo, LKML
On Mon, 8 Sep 2014, Mel Gorman wrote:
> A commit in linux-next was causing boot to fail and bisection identified
> the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_".
> The commit ID is worthless as it's a linux-next commit. One of the changes
> in that patch looks very suspicious. Reverting the full patch fixes boot
> as does this fixlet.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
I assume that since this is ipi_mask_ptr that the boot hangs instead of
doing anything else.
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix
2014-09-08 23:46 ` Christoph Lameter
@ 2014-09-09 0:35 ` Tejun Heo
2014-09-09 5:55 ` Ted Percival
0 siblings, 1 reply; 6+ messages in thread
From: Tejun Heo @ 2014-09-09 0:35 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Mel Gorman, LKML
On Mon, Sep 08, 2014 at 06:46:47PM -0500, Christoph Lameter wrote:
> On Mon, 8 Sep 2014, Mel Gorman wrote:
>
> > A commit in linux-next was causing boot to fail and bisection identified
> > the patch "percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_".
> > The commit ID is worthless as it's a linux-next commit. One of the changes
> > in that patch looks very suspicious. Reverting the full patch fixes boot
> > as does this fixlet.
>
> I already acked a patch like this today.
It isn't in my inbox.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix
2014-09-09 0:35 ` Tejun Heo
@ 2014-09-09 5:55 ` Ted Percival
0 siblings, 0 replies; 6+ messages in thread
From: Ted Percival @ 2014-09-09 5:55 UTC (permalink / raw)
To: linux-kernel
Tejun Heo <tj <at> kernel.org> writes:
> On Mon, Sep 08, 2014 at 06:46:47PM -0500, Christoph Lameter wrote:
> > I already acked a patch like this today.
>
> It isn't in my inbox.
It was "[PATCH] x86, apic: Fix unmasked CPU initialization"
<http://www.spinics.net/lists/kernel/msg1820725.html>
Sorry you weren't included; I used get_maintainer.pl for the recipient list.
I also posted it with a smaller recipient list including you on Friday under
the title
"[PATCH] x86: Restore missing cpumask_copy() in __x2apic_send_IPI_mask"
<http://www.spinics.net/lists/kernel/msg1819784.html>
Good to see it's solved now anyway. Since I've been using the same patch for
the last few days,
Tested-by: Ted Percival <ted@tedp.id.au>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-09 6:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-08 22:06 [PATCH] percpu: Resolve ambiguities in __get_cpu_var/cpumask_var_t -fix Mel Gorman
2014-09-08 22:14 ` Tejun Heo
2014-09-08 23:46 ` Christoph Lameter
2014-09-09 0:35 ` Tejun Heo
2014-09-09 5:55 ` Ted Percival
2014-09-09 0:21 ` David Rientjes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).