* [PATCH] drm/amd/display: remove unnecessary conditional operators
@ 2021-11-02 7:01 cgel.zte
2021-11-02 8:58 ` Simon Ser
0 siblings, 1 reply; 3+ messages in thread
From: cgel.zte @ 2021-11-02 7:01 UTC (permalink / raw)
To: harry.wentland
Cc: sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel,
nicholas.kazlauskas, qingqing.zhuo, contact, aurabindo.pillai,
Wayne.Lin, shenshih, nikola.cornij, Roman.Li, Anson.Jacob,
Aric.Cyr, meenakshikumar.somasundaram, jiapeng.chong,
george.shen, syed.hassan, lee.jones, ye.guojin, amd-gfx,
dri-devel, linux-kernel, Zeal Robot
From: Ye Guojin <ye.guojin@zte.com.cn>
Since the variables named is_end_of_payload and hpd_status are already
bool type, the ?: conditional operator is unnecessary any more.
Clean them up here.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 43e983e42c0f..752a79724ce1 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -784,8 +784,7 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
plink = adev->dm.dc->links[notify.link_index];
if (plink) {
plink->hpd_status =
- notify.hpd_status ==
- DP_HPD_PLUG ? true : false;
+ notify.hpd_status == DP_HPD_PLUG;
}
}
queue_work(adev->dm.delayed_hpd_wq, &dmub_hpd_wrk->handle_hpd_work);
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
index 60539b1f2a80..24dc662ec3e4 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c
@@ -626,7 +626,7 @@ bool dal_ddc_submit_aux_command(struct ddc_service *ddc,
do {
struct aux_payload current_payload;
bool is_end_of_payload = (retrieved + DEFAULT_AUX_MAX_DATA_SIZE) >=
- payload->length ? true : false;
+ payload->length;
uint32_t payload_length = is_end_of_payload ?
payload->length - retrieved : DEFAULT_AUX_MAX_DATA_SIZE;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: remove unnecessary conditional operators
2021-11-02 7:01 [PATCH] drm/amd/display: remove unnecessary conditional operators cgel.zte
@ 2021-11-02 8:58 ` Simon Ser
2021-11-02 18:41 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Simon Ser @ 2021-11-02 8:58 UTC (permalink / raw)
To: cgel.zte
Cc: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel,
nicholas.kazlauskas, qingqing.zhuo, aurabindo.pillai, Wayne.Lin,
shenshih, nikola.cornij, Roman.Li, Anson.Jacob, Aric.Cyr,
meenakshikumar.somasundaram, jiapeng.chong, george.shen,
syed.hassan, lee.jones, ye.guojin, amd-gfx, dri-devel,
linux-kernel, Zeal Robot
Reviewed-by: Simon Ser <contact@emersion.fr>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: remove unnecessary conditional operators
2021-11-02 8:58 ` Simon Ser
@ 2021-11-02 18:41 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2021-11-02 18:41 UTC (permalink / raw)
To: Simon Ser
Cc: CGEL, Dave Airlie, Maling list - DRI developers, LKML,
Meenakshikumar Somasundaram, Lee Jones, Jiapeng Chong,
Zeal Robot, Siqueira, Rodrigo, syed.hassan, amd-gfx list,
Leo (Sunpeng) Li, Aurabindo Pillai, George Shen, Anson Jacob,
Nikola Cornij, ye.guojin, Jude Shih, Qingqing Zhuo, xinhui pan,
Roman Li, Christian Koenig, Wayne Lin, Deucher, Alexander,
Kazlauskas, Nicholas
Applied. Thanks!
Alex
On Tue, Nov 2, 2021 at 4:58 AM Simon Ser <contact@emersion.fr> wrote:
>
> Reviewed-by: Simon Ser <contact@emersion.fr>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-02 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 7:01 [PATCH] drm/amd/display: remove unnecessary conditional operators cgel.zte
2021-11-02 8:58 ` Simon Ser
2021-11-02 18:41 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).