From: ebiederm@xmission.com (Eric W. Biederman)
To: "Peer Chen" <pchen@nvidia.com>
Cc: "peerchen" <peerchen@gmail.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"akpm" <akpm@linux-foundation.org>,
"Andy Currid" <ACurrid@nvidia.com>
Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability
Date: Mon, 07 Jan 2008 02:01:01 -0700 [thread overview]
Message-ID: <m163y6ko1e.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <15F501D1A78BD343BE8F4D8DB854566B1FD7D6B5@hkemmail01.nvidia.com> (Peer Chen's message of "Mon, 7 Jan 2008 13:32:28 +0800")
"Peer Chen" <pchen@nvidia.com> writes:
> Eric,
> Any decision for this patch, if not, currently we prefer to add all our
> code to quirks.c.
Sorry. I think adding the code to quirks.c is fine.
For bisection and code inspection purposes I would prefer the code
to come as a patchset of two patches. With the generic change
first.
I wanted to understand where you were coming from to make certain
I had not looked over something generic. The closest to generic
I can make of your concern is that we are doing useless work if
we know there is an upstream msi to irq mapper that we can just
tunnel to over hypertransport. At the generic level we can't know
that there is an upstream mapping capability as nothing reports
it, so we even if it is a good idea we can't do anything.
So a quirk looks fine to do what you are doing.
Just please next round handle the address part of the msi mapping
capability if it is present, in the x86 part of the generic code.
Just in case someone implements that.
Eric
next prev parent reply other threads:[~2008-01-07 9:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 15:00 [PATCH] msi: set 'En' bit of MSI Mapping Capability peerchen
2007-12-18 21:59 ` Eric W. Biederman
2007-12-20 13:43 ` Peer Chen
2007-12-20 22:48 ` Eric W. Biederman
2007-12-24 9:10 ` Peer Chen
2007-12-24 11:49 ` Eric W. Biederman
2008-01-02 9:57 ` Peer Chen
2008-01-07 5:32 ` Peer Chen
2008-01-07 9:01 ` Eric W. Biederman [this message]
2007-12-20 0:41 ` Andrew Morton
2007-12-20 0:45 ` Andrew Morton
2007-12-20 22:54 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m163y6ko1e.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ACurrid@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pchen@nvidia.com \
--cc=peerchen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).