From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@linux-foundation.org>
Cc: peerchen@gmail.com, linux-kernel@vger.kernel.org,
acurrid@nvidia.com, pchen@nvidia.com
Subject: Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability
Date: Thu, 20 Dec 2007 15:54:07 -0700 [thread overview]
Message-ID: <m17ij97zao.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20071219164555.1916fa42.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 19 Dec 2007 16:45:55 -0800")
Andrew Morton <akpm@linux-foundation.org> writes:
> On Wed, 19 Dec 2007 16:41:25 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
>> It would be better to just add a stub implementation of
>> ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp
>> tricks.
>
>
> And by this I really do mean going into each include/asm-*/pci.h and adding
>
>
> struct pci_dev; (if needed)
> ...
>
> static inline void ht_enable_msi_mapping(struct pci_dev *dev)
> {
> }
>
>
> no macros, no ifdef tricks, no include tricks. Just straight, clean, fully
> typechecked C.
Andrew thanks for the code style review. I goofed about recommending the
ARCH_HAVE_XXXX thing.
I'm going to concentrate on the content for the moment. I think we
are very close to a general solution to a very common problem with
MSI interrupts.
Eric
prev parent reply other threads:[~2007-12-20 22:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 15:00 [PATCH] msi: set 'En' bit of MSI Mapping Capability peerchen
2007-12-18 21:59 ` Eric W. Biederman
2007-12-20 13:43 ` Peer Chen
2007-12-20 22:48 ` Eric W. Biederman
2007-12-24 9:10 ` Peer Chen
2007-12-24 11:49 ` Eric W. Biederman
2008-01-02 9:57 ` Peer Chen
2008-01-07 5:32 ` Peer Chen
2008-01-07 9:01 ` Eric W. Biederman
2007-12-20 0:41 ` Andrew Morton
2007-12-20 0:45 ` Andrew Morton
2007-12-20 22:54 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17ij97zao.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=acurrid@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pchen@nvidia.com \
--cc=peerchen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).