2.5.X config: USB speedtouch driver

2.5.X config: USB speedtouch driver

[Bob_Tracy]

Minor nit: the subject driver depends on ATM, so a config-time check to
see if ATM support is enabled is appropriate.

-- 
-----------------------------------------------------------------------
Bob Tracy                   WTO + WIPO = DMCA? http://www.anti-dmca.org
rct@frus.com
-----------------------------------------------------------------------

Re: 2.5.X config: USB speedtouch driver

[Greg KH]

On Tue, Sep 10, 2002 at 01:53:45PM -0500, Bob_Tracy wrote:
> Minor nit: the subject driver depends on ATM, so a config-time check to
> see if ATM support is enabled is appropriate.

Agreed, patch? :)

greg k-h

Re: 2.5.X config: USB speedtouch driver

[Bob_Tracy]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Greg KH wrote:
> On Tue, Sep 10, 2002 at 01:53:45PM -0500, Bob_Tracy wrote:
> > Minor nit: the subject driver depends on ATM, so a config-time check to
> > see if ATM support is enabled is appropriate.
> 
> Agreed, patch? :)

Ok.  You shamed me into it :-).  If I understand how dep_tristate works,
the attached one-liner should do the trick.  Sorry for doing this as an
attachment, but I've seen my mailer mangle stuff when I try to include
it in-line :-(.

-- 
-----------------------------------------------------------------------
Bob Tracy                   WTO + WIPO = DMCA? http://www.anti-dmca.org
rct@frus.com
-----------------------------------------------------------------------

[-- Attachment #2: patch34_usbmisc --]
[-- Type: text/plain, Size: 640 bytes --]

--- linux/drivers/usb/misc/Config.in.orig	Wed Aug 28 21:02:04 2002
+++ linux/drivers/usb/misc/Config.in	Tue Sep 10 14:39:38 2002
@@ -8,4 +8,4 @@
 dep_tristate '  USB Diamond Rio500 support (EXPERIMENTAL)' CONFIG_USB_RIO500 $CONFIG_USB $CONFIG_EXPERIMENTAL
 dep_tristate '  Tieman Voyager USB Braille display support (EXPERIMENTAL)' CONFIG_USB_BRLVGER $CONFIG_USB $CONFIG_EXPERIMENTAL
 dep_tristate '  USB LCD driver support' CONFIG_USB_LCD $CONFIG_USB
-dep_tristate '  Alcatel Speedtouch ADSL USB Modem' CONFIG_USB_SPEEDTOUCH $CONFIG_USB    
+dep_tristate '  Alcatel Speedtouch ADSL USB Modem' CONFIG_USB_SPEEDTOUCH $CONFIG_USB $CONFIG_ATM

Re: 2.5.X config: USB speedtouch driver

[Greg KH]

On Tue, Sep 10, 2002 at 02:44:37PM -0500, Bob_Tracy wrote:
> Greg KH wrote:
> > On Tue, Sep 10, 2002 at 01:53:45PM -0500, Bob_Tracy wrote:
> > > Minor nit: the subject driver depends on ATM, so a config-time check to
> > > see if ATM support is enabled is appropriate.
> > 
> > Agreed, patch? :)
> 
> Ok.  You shamed me into it :-).  If I understand how dep_tristate works,
> the attached one-liner should do the trick.  Sorry for doing this as an
> attachment, but I've seen my mailer mangle stuff when I try to include
> it in-line :-(.

Looks good, I've applied this to my tree.

thanks,

greg k-h