* [PATCH] Minor Kexec bug fix (2.6.11-rc2-mm2)
@ 2005-02-02 13:56 Vivek Goyal
2005-02-03 0:07 ` [Fastboot] " Randy.Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Vivek Goyal @ 2005-02-02 13:56 UTC (permalink / raw)
To: Andrew Morton, lkml, fastboot
[-- Attachment #1: Type: text/plain, Size: 119 bytes --]
Hi Andrew,
This patch has been generated against 2.6.11-rc2-mm2. This fixes a very
minor bug in kexec.
Thanks
Vivek
[-- Attachment #2: kexec_minor_bug_fix.patch --]
[-- Type: text/plain, Size: 796 bytes --]
This patch fixes a minor bug in kexec. Changing the data type of flags makes
sure proper control flow of code during crash event.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
---
linux-2.6.11-rc2-mm2-kdump-vivek/include/linux/kexec.h | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN include/linux/kexec.h~kexec_minor_bug_fix include/linux/kexec.h
--- linux-2.6.11-rc2-mm2-kdump/include/linux/kexec.h~kexec_minor_bug_fix 2005-02-02 16:28:18.000000000 +0530
+++ linux-2.6.11-rc2-mm2-kdump-vivek/include/linux/kexec.h 2005-02-02 16:29:01.000000000 +0530
@@ -79,7 +79,7 @@ struct kimage {
unsigned long control_page;
/* Flags to indicate special processing */
- int type : 1;
+ unsigned int type : 1;
#define KEXEC_TYPE_DEFAULT 0
#define KEXEC_TYPE_CRASH 1
};
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Fastboot] [PATCH] Minor Kexec bug fix (2.6.11-rc2-mm2)
2005-02-02 13:56 [PATCH] Minor Kexec bug fix (2.6.11-rc2-mm2) Vivek Goyal
@ 2005-02-03 0:07 ` Randy.Dunlap
2005-02-03 1:26 ` Eric W. Biederman
0 siblings, 1 reply; 3+ messages in thread
From: Randy.Dunlap @ 2005-02-03 0:07 UTC (permalink / raw)
To: Vivek Goyal; +Cc: Andrew Morton, lkml, fastboot
Vivek Goyal wrote:
> Hi Andrew,
>
> This patch has been generated against 2.6.11-rc2-mm2. This fixes a very
> minor bug in kexec.
Have you run sparse on a kexec-patched kernel tree?
I have, but not lately. It needed some s/0/NULL/ in several places,
but that was before the latest big changes...
> diff -puN include/linux/kexec.h~kexec_minor_bug_fix include/linux/kexec.h
> --- linux-2.6.11-rc2-mm2-kdump/include/linux/kexec.h~kexec_minor_bug_fix 2005-02-02 16:28:18.000000000 +0530
> +++ linux-2.6.11-rc2-mm2-kdump-vivek/include/linux/kexec.h 2005-02-02 16:29:01.000000000 +0530
> @@ -79,7 +79,7 @@ struct kimage {
> unsigned long control_page;
>
> /* Flags to indicate special processing */
> - int type : 1;
> + unsigned int type : 1;
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Fastboot] [PATCH] Minor Kexec bug fix (2.6.11-rc2-mm2)
2005-02-03 0:07 ` [Fastboot] " Randy.Dunlap
@ 2005-02-03 1:26 ` Eric W. Biederman
0 siblings, 0 replies; 3+ messages in thread
From: Eric W. Biederman @ 2005-02-03 1:26 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: Vivek Goyal, Andrew Morton, fastboot, lkml
"Randy.Dunlap" <rddunlap@osdl.org> writes:
> Vivek Goyal wrote:
> > Hi Andrew,
> > This patch has been generated against 2.6.11-rc2-mm2. This fixes a very
> > minor bug in kexec.
>
> Have you run sparse on a kexec-patched kernel tree?
> I have, but not lately. It needed some s/0/NULL/ in several places,
> but that was before the latest big changes...
I have been avoiding adding more but I have not done had a flag
day and killed them all either.
The one bit int bug was a stupid thinko in the new code.
Totally obvious when someone tried it, to use it.
I think I am about ready to provide a sysrq panic interface.
At least for testing that code path it would be good. And
if we actually have kernel core dumps it might be useful
beyond that.
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-03 1:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-02 13:56 [PATCH] Minor Kexec bug fix (2.6.11-rc2-mm2) Vivek Goyal
2005-02-03 0:07 ` [Fastboot] " Randy.Dunlap
2005-02-03 1:26 ` Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).