* [PATCH] CONFIG_INET depend on CONFIG_SYSCTL
@ 2007-06-12 7:38 Yoshinori Sato
2007-06-12 8:08 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Yoshinori Sato @ 2007-06-12 7:38 UTC (permalink / raw)
To: lkml
It cannot build with CONFIG_SYSCTL=n and CONFIG_INET=y.
In case of CONFIG_INET=y it should become CONFIG_SYSCTL=y.
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
diff --git a/net/Kconfig b/net/Kconfig
index f3de729..2e9a885 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -34,6 +34,7 @@ source "net/iucv/Kconfig"
config INET
bool "TCP/IP networking"
+ select SYSCTL
---help---
These are the protocols used on the Internet and on most local
Ethernets. It is highly recommended to say Y here (this will enlarge
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] CONFIG_INET depend on CONFIG_SYSCTL
2007-06-12 7:38 [PATCH] CONFIG_INET depend on CONFIG_SYSCTL Yoshinori Sato
@ 2007-06-12 8:08 ` David Miller
2007-06-13 5:59 ` Yoshinori Sato
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2007-06-12 8:08 UTC (permalink / raw)
To: ysato; +Cc: linux-kernel, netdev
From: Yoshinori Sato <ysato@users.sourceforge.jp>
Date: Tue, 12 Jun 2007 16:38:55 +0900
> It cannot build with CONFIG_SYSCTL=n and CONFIG_INET=y.
> In case of CONFIG_INET=y it should become CONFIG_SYSCTL=y.
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
1) Please post networking patches to netdev@vger.kernel.org
which has been added to the CC:
2) It is much better to add the appropriate CONFIG_SYSCTL
ifdefs to the INET code than to force it on for everyone.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] CONFIG_INET depend on CONFIG_SYSCTL
2007-06-12 8:08 ` David Miller
@ 2007-06-13 5:59 ` Yoshinori Sato
2007-06-13 6:05 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Yoshinori Sato @ 2007-06-13 5:59 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, netdev
At Tue, 12 Jun 2007 01:08:55 -0700 (PDT),
David Miller wrote:
>
> From: Yoshinori Sato <ysato@users.sourceforge.jp>
> Date: Tue, 12 Jun 2007 16:38:55 +0900
>
> > It cannot build with CONFIG_SYSCTL=n and CONFIG_INET=y.
> > In case of CONFIG_INET=y it should become CONFIG_SYSCTL=y.
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
>
> 1) Please post networking patches to netdev@vger.kernel.org
> which has been added to the CC:
It was understood.
> 2) It is much better to add the appropriate CONFIG_SYSCTL
> ifdefs to the INET code than to force it on for everyone.
It examined that, but many corrections become necessary.
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] CONFIG_INET depend on CONFIG_SYSCTL
2007-06-13 5:59 ` Yoshinori Sato
@ 2007-06-13 6:05 ` David Miller
2007-06-22 7:42 ` Yoshinori Sato
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2007-06-13 6:05 UTC (permalink / raw)
To: ysato; +Cc: linux-kernel, netdev
From: Yoshinori Sato <ysato@users.sourceforge.jp>
Date: Wed, 13 Jun 2007 14:59:16 +0900
> At Tue, 12 Jun 2007 01:08:55 -0700 (PDT),
> David Miller wrote:
>
> > 2) It is much better to add the appropriate CONFIG_SYSCTL
> > ifdefs to the INET code than to force it on for everyone.
>
> It examined that, but many corrections become necessary.
I understand, but embedded people will not be happy that
SYSFS is a requirement for IPV4 networking. Every little
bit of space savings matters for them.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] CONFIG_INET depend on CONFIG_SYSCTL
2007-06-13 6:05 ` David Miller
@ 2007-06-22 7:42 ` Yoshinori Sato
0 siblings, 0 replies; 5+ messages in thread
From: Yoshinori Sato @ 2007-06-22 7:42 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, netdev
At Tue, 12 Jun 2007 23:05:45 -0700 (PDT),
David Miller wrote:
>
> From: Yoshinori Sato <ysato@users.sourceforge.jp>
> Date: Wed, 13 Jun 2007 14:59:16 +0900
>
> > At Tue, 12 Jun 2007 01:08:55 -0700 (PDT),
> > David Miller wrote:
> >
> > > 2) It is much better to add the appropriate CONFIG_SYSCTL
> > > ifdefs to the INET code than to force it on for everyone.
> >
> > It examined that, but many corrections become necessary.
>
> I understand, but embedded people will not be happy that
> SYSFS is a requirement for IPV4 networking. Every little
> bit of space savings matters for them.
A reply became late, sorry.
I do not check it in detail, but there seem to be part a few
depending SYSFS.
I need to check whether can separate a SYSFS depending part.
It may take time, but tries to check it.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-06-22 7:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-12 7:38 [PATCH] CONFIG_INET depend on CONFIG_SYSCTL Yoshinori Sato
2007-06-12 8:08 ` David Miller
2007-06-13 5:59 ` Yoshinori Sato
2007-06-13 6:05 ` David Miller
2007-06-22 7:42 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).