* [PATCH] media: imx7-media-csi: Remove unneeded break after return
@ 2019-06-30 3:49 Chinmaya Krishnan Mahesh
2019-07-01 9:44 ` Rui Miguel Silva
0 siblings, 1 reply; 2+ messages in thread
From: Chinmaya Krishnan Mahesh @ 2019-06-30 3:49 UTC (permalink / raw)
Cc: Chinmaya Krishnan Mahesh, Rui Miguel Silva, Steve Longerbeam,
Philipp Zabel, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-media, devel, linux-arm-kernel,
linux-kernel
This patch fixes the checkpatch.pl warning:
WARNING: break is not useful after a goto or return
Signed-off-by: Chinmaya Krishnan Mahesh <chinmaya.mahesh@disroot.org>
---
drivers/staging/media/imx/imx7-media-csi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
index a708a0340eb1..c15acca1dc0d 100644
--- a/drivers/staging/media/imx/imx7-media-csi.c
+++ b/drivers/staging/media/imx/imx7-media-csi.c
@@ -1021,7 +1021,6 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi,
break;
default:
return -EINVAL;
- break;
}
return 0;
}
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: imx7-media-csi: Remove unneeded break after return
2019-06-30 3:49 [PATCH] media: imx7-media-csi: Remove unneeded break after return Chinmaya Krishnan Mahesh
@ 2019-07-01 9:44 ` Rui Miguel Silva
0 siblings, 0 replies; 2+ messages in thread
From: Rui Miguel Silva @ 2019-07-01 9:44 UTC (permalink / raw)
To: Chinmaya Krishnan Mahesh
Cc: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-media, devel, linux-arm-kernel, linux-kernel
Hi Chinmaya,
Thanks for your patch.
On Sun 30 Jun 2019 at 04:49, Chinmaya Krishnan Mahesh wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: break is not useful after a goto or return
but this is already fixed in the media subsystem tree, by a patch
from Fabio:
964fcacddf media: imx7-media-csi: Remove unneeded break
It is better to use that tree as reference for media fixes,
sometimes some are already fixed there.
Nevertheless many thanks for the patch.
---
Cheers,
Rui
>
> Signed-off-by: Chinmaya Krishnan Mahesh <chinmaya.mahesh@disroot.org>
> ---
> drivers/staging/media/imx/imx7-media-csi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
> index a708a0340eb1..c15acca1dc0d 100644
> --- a/drivers/staging/media/imx/imx7-media-csi.c
> +++ b/drivers/staging/media/imx/imx7-media-csi.c
> @@ -1021,7 +1021,6 @@ static int imx7_csi_try_fmt(struct imx7_csi *csi,
> break;
> default:
> return -EINVAL;
> - break;
> }
> return 0;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-01 9:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-30 3:49 [PATCH] media: imx7-media-csi: Remove unneeded break after return Chinmaya Krishnan Mahesh
2019-07-01 9:44 ` Rui Miguel Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).