From: firstname.lastname@example.org (Krzysztof Hałasa) To: Arnd Bergmann <email@example.com> Cc: Bjorn Helgaas <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow" Date: Fri, 10 Jun 2016 12:10:14 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <7440319.e8dDgNlZLB@wuerfel> (Arnd Bergmann's message of "Thu, 09 Jun 2016 16:42:03 +0200") Arnd Bergmann <firstname.lastname@example.org> writes: > Before that, we were always setting both mrrs and mps. As we don't know > who uses PCIE_BUS_PEER2PEER, maybe another option would be to add yet > another pcie_bus_config value for this particular quirk? It would be a safe approach. Or, maybe another non-pcie_bus_config thing, I don't know (so the pcie_bus_config is left for the user). > I started the DT conversion a long time ago (see the DT parsing in > arch/arm/mach-cns3xxx/core.c) but I never had any hardware to test > on, and it was at a time when we didn't even have DT support in all > the subsystems. > > I'd definitely help you get the rest of the DT support in place if > you can test it. This is now the only SMP platform and one of > the last users of GIC and l2x0 that does not use DT, so I'd love > to see that converted just so we can remove the legacy probing from > those drivers. Ok. Is there a DT skeleton file somewhere, so I can try to boot the board (without Laguna extras) in DT mode? At first, I only need CPU + RAM + console serial port. > Converting what we have in mainline should be fairly straightforward, > but there is more code in > target/linux/cns3xxx/files/arch/arm/mach-cns3xxx/laguna.c that requires > more work, in particular we need to come up with a way to handle > the laguna_net_data and laguna_info structures, which have some of > the same data that is normall in DT. I assume adding this to U-Boot should be acceptable (for Gateworks, too). They are already doing this to their i.MX6 line Ventana. > Also, the gpio driver doesn't > have a trivial conversion to DT and requires some work to define > a binding and implement that. GPIO is a bit less important ATM, since the boards can boot without it. -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2016-06-10 10:10 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-31 21:58 Bjorn Helgaas 2016-05-31 22:02 ` Bjorn Helgaas 2016-06-01 11:08 ` Krzysztof Hałasa 2016-06-01 21:09 ` Arnd Bergmann 2016-06-09 5:42 ` Krzysztof Hałasa 2016-06-09 14:42 ` Arnd Bergmann 2016-06-10 10:10 ` Krzysztof Hałasa [this message] 2016-06-10 21:57 ` Arnd Bergmann 2016-06-16 4:39 ` Krzysztof Hałasa 2016-06-09 17:01 ` Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] Revert "ARM: cns3xxx: pci: avoid potential stack overflow"' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).