* [PATCH] RISC-V: cpuidle: fix Kconfig select for RISCV_SBI_CPUIDLE
@ 2022-04-09 22:53 Randy Dunlap
2022-04-10 3:14 ` Anup Patel
2022-04-21 22:28 ` Palmer Dabbelt
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2022-04-09 22:53 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Anup Patel, Anup Patel,
Anup Patel, Palmer Dabbelt, linux-pm, linux-riscv, Paul Walmsley,
Palmer Dabbelt, Albert Ou
There can be lots of build errors when building cpuidle-riscv-sbi.o.
They are all caused by a kconfig problem with this warning:
WARNING: unmet direct dependencies detected for RISCV_SBI_CPUIDLE
Depends on [n]: CPU_IDLE [=y] && RISCV [=y] && RISCV_SBI [=n]
Selected by [y]:
- SOC_VIRT [=y] && CPU_IDLE [=y]
so make the 'select' of RISCV_SBI_CPUIDLE also depend on RISCV_SBI.
Fixes: c5179ef1ca0c ("RISC-V: Enable RISC-V SBI CPU Idle driver for QEMU virt machine")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Anup Patel <anup.patel@wdc.com>
Cc: Anup Patel <apatel@ventanamicro.com>
Cc: Anup Patel <anup@brainfault.org>
Cc: Palmer Dabbelt <palmer@rivosinc.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-riscv@lists.infradead.org
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
---
arch/riscv/Kconfig.socs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -38,7 +38,7 @@ config SOC_VIRT
select SIFIVE_PLIC
select PM_GENERIC_DOMAINS if PM
select PM_GENERIC_DOMAINS_OF if PM && OF
- select RISCV_SBI_CPUIDLE if CPU_IDLE
+ select RISCV_SBI_CPUIDLE if CPU_IDLE && RISCV_SBI
help
This enables support for QEMU Virt Machine.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: cpuidle: fix Kconfig select for RISCV_SBI_CPUIDLE
2022-04-09 22:53 [PATCH] RISC-V: cpuidle: fix Kconfig select for RISCV_SBI_CPUIDLE Randy Dunlap
@ 2022-04-10 3:14 ` Anup Patel
2022-04-21 22:28 ` Palmer Dabbelt
1 sibling, 0 replies; 3+ messages in thread
From: Anup Patel @ 2022-04-10 3:14 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel@vger.kernel.org List, kernel test robot, Anup Patel,
Palmer Dabbelt, open list:THERMAL, linux-riscv, Paul Walmsley,
Palmer Dabbelt, Albert Ou
On Sun, Apr 10, 2022 at 4:23 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> There can be lots of build errors when building cpuidle-riscv-sbi.o.
> They are all caused by a kconfig problem with this warning:
>
> WARNING: unmet direct dependencies detected for RISCV_SBI_CPUIDLE
> Depends on [n]: CPU_IDLE [=y] && RISCV [=y] && RISCV_SBI [=n]
> Selected by [y]:
> - SOC_VIRT [=y] && CPU_IDLE [=y]
>
> so make the 'select' of RISCV_SBI_CPUIDLE also depend on RISCV_SBI.
>
> Fixes: c5179ef1ca0c ("RISC-V: Enable RISC-V SBI CPU Idle driver for QEMU virt machine")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Anup Patel <anup.patel@wdc.com>
> Cc: Anup Patel <apatel@ventanamicro.com>
> Cc: Anup Patel <anup@brainfault.org>
> Cc: Palmer Dabbelt <palmer@rivosinc.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-riscv@lists.infradead.org
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
Looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Regards,
Anup
> ---
> arch/riscv/Kconfig.socs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -38,7 +38,7 @@ config SOC_VIRT
> select SIFIVE_PLIC
> select PM_GENERIC_DOMAINS if PM
> select PM_GENERIC_DOMAINS_OF if PM && OF
> - select RISCV_SBI_CPUIDLE if CPU_IDLE
> + select RISCV_SBI_CPUIDLE if CPU_IDLE && RISCV_SBI
> help
> This enables support for QEMU Virt Machine.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: cpuidle: fix Kconfig select for RISCV_SBI_CPUIDLE
2022-04-09 22:53 [PATCH] RISC-V: cpuidle: fix Kconfig select for RISCV_SBI_CPUIDLE Randy Dunlap
2022-04-10 3:14 ` Anup Patel
@ 2022-04-21 22:28 ` Palmer Dabbelt
1 sibling, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2022-04-21 22:28 UTC (permalink / raw)
To: rdunlap
Cc: linux-kernel, rdunlap, lkp, anup, apatel, anup, linux-pm,
linux-riscv, Paul Walmsley, aou
On Sat, 09 Apr 2022 15:53:17 PDT (-0700), rdunlap@infradead.org wrote:
> There can be lots of build errors when building cpuidle-riscv-sbi.o.
> They are all caused by a kconfig problem with this warning:
>
> WARNING: unmet direct dependencies detected for RISCV_SBI_CPUIDLE
> Depends on [n]: CPU_IDLE [=y] && RISCV [=y] && RISCV_SBI [=n]
> Selected by [y]:
> - SOC_VIRT [=y] && CPU_IDLE [=y]
>
> so make the 'select' of RISCV_SBI_CPUIDLE also depend on RISCV_SBI.
>
> Fixes: c5179ef1ca0c ("RISC-V: Enable RISC-V SBI CPU Idle driver for QEMU virt machine")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Anup Patel <anup.patel@wdc.com>
> Cc: Anup Patel <apatel@ventanamicro.com>
> Cc: Anup Patel <anup@brainfault.org>
> Cc: Palmer Dabbelt <palmer@rivosinc.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-riscv@lists.infradead.org
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> ---
> arch/riscv/Kconfig.socs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -38,7 +38,7 @@ config SOC_VIRT
> select SIFIVE_PLIC
> select PM_GENERIC_DOMAINS if PM
> select PM_GENERIC_DOMAINS_OF if PM && OF
> - select RISCV_SBI_CPUIDLE if CPU_IDLE
> + select RISCV_SBI_CPUIDLE if CPU_IDLE && RISCV_SBI
> help
> This enables support for QEMU Virt Machine.
Sorry to be slow here, I seem to remember having written this before but
I must have just gotted pulled into something else.
IMO the real bug here is that Kconfig.socs is poorly designed: I
misunderstood how select works at the time, we should really clean all
this up (or maybe just remove it entirely?) so we don't have to
duplicate all these dependencies.
That's a bigger project, though so this is on fixes -- it's way better
to have the build work.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-21 22:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-09 22:53 [PATCH] RISC-V: cpuidle: fix Kconfig select for RISCV_SBI_CPUIDLE Randy Dunlap
2022-04-10 3:14 ` Anup Patel
2022-04-21 22:28 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).