* [PATCH] riscv: vdso: drop unnecessary cc-ldoption
@ 2019-04-23 21:22 Nick Desaulniers
2019-04-24 6:20 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Nick Desaulniers @ 2019-04-23 21:22 UTC (permalink / raw)
To: palmer, aou
Cc: Nick Desaulniers, clang-built-linux, Masahiro Yamada,
Arnd Bergmann, Aurelien Jarno, linux-riscv, linux-kernel
Towards the goal of removing cc-ldoption, it seems that --hash-style=
was added to binutils 2.17.50.0.2 in 2006. The minimal required version
of binutils for the kernel according to
Documentation/process/changes.rst is 2.20.
Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html
Cc: clang-built-linux@googlegroups.com
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/riscv/kernel/vdso/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
index fec62b24df89..b07b765f312a 100644
--- a/arch/riscv/kernel/vdso/Makefile
+++ b/arch/riscv/kernel/vdso/Makefile
@@ -36,7 +36,7 @@ $(obj)/vdso.so.dbg: $(src)/vdso.lds $(obj-vdso) FORCE
# these symbols in the kernel code rather than hand-coded addresses.
SYSCFLAGS_vdso.so.dbg = -shared -s -Wl,-soname=linux-vdso.so.1 \
- $(call cc-ldoption, -Wl$(comma)--hash-style=both)
+ -Wl,--hash-style=both
$(obj)/vdso-dummy.o: $(src)/vdso.lds $(obj)/rt_sigreturn.o FORCE
$(call if_changed,vdsold)
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: vdso: drop unnecessary cc-ldoption
2019-04-23 21:22 [PATCH] riscv: vdso: drop unnecessary cc-ldoption Nick Desaulniers
@ 2019-04-24 6:20 ` Christoph Hellwig
2019-04-29 23:40 ` Palmer Dabbelt
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2019-04-24 6:20 UTC (permalink / raw)
To: Nick Desaulniers
Cc: palmer, aou, Arnd Bergmann, Masahiro Yamada, linux-kernel,
clang-built-linux, linux-riscv, Aurelien Jarno
On Tue, Apr 23, 2019 at 02:22:53PM -0700, Nick Desaulniers wrote:
> Towards the goal of removing cc-ldoption, it seems that --hash-style=
> was added to binutils 2.17.50.0.2 in 2006. The minimal required version
> of binutils for the kernel according to
> Documentation/process/changes.rst is 2.20.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: vdso: drop unnecessary cc-ldoption
2019-04-24 6:20 ` Christoph Hellwig
@ 2019-04-29 23:40 ` Palmer Dabbelt
0 siblings, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2019-04-29 23:40 UTC (permalink / raw)
To: ndesaulniers, Christoph Hellwig
Cc: ndesaulniers, aou, Arnd Bergmann, yamada.masahiro, linux-kernel,
clang-built-linux, linux-riscv, aurelien
On Tue, 23 Apr 2019 23:20:20 PDT (-0700), Christoph Hellwig wrote:
> On Tue, Apr 23, 2019 at 02:22:53PM -0700, Nick Desaulniers wrote:
>> Towards the goal of removing cc-ldoption, it seems that --hash-style=
>> was added to binutils 2.17.50.0.2 in 2006. The minimal required version
>> of binutils for the kernel according to
>> Documentation/process/changes.rst is 2.20.
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks! This in on for-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-29 23:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 21:22 [PATCH] riscv: vdso: drop unnecessary cc-ldoption Nick Desaulniers
2019-04-24 6:20 ` Christoph Hellwig
2019-04-29 23:40 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).