From: Palmer Dabbelt <palmer@sifive.com>
To: schwab@suse.de
Cc: Christoph Hellwig <hch@lst.de>,
Greg KH <gregkh@linuxfoundation.org>,
jslaby@suse.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] serial/sifive: select SERIAL_EARLYCON
Date: Mon, 16 Sep 2019 14:38:39 -0700 (PDT) [thread overview]
Message-ID: <mhng-5091669f-461c-4e62-a71c-e16957801fad@palmer-si-x1c4> (raw)
In-Reply-To: <87ftkwdo85.fsf@igel.home>
On Mon, 16 Sep 2019 12:40:10 PDT (-0700), schwab@suse.de wrote:
> On Sep 16 2019, Palmer Dabbelt <palmer@sifive.com> wrote:
>
>> On Sun, 15 Sep 2019 23:42:53 PDT (-0700), Christoph Hellwig wrote:
>>> On Fri, Sep 13, 2019 at 01:40:27PM -0700, Palmer Dabbelt wrote:
>>>> OpenEmbedded passes "earlycon=sbi", which I can find in the doumentation.
>>>> I can't find anything about just "earlycon". I've sent a patch adding sbi
>>>> to the list of earlycon arguments.
>>>
>>> earlycon without arguments is documented, although just for ARM64.
>>> I can send a patch to update it to properly cover all DT platforms
>>> in addition.
>>
>> Thanks. I've kind of lost track of the thread, but assuming that does the
>> "automatically pick an earlycon" stuff then that's probably what we should
>> be using in the distros.
>
> Except that it doesn't work.
Sorry, once again I've lost track of the thread.
The code looks generic. The device tree in arch/riscv for the HiFive Unleashed
doesn't have a stdout-path set, which if I understand correctly is used by the
automatic earlycon stuff to pick a console. I gave this a quick test on QEMU,
which finds a 16550 earlycon for me. I use openembedded's qemuriscv64 target,
the following diff to make sure I'm getting an earlycon
diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c
index 5cd8c36c8fcc..61290714bbcb 100644
--- a/drivers/tty/serial/8250/8250_early.c
+++ b/drivers/tty/serial/8250/8250_early.c
@@ -106,6 +106,7 @@ static void early_serial8250_write(struct console *console,
struct earlycon_device *device = console->data;
struct uart_port *port = &device->port;
+ uart_console_write(port, "_e_", 3, serial_putc);
uart_console_write(port, s, count, serial_putc);
}
and run this command line
/home/palmer/work/linux/openembedded-riscv64/build/tmp-glibc/work/x86_64-linux/qemu-helper-native/1.0-r1/recipe-sysroot-native/usr/bin/qemu-system-riscv64 -device virtio-net-device,netdev=net0,mac=52:54:00:12:35:02 -netdev user,id=net0,hostfwd=tcp::2222-:22,hostfwd=tcp::2323-:23,tftp=/home/palmer/work/linux/openembedded-riscv64/build/tmp-glibc/deploy/images/qemuriscv64 -drive id=disk0,file=/home/palmer/work/linux/openembedded-riscv64/build/tmp-glibc/deploy/images/qemuriscv64/core-image-full-cmdline-qemuriscv64-20190711162644.rootfs.ext4,if=none,format=raw -device virtio-blk-device,drive=disk0 -object rng-random,filename=/dev/urandom,id=rng0 -device virtio-rng-device,rng=rng0 -show-cursor -monitor null -device loader,file=/home/palmer/work/linux/linux/arch/riscv/boot/Image,addr=0x80200000 -nographic -machine virt -m 512 -serial mon:stdio -serial null -kernel /home/palmer/work/linux/openembedded-riscv64/build/tmp-glibc/deploy/images/qemuriscv64/fw_jump.elf -append 'root=/dev/vda
rw highres=off console=ttyS0 mem=512M ip=dhcp earlycon '
which gives me some early stuff and then some non-early stuff
_e_[ 0.407579] printk: console [ttyS0] disabled
_e_[ 0.409205] 10000000.uart: ttyS0 at MMIO 0x10000000 (irq = 10, base_baud = 230400) is a 16550A
[ 0.410720] printk: console [ttyS0] enabled
_e_[ 0.410720] printk: console [ttyS0] enabled
[ 0.411391] printk: bootconsole [ns16550a0] disabled
_e_[ 0.411391] printk: bootconsole [ns16550a0] disabled
[ 0.420664] [drm] radeon kernel modesetting enabled.
[ 0.428086] random: fast init done
[ 0.429331] random: crng init done
[ 0.440678] loop: module loaded
[ 0.447607] virtio_blk virtio1: [vda] 262830 512-byte logical blocks (135 MB/128 MiB)
[ 0.469483] libphy: Fixed MDIO Bus: probed
If you don't have something like "/chosen/stdout-path = &uart0;" in your device
tree, then that's probably the issue. Here's where it's set in Christoph's
k210:
http://git.infradead.org/users/hch/riscv.git/blob/f10e64873eafc68516b8884c06b9290b9887633b:/arch/riscv/boot/dts/kendryte/kd210.dts#l20
but we don't set it for the HiFive Unleashed. I'd call that a bug, something
like this
diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
index 93d68cbd64fe..6d0ec76d93fe 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
@@ -13,6 +13,7 @@
compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000";
chosen {
+ stdout-path = &uart0;
};
cpus {
should fix it. LMK if I've misunderstood something.
next prev parent reply other threads:[~2019-09-16 21:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 5:59 [PATCH] serial/sifive: select SERIAL_EARLYCON Christoph Hellwig
2019-09-10 6:57 ` Andreas Schwab
2019-09-10 7:05 ` Christoph Hellwig
2019-09-10 8:18 ` Andreas Schwab
2019-09-10 14:36 ` Christoph Hellwig
2019-09-10 14:42 ` Andreas Schwab
2019-09-13 20:40 ` Palmer Dabbelt
2019-09-16 6:42 ` Christoph Hellwig
2019-09-16 16:12 ` Palmer Dabbelt
2019-09-16 19:40 ` Andreas Schwab
2019-09-16 21:38 ` Palmer Dabbelt [this message]
2019-09-17 7:43 ` Andreas Schwab
2019-10-04 21:45 ` Atish Patra
2019-09-16 11:57 ` Paul Walmsley
2019-09-16 12:00 ` Andreas Schwab
2019-09-16 12:15 ` Christoph Hellwig
2019-09-16 12:18 ` Paul Walmsley
2019-09-16 12:22 ` Christoph Hellwig
2019-09-16 10:21 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-5091669f-461c-4e62-a71c-e16957801fad@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.walmsley@sifive.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).