From: Andreas Schwab <schwab@suse.de>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: Christoph Hellwig <hch@lst.de>,
Greg KH <gregkh@linuxfoundation.org>,
jslaby@suse.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] serial/sifive: select SERIAL_EARLYCON
Date: Tue, 17 Sep 2019 09:43:25 +0200 [thread overview]
Message-ID: <mvma7b3e5b6.fsf@suse.de> (raw)
In-Reply-To: <mhng-5091669f-461c-4e62-a71c-e16957801fad@palmer-si-x1c4> (Palmer Dabbelt's message of "Mon, 16 Sep 2019 14:38:39 -0700 (PDT)")
On Sep 16 2019, Palmer Dabbelt <palmer@sifive.com> wrote:
> but we don't set it for the HiFive Unleashed. I'd call that a bug,
> something like this
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> index 93d68cbd64fe..6d0ec76d93fe 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts
> @@ -13,6 +13,7 @@
> compatible = "sifive,hifive-unleashed-a00", "sifive,fu540-c000";
>
> chosen {
> + stdout-path = &uart0;
> };
>
> cpus {
>
> should fix it. LMK if I've misunderstood something.
If that's how it's supposed to work, ok. Other platforms add it in
u-boot.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2019-09-17 7:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 5:59 [PATCH] serial/sifive: select SERIAL_EARLYCON Christoph Hellwig
2019-09-10 6:57 ` Andreas Schwab
2019-09-10 7:05 ` Christoph Hellwig
2019-09-10 8:18 ` Andreas Schwab
2019-09-10 14:36 ` Christoph Hellwig
2019-09-10 14:42 ` Andreas Schwab
2019-09-13 20:40 ` Palmer Dabbelt
2019-09-16 6:42 ` Christoph Hellwig
2019-09-16 16:12 ` Palmer Dabbelt
2019-09-16 19:40 ` Andreas Schwab
2019-09-16 21:38 ` Palmer Dabbelt
2019-09-17 7:43 ` Andreas Schwab [this message]
2019-10-04 21:45 ` Atish Patra
2019-09-16 11:57 ` Paul Walmsley
2019-09-16 12:00 ` Andreas Schwab
2019-09-16 12:15 ` Christoph Hellwig
2019-09-16 12:18 ` Paul Walmsley
2019-09-16 12:22 ` Christoph Hellwig
2019-09-16 10:21 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvma7b3e5b6.fsf@suse.de \
--to=schwab@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).