* [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning
@ 2022-07-09 1:49 Randy Dunlap
2022-07-20 4:04 ` Guo Ren
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Randy Dunlap @ 2022-07-09 1:49 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Wei Fu, Liu Shaohua, Guo Ren, Heiko Stuebner,
Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv
RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
quieten this kconfig warning:
WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
Depends on [n]: !XIP_KERNEL [=y]
Selected by [y]:
- RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Wei Fu <wefu@redhat.com>
Cc: Liu Shaohua <liush@allwinnertech.com>
Cc: Guo Ren <guoren@kernel.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-riscv@lists.infradead.org
---
arch/riscv/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -362,6 +362,7 @@ config RISCV_ISA_C
config RISCV_ISA_SVPBMT
bool "SVPBMT extension support"
depends on 64BIT && MMU
+ depends on !XIP_KERNEL
select RISCV_ALTERNATIVE
default y
help
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning
2022-07-09 1:49 [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning Randy Dunlap
@ 2022-07-20 4:04 ` Guo Ren
2022-07-20 9:01 ` Heiko Stübner
2022-09-13 12:00 ` Heiko Stuebner
2 siblings, 0 replies; 6+ messages in thread
From: Guo Ren @ 2022-07-20 4:04 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linux Kernel Mailing List, Wei Fu, Liu Shaohua, Heiko Stuebner,
Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv
Reviewed-by: Guo Ren <guoren@kernel.org>
On Sat, Jul 9, 2022 at 9:49 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
> quieten this kconfig warning:
>
> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
> Depends on [n]: !XIP_KERNEL [=y]
> Selected by [y]:
> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>
> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Wei Fu <wefu@redhat.com>
> Cc: Liu Shaohua <liush@allwinnertech.com>
> Cc: Guo Ren <guoren@kernel.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
> ---
> arch/riscv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -362,6 +362,7 @@ config RISCV_ISA_C
> config RISCV_ISA_SVPBMT
> bool "SVPBMT extension support"
> depends on 64BIT && MMU
> + depends on !XIP_KERNEL
> select RISCV_ALTERNATIVE
> default y
> help
--
Best Regards
Guo Ren
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning
2022-07-09 1:49 [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning Randy Dunlap
2022-07-20 4:04 ` Guo Ren
@ 2022-07-20 9:01 ` Heiko Stübner
2022-09-13 12:00 ` Heiko Stuebner
2 siblings, 0 replies; 6+ messages in thread
From: Heiko Stübner @ 2022-07-20 9:01 UTC (permalink / raw)
To: linux-kernel, Randy Dunlap
Cc: Randy Dunlap, Wei Fu, Liu Shaohua, Guo Ren, Paul Walmsley,
Palmer Dabbelt, Albert Ou, linux-riscv
Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap:
> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
> quieten this kconfig warning:
>
> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
> Depends on [n]: !XIP_KERNEL [=y]
> Selected by [y]:
> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>
> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Wei Fu <wefu@redhat.com>
> Cc: Liu Shaohua <liush@allwinnertech.com>
> Cc: Guo Ren <guoren@kernel.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning
2022-07-09 1:49 [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning Randy Dunlap
2022-07-20 4:04 ` Guo Ren
2022-07-20 9:01 ` Heiko Stübner
@ 2022-09-13 12:00 ` Heiko Stuebner
2022-09-15 18:48 ` Palmer Dabbelt
2022-09-15 18:48 ` Palmer Dabbelt
2 siblings, 2 replies; 6+ messages in thread
From: Heiko Stuebner @ 2022-09-13 12:00 UTC (permalink / raw)
To: linux-kernel, Randy Dunlap
Cc: Randy Dunlap, Wei Fu, Liu Shaohua, Guo Ren, Paul Walmsley,
Palmer Dabbelt, Albert Ou, linux-riscv
Hi Palmer,
Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap:
> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
> quieten this kconfig warning:
>
> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
> Depends on [n]: !XIP_KERNEL [=y]
> Selected by [y]:
> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>
> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
I think this should also be applied as fix?
Thanks
Heiko
> Cc: Wei Fu <wefu@redhat.com>
> Cc: Liu Shaohua <liush@allwinnertech.com>
> Cc: Guo Ren <guoren@kernel.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
> ---
> arch/riscv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -362,6 +362,7 @@ config RISCV_ISA_C
> config RISCV_ISA_SVPBMT
> bool "SVPBMT extension support"
> depends on 64BIT && MMU
> + depends on !XIP_KERNEL
> select RISCV_ALTERNATIVE
> default y
> help
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning
2022-09-13 12:00 ` Heiko Stuebner
@ 2022-09-15 18:48 ` Palmer Dabbelt
2022-09-15 18:48 ` Palmer Dabbelt
1 sibling, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2022-09-15 18:48 UTC (permalink / raw)
To: heiko
Cc: linux-kernel, rdunlap, rdunlap, wefu, liush, guoren,
Paul Walmsley, aou, linux-riscv
On Tue, 13 Sep 2022 05:00:08 PDT (-0700), heiko@sntech.de wrote:
> Hi Palmer,
>
> Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap:
>> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
>> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
>> quieten this kconfig warning:
>>
>> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
>> Depends on [n]: !XIP_KERNEL [=y]
>> Selected by [y]:
>> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>>
>> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> I think this should also be applied as fix?
Thanks, the original seems to have gotten lost somewhere but I've picked
this up from lore.
>
> Thanks
> Heiko
>
>
>> Cc: Wei Fu <wefu@redhat.com>
>> Cc: Liu Shaohua <liush@allwinnertech.com>
>> Cc: Guo Ren <guoren@kernel.org>
>> Cc: Heiko Stuebner <heiko@sntech.de>
>> Cc: Paul Walmsley <paul.walmsley@sifive.com>
>> Cc: Palmer Dabbelt <palmer@dabbelt.com>
>> Cc: Albert Ou <aou@eecs.berkeley.edu>
>> Cc: linux-riscv@lists.infradead.org
>> ---
>> arch/riscv/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -362,6 +362,7 @@ config RISCV_ISA_C
>> config RISCV_ISA_SVPBMT
>> bool "SVPBMT extension support"
>> depends on 64BIT && MMU
>> + depends on !XIP_KERNEL
>> select RISCV_ALTERNATIVE
>> default y
>> help
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning
2022-09-13 12:00 ` Heiko Stuebner
2022-09-15 18:48 ` Palmer Dabbelt
@ 2022-09-15 18:48 ` Palmer Dabbelt
1 sibling, 0 replies; 6+ messages in thread
From: Palmer Dabbelt @ 2022-09-15 18:48 UTC (permalink / raw)
To: heiko
Cc: linux-kernel, rdunlap, rdunlap, wefu, liush, guoren,
Paul Walmsley, aou, linux-riscv
On Tue, 13 Sep 2022 05:00:08 PDT (-0700), heiko@sntech.de wrote:
> Hi Palmer,
>
> Am Samstag, 9. Juli 2022, 03:49:29 CEST schrieb Randy Dunlap:
>> RISCV_ISA_SVPBMT selects RISCV_ALTERNATIVE which depends on !XIP_KERNEL.
>> Therefore RISCV_ISA_SVPBMT should also depend on !XIP_KERNEL so
>> quieten this kconfig warning:
>>
>> WARNING: unmet direct dependencies detected for RISCV_ALTERNATIVE
>> Depends on [n]: !XIP_KERNEL [=y]
>> Selected by [y]:
>> - RISCV_ISA_SVPBMT [=y] && 64BIT [=y] && MMU [=y]
>>
>> Fixes: ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> I think this should also be applied as fix?
>
> Thanks
> Heiko
>
>
>> Cc: Wei Fu <wefu@redhat.com>
>> Cc: Liu Shaohua <liush@allwinnertech.com>
>> Cc: Guo Ren <guoren@kernel.org>
>> Cc: Heiko Stuebner <heiko@sntech.de>
>> Cc: Paul Walmsley <paul.walmsley@sifive.com>
>> Cc: Palmer Dabbelt <palmer@dabbelt.com>
>> Cc: Albert Ou <aou@eecs.berkeley.edu>
>> Cc: linux-riscv@lists.infradead.org
>> ---
>> arch/riscv/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -362,6 +362,7 @@ config RISCV_ISA_C
>> config RISCV_ISA_SVPBMT
>> bool "SVPBMT extension support"
>> depends on 64BIT && MMU
>> + depends on !XIP_KERNEL
>> select RISCV_ALTERNATIVE
>> default y
>> help
>>
Thanks, this is on fixes.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-15 18:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-09 1:49 [PATCH] riscv: fix RISCV_ISA_SVPBMT kconfig dependency warning Randy Dunlap
2022-07-20 4:04 ` Guo Ren
2022-07-20 9:01 ` Heiko Stübner
2022-09-13 12:00 ` Heiko Stuebner
2022-09-15 18:48 ` Palmer Dabbelt
2022-09-15 18:48 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).