From: Palmer Dabbelt <palmer@sifive.com>
To: zongbox@gmail.com
Cc: Christoph Hellwig <hch@infradead.org>,
zong@andestech.com, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, greentime@andestech.com
Subject: Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index and type for 32-bit
Date: Thu, 05 Jul 2018 09:42:29 -0700 (PDT) [thread overview]
Message-ID: <mhng-ace58b68-1a85-4109-b564-4e24179fa8a7@palmer-si-x1c4> (raw)
In-Reply-To: <CA+ZOyaggr-Y2-Yh_o4+XQLoT5-o6PM9m4_T3sHHUq13+CgJYEQ@mail.gmail.com>
On Thu, 05 Jul 2018 06:33:07 PDT (-0700), zongbox@gmail.com wrote:
> Palmer Dabbelt <palmer@sifive.com> 於 2018年7月5日 週四 上午4:58寫道：
>>
>> On Fri, 29 Jun 2018 09:53:49 PDT (-0700), zongbox@gmail.com wrote:
>> > Christoph Hellwig <hch@infradead.org> 於 2018年6月29日 週五 下午3:12寫道：
>> >>
>> >> On Mon, Jun 25, 2018 at 04:49:39PM +0800, Zong Li wrote:
>> >> > Use generic marco to get the index and type of symbol.
>> >>
>> >> Why do we even need this in a uapi header? Shouldn't ELF_RISCV_R_SYM
>> >> and ELF_RISCV_R_TYPE move to module.c? In that case we could just
>> >> use CONFIG_64BIT.
>> >
>> > Make sense. I even think the all definitions can be move to include/asm/elf.h.
>> > How do you think about that?
>>
>> Sorry I've been slow about reviewing this, but I think just in the interest of
>> getting a sane RV32I port up and running quickly (so we can try to get glibc in
>> shape) I'm going to take this for now.
>>
>> Do you mind submitting a cleanup patch?
>
> I will send a patch to clean up. Thanks everyone to review this patchset.
Well, thanks for doing the work :).
next prev parent reply other threads:[~2018-07-05 16:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 8:49 [PATCH v2 0/4] Building for 32-bit RISC-V kernel Zong Li
2018-06-25 8:49 ` [PATCH v2 1/4] RISC-V: Add conditional macro for zone of DMA32 Zong Li
2018-06-29 7:08 ` Christoph Hellwig
2018-06-25 8:49 ` [PATCH v2 2/4] RISC-V: Select GENERIC_UCMPDI2 on RV32I Zong Li
2018-06-29 7:08 ` Christoph Hellwig
2018-06-25 8:49 ` [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index and type for 32-bit Zong Li
2018-06-29 7:12 ` Christoph Hellwig
2018-06-29 16:53 ` Zong Li
2018-07-04 20:58 ` Palmer Dabbelt
2018-07-05 13:33 ` Zong Li
2018-07-05 16:42 ` Palmer Dabbelt [this message]
2018-06-25 8:49 ` [PATCH v2 4/4] RISC-V: Change variable type for 32-bit compatible Zong Li
2018-06-29 7:12 ` Christoph Hellwig
2018-06-29 7:23 ` [PATCH v2 0/4] Building for 32-bit RISC-V kernel Christoph Hellwig
2018-06-29 17:06 ` Zong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-ace58b68-1a85-4109-b564-4e24179fa8a7@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=greentime@andestech.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=zong@andestech.com \
--cc=zongbox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).