* [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check
@ 2015-10-30 18:22 tim.gardner
2015-10-30 19:28 ` Manoj Kumar
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: tim.gardner @ 2015-10-30 18:22 UTC (permalink / raw)
To: linux-scsi, linux-kernel
Cc: Tim Gardner, Jayamohan Kallickal, Minh Tran, John Soni Jose,
James E.J. Bottomley
From: Tim Gardner <tim.gardner@canonical.com>
drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
WARN_ON(!length > 0);
gcc version 5.2.1
Cc: Jayamohan Kallickal <jayamohan.kallickal@avagotech.com>
Cc: Minh Tran <minh.tran@avagotech.com>
Cc: John Soni Jose <sony.john-n@avagotech.com>
Cc: "James E.J. Bottomley" <JBottomley@odin.com>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 7a6dbfb..5cdcd29 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address,
{
WARN_ON(!virtual_address);
WARN_ON(!physical_address);
- WARN_ON(!length > 0);
+ WARN_ON(!length);
WARN_ON(!sgl);
sgl->va = virtual_address;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check
2015-10-30 18:22 [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check tim.gardner
@ 2015-10-30 19:28 ` Manoj Kumar
2015-10-30 20:59 ` Johannes Thumshirn
2015-11-12 1:28 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Manoj Kumar @ 2015-10-30 19:28 UTC (permalink / raw)
To: tim.gardner, linux-scsi, linux-kernel
Cc: Jayamohan Kallickal, Minh Tran, John Soni Jose, James E.J. Bottomley
Tim:
Reviewed-by: Manoj Kumar <manoj@linux.vnet.ibm.com>
---
Manoj Kumar
On 10/30/2015 1:22 PM, tim.gardner@canonical.com wrote:
> From: Tim Gardner <tim.gardner@canonical.com>
>
> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
> drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
> WARN_ON(!length > 0);
>
> gcc version 5.2.1
>
> Cc: Jayamohan Kallickal <jayamohan.kallickal@avagotech.com>
> Cc: Minh Tran <minh.tran@avagotech.com>
> Cc: John Soni Jose <sony.john-n@avagotech.com>
> Cc: "James E.J. Bottomley" <JBottomley@odin.com>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
> drivers/scsi/be2iscsi/be_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index 7a6dbfb..5cdcd29 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address,
> {
> WARN_ON(!virtual_address);
> WARN_ON(!physical_address);
> - WARN_ON(!length > 0);
> + WARN_ON(!length);
> WARN_ON(!sgl);
>
> sgl->va = virtual_address;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check
2015-10-30 18:22 [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check tim.gardner
2015-10-30 19:28 ` Manoj Kumar
@ 2015-10-30 20:59 ` Johannes Thumshirn
2015-11-01 15:43 ` Tim Gardner
2015-11-12 1:28 ` Martin K. Petersen
2 siblings, 1 reply; 5+ messages in thread
From: Johannes Thumshirn @ 2015-10-30 20:59 UTC (permalink / raw)
To: tim.gardner
Cc: linux-scsi, linux-kernel, Jayamohan Kallickal, Minh Tran,
John Soni Jose, James E.J. Bottomley
Hi Tim,
tim.gardner@canonical.com writes:
> From: Tim Gardner <tim.gardner@canonical.com>
>
> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
> drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
> WARN_ON(!length > 0);
>
> gcc version 5.2.1
This patch (or similar) was already posted on Oct 1 by Joel Stanley.
See http://comments.gmane.org/gmane.linux.scsi/105462
Thanks,
Johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check
2015-10-30 20:59 ` Johannes Thumshirn
@ 2015-11-01 15:43 ` Tim Gardner
0 siblings, 0 replies; 5+ messages in thread
From: Tim Gardner @ 2015-11-01 15:43 UTC (permalink / raw)
To: Johannes Thumshirn
Cc: linux-scsi, linux-kernel, Jayamohan Kallickal, Minh Tran,
John Soni Jose, James E.J. Bottomley
On 10/30/2015 02:59 PM, Johannes Thumshirn wrote:
> Hi Tim,
> tim.gardner@canonical.com writes:
>
>> From: Tim Gardner <tim.gardner@canonical.com>
>>
>> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
>> drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
>> WARN_ON(!length > 0);
>>
>> gcc version 5.2.1
>
> This patch (or similar) was already posted on Oct 1 by Joel Stanley.
> See http://comments.gmane.org/gmane.linux.scsi/105462
>
> Thanks,
> Johannes
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Mechanical application of prarens makes that expression more complicated
then it needs to be. It is, after all, an unsigned integer.
rtg
--
Tim Gardner tim.gardner@canonical.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check
2015-10-30 18:22 [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check tim.gardner
2015-10-30 19:28 ` Manoj Kumar
2015-10-30 20:59 ` Johannes Thumshirn
@ 2015-11-12 1:28 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2015-11-12 1:28 UTC (permalink / raw)
To: tim.gardner
Cc: linux-scsi, linux-kernel, Jayamohan Kallickal, Minh Tran,
John Soni Jose, James E.J. Bottomley
Applied.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-11-12 1:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-30 18:22 [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check tim.gardner
2015-10-30 19:28 ` Manoj Kumar
2015-10-30 20:59 ` Johannes Thumshirn
2015-11-01 15:43 ` Tim Gardner
2015-11-12 1:28 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).