From: Johannes Thumshirn <jthumshirn@suse.de>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH] power: bq27x00_battery: Destroy battery_id IDR on module exit
Date: Thu, 09 Jul 2015 09:07:40 +0200 [thread overview]
Message-ID: <mqdwpy9stab.fsf@c203.arch.suse.de> (raw)
In-Reply-To: <201507081810.14511@pali> ("Pali \=\?utf-8\?Q\?Roh\=C3\=A1r\=22's\?\= message of "Wed, 8 Jul 2015 18:10:14 +0200")
Pali Rohár <pali.rohar@gmail.com> writes:
> On Wednesday 08 July 2015 17:18:20 Johannes Thumshirn wrote:
>> Destroy battery_id IDR on module exit, reclaiming the allocated
>> memory.
>>
>> This was detected by the following semantic patch (written by Luis
>> Rodriguez <mcgrof@suse.com>)
>> <SmPL>
>> @ defines_module_init @
>> declarer name module_init, module_exit;
>> declarer name DEFINE_IDR;
>> identifier init;
>> @@
>>
>> module_init(init);
>>
>> @ defines_module_exit @
>> identifier exit;
>> @@
>>
>> module_exit(exit);
>>
>> @ declares_idr depends on defines_module_init && defines_module_exit
>> @ identifier idr;
>> @@
>>
>> DEFINE_IDR(idr);
>>
>> @ on_exit_calls_destroy depends on declares_idr &&
>> defines_module_exit @ identifier declares_idr.idr,
>> defines_module_exit.exit;
>> @@
>>
>> exit(void)
>> {
>> ...
>> idr_destroy(&idr);
>> ...
>> }
>>
>> @ missing_module_idr_destroy depends on declares_idr &&
>> defines_module_exit && !on_exit_calls_destroy @ identifier
>> declares_idr.idr, defines_module_exit.exit;
>> @@
>>
>> exit(void)
>> {
>> ...
>> +idr_destroy(&idr);
>> }
>> </SmPL>
>>
>> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
>> ---
>> drivers/power/bq27x00_battery.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/power/bq27x00_battery.c
>> b/drivers/power/bq27x00_battery.c index b6b9837..99180d2 100644
>> --- a/drivers/power/bq27x00_battery.c
>> +++ b/drivers/power/bq27x00_battery.c
>> @@ -1106,6 +1106,7 @@ static void __exit bq27x00_battery_exit(void)
>> {
>> bq27x00_battery_platform_exit();
>> bq27x00_battery_i2c_exit();
>> + idr_destroy(&battery_id);
>> }
>> module_exit(bq27x00_battery_exit);
>
> Hello, I see that none power supply kernel driver is calling
> idr_destroy() at module exit time. So if this patch is needed for
> bq27x00_battery module, then it is needed also for other charger/battery
> modules...
You're right. I'll post a follow up for this with (this time hopefully)
all battery drivers included.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2015-07-09 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 15:18 [PATCH] power: bq27x00_battery: Destroy battery_id IDR on module exit Johannes Thumshirn
2015-07-08 16:10 ` Pali Rohár
2015-07-09 7:07 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mqdwpy9stab.fsf@c203.arch.suse.de \
--to=jthumshirn@suse.de \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).