* [PATCH] HID: fix compiling error in u2fzero_probe()
@ 2019-04-13 13:44 Mao Wenan
2019-04-15 9:03 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Mao Wenan @ 2019-04-13 13:44 UTC (permalink / raw)
To: jikos, benjamin.tissoires, maowenan
Cc: linux-input, linux-kernel, kernel-janitors, Hulk Robot
There is one compiling error in u2fzero_probe()->u2fzero_init_hwrng(),
this is because HW_RANDOM is not set.
drivers/hid/hid-u2fzero.o: In function `u2fzero_probe':
hid-u2fzero.c:(.text+0xc70): undefined reference to `devm_hwrng_register'
Fixes: 42337b9d4d958("HID: add driver for U2F Zero built-in LED and RNG")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/hid/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 4dc1035..76d8206 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -1017,6 +1017,7 @@ config HID_U2FZERO
tristate "U2F Zero LED and RNG support"
depends on USB_HID
depends on LEDS_CLASS
+ depends on HW_RANDOM
help
Support for the LED of the U2F Zero device.
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: fix compiling error in u2fzero_probe()
2019-04-13 13:44 [PATCH] HID: fix compiling error in u2fzero_probe() Mao Wenan
@ 2019-04-15 9:03 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2019-04-15 9:03 UTC (permalink / raw)
To: Mao Wenan
Cc: benjamin.tissoires, linux-input, linux-kernel, kernel-janitors,
Hulk Robot, Andrej Shadura
On Sat, 13 Apr 2019, Mao Wenan wrote:
> There is one compiling error in u2fzero_probe()->u2fzero_init_hwrng(),
> this is because HW_RANDOM is not set.
>
> drivers/hid/hid-u2fzero.o: In function `u2fzero_probe':
> hid-u2fzero.c:(.text+0xc70): undefined reference to `devm_hwrng_register'
>
> Fixes: 42337b9d4d958("HID: add driver for U2F Zero built-in LED and RNG")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/hid/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 4dc1035..76d8206 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -1017,6 +1017,7 @@ config HID_U2FZERO
> tristate "U2F Zero LED and RNG support"
> depends on USB_HID
> depends on LEDS_CLASS
> + depends on HW_RANDOM
[ CCing Andrej ]
This was supposed to be sent by Andrej (together with other fixes), but
you beat him to it. Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-15 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-13 13:44 [PATCH] HID: fix compiling error in u2fzero_probe() Mao Wenan
2019-04-15 9:03 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).