From: Jiri Kosina <jikos@kernel.org>
To: Dmitry Torokhov <dtor@chromium.org>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Benson Leung <bleung@chromium.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] HID: google: whiskers: more robust tablet mode detection
Date: Mon, 23 Sep 2019 11:09:04 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1909231108330.1459@cbobk.fhfr.pm> (raw)
In-Reply-To: <CAE_wzQ9U-Lu=Uce0jFjec9JMYMhsQZoTuB+xqDpkOdC+Ufq6Ng@mail.gmail.com>
On Sun, 15 Sep 2019, Dmitry Torokhov wrote:
> > > The USB interface may get detected before the platform/EC one, so let's
> > > note the state of the base (if we receive event) and use it to correctly
> > > initialize the tablet mode switch state.
> > >
> > > Also let's start the HID interface immediately when probing, this will
> > > ensure that we correctly process "base folded" events that may be sent
> > > as we initialize the base. Note that this requires us to add a release()
> >
> > s/release/remove/ ?
>
> You are right.
I'll fix that up when I am applying it (once 5.4 merge window is over).
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2019-09-23 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 22:03 [PATCH 1/3] HID: google: whiskers: more robust tablet mode detection Dmitry Torokhov
2019-09-13 22:03 ` [PATCH 2/3] HID: google: whiskers: signal tablet mode switch on disconnect Dmitry Torokhov
2019-09-13 22:03 ` [PATCH 3/3] HID: google: whiskers: signal tablet mode on connect Dmitry Torokhov
2019-09-16 3:26 ` [PATCH 1/3] HID: google: whiskers: more robust tablet mode detection Nicolas Boichat
2019-09-16 3:36 ` Dmitry Torokhov
2019-09-23 9:09 ` Jiri Kosina [this message]
2019-10-01 14:16 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1909231108330.1459@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bleung@chromium.org \
--cc=drinkcat@chromium.org \
--cc=dtor@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).