linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] HID: i2c-hid: remove orphaned member sleep_delay
@ 2019-11-15  5:36 You-Sheng Yang
  2019-11-15 12:20 ` Jiri Kosina
  0 siblings, 1 reply; 2+ messages in thread
From: You-Sheng Yang @ 2019-11-15  5:36 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires, Kai-Heng Feng, Hui Wang
  Cc: You-Sheng Yang, HungNien Chen, linux-input, linux-kernel

This was introduced in commit 00b790ea545b ("HID: i2c-hid: Add a small
delay after sleep command for Raydium touchpanel") which has been
effectively reverted by commit 67b18dfb8cfc ("HID: i2c-hid: Remove
runtime power management").

Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
---
 drivers/hid/i2c-hid/i2c-hid-core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 04c088131e04..adfe344bc786 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -157,8 +157,6 @@ struct i2c_hid {
 
 	bool			irq_wake_enabled;
 	struct mutex		reset_lock;
-
-	unsigned long		sleep_delay;
 };
 
 static const struct i2c_hid_quirks {
-- 
2.24.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] HID: i2c-hid: remove orphaned member sleep_delay
  2019-11-15  5:36 [PATCH] HID: i2c-hid: remove orphaned member sleep_delay You-Sheng Yang
@ 2019-11-15 12:20 ` Jiri Kosina
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2019-11-15 12:20 UTC (permalink / raw)
  To: You-Sheng Yang
  Cc: Benjamin Tissoires, Kai-Heng Feng, Hui Wang, HungNien Chen,
	linux-input, linux-kernel

On Fri, 15 Nov 2019, You-Sheng Yang wrote:

> This was introduced in commit 00b790ea545b ("HID: i2c-hid: Add a small
> delay after sleep command for Raydium touchpanel") which has been
> effectively reverted by commit 67b18dfb8cfc ("HID: i2c-hid: Remove
> runtime power management").
> 
> Signed-off-by: You-Sheng Yang <vicamo.yang@canonical.com>
> ---
>  drivers/hid/i2c-hid/i2c-hid-core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
> index 04c088131e04..adfe344bc786 100644
> --- a/drivers/hid/i2c-hid/i2c-hid-core.c
> +++ b/drivers/hid/i2c-hid/i2c-hid-core.c
> @@ -157,8 +157,6 @@ struct i2c_hid {
>  
>  	bool			irq_wake_enabled;
>  	struct mutex		reset_lock;
> -
> -	unsigned long		sleep_delay;
>  };

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-15 12:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15  5:36 [PATCH] HID: i2c-hid: remove orphaned member sleep_delay You-Sheng Yang
2019-11-15 12:20 ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).