From: Jiri Kosina <jikos@kernel.org>
To: Scott Shumate <scott.shumate@gmail.com>
Cc: "Colenbrander, Roderick" <Roderick.Colenbrander@sony.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HID: sony: Fix for broken buttons on DS3 USB dongles
Date: Tue, 26 May 2020 11:00:18 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2005261059590.25812@cbobk.fhfr.pm> (raw)
In-Reply-To: <e3496a04-3a96-f833-955f-69912a76bdac@gmail.com>
On Wed, 13 May 2020, Scott Shumate wrote:
> Hi Roderick,
>
> The official DS3 has a Report Count(19) instead of Report Count(13) in the
> exact same offset. I have no idea what the silicon vendor for these dongles
> was thinking but it's suspicious that the official count of 19 (0x13) turned
> into 13 (0xd) in the knock-off. It makes you wonder if the engineers confused
> the decimal/hex numbers.
>
> As buggy as all of these third-party devices are, I'm afraid relying on the
> HID parser to get it right is only going to worse over time. I do like your
> idea of having each device register themselves. It would be nice to have each
> device provide a callback to decode its own report rather than handle a bunch
> of special conditions and quirks in a unified report decoding function. The
> drawback of course is that its going to be a little more effort to maintain.
I've added Cc: stable and Fixes: tag, and applied.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2020-05-26 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46c1ab66-62d7-5dae-2f4d-7e722f1aff3a@gmail.com>
2020-05-13 19:41 ` [PATCH] HID: sony: Fix for broken buttons on DS3 USB dongles Colenbrander, Roderick
2020-05-13 20:06 ` Scott Shumate
2020-05-26 9:00 ` Jiri Kosina [this message]
2020-05-13 18:39 scott.shumate
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2005261059590.25812@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=Roderick.Colenbrander@sony.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.shumate@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).