* [PATCH] HID: alps: clean up indentation issue
@ 2020-09-20 14:17 Colin King
2020-09-22 9:20 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2020-09-20 14:17 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, linux-input, linux-kernel
Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
There is an if statement that is indented too deeply, fix
this by removing the extraneous tab.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/hid/hid-alps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index a9c2de95c5e2..3feaece13ade 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -526,7 +526,7 @@ static int u1_init(struct hid_device *hdev, struct alps_dev *pri_data)
ret = u1_read_write_register(hdev, ADDRESS_U1_NUM_SENS_Y,
&sen_line_num_y, 0, true);
- if (ret < 0) {
+ if (ret < 0) {
dev_err(&hdev->dev, "failed U1_NUM_SENS_Y (%d)\n", ret);
goto exit;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: alps: clean up indentation issue
2020-09-20 14:17 [PATCH] HID: alps: clean up indentation issue Colin King
@ 2020-09-22 9:20 ` Jiri Kosina
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2020-09-22 9:20 UTC (permalink / raw)
To: Colin King; +Cc: Benjamin Tissoires, linux-input, linux-kernel, kernel-janitors
On Sun, 20 Sep 2020, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an if statement that is indented too deeply, fix
> this by removing the extraneous tab.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/hid/hid-alps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
> index a9c2de95c5e2..3feaece13ade 100644
> --- a/drivers/hid/hid-alps.c
> +++ b/drivers/hid/hid-alps.c
> @@ -526,7 +526,7 @@ static int u1_init(struct hid_device *hdev, struct alps_dev *pri_data)
>
> ret = u1_read_write_register(hdev, ADDRESS_U1_NUM_SENS_Y,
> &sen_line_num_y, 0, true);
> - if (ret < 0) {
> + if (ret < 0) {
> dev_err(&hdev->dev, "failed U1_NUM_SENS_Y (%d)\n", ret);
I am usually not taking whitespace fixes, but this one actually really
does improve code readability, so I am taking this one. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] HID: alps: clean up indentation issue
@ 2019-09-25 11:19 Colin King
0 siblings, 0 replies; 3+ messages in thread
From: Colin King @ 2019-09-25 11:19 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, linux-input
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is an if statement that is indented one level too deeply,
remove the extraneous tab.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/hid/hid-alps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index ae79a7c66737..280f1962914b 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -525,7 +525,7 @@ static int u1_init(struct hid_device *hdev, struct alps_dev *pri_data)
ret = u1_read_write_register(hdev, ADDRESS_U1_NUM_SENS_Y,
&sen_line_num_y, 0, true);
- if (ret < 0) {
+ if (ret < 0) {
dev_err(&hdev->dev, "failed U1_NUM_SENS_Y (%d)\n", ret);
goto exit;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-22 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-20 14:17 [PATCH] HID: alps: clean up indentation issue Colin King
2020-09-22 9:20 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2019-09-25 11:19 Colin King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).