From: Jiri Kosina <jikos@kernel.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Gerecke <jason.gerecke@wacom.com>,
Ping Cheng <ping.cheng@wacom.com>
Subject: Re: [PATCH] HID: wacom: Make use of the helper function devm_add_action_or_reset()
Date: Thu, 7 Oct 2021 13:38:45 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2110071338010.29107@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210922125939.427-1-caihuoqing@baidu.com>
On Wed, 22 Sep 2021, Cai Huoqing wrote:
> The helper function devm_add_action_or_reset() will internally
> call devm_add_action(), and if devm_add_action() fails then it will
> execute the action mentioned and return the error code. So
> use devm_add_action_or_reset() instead of devm_add_action()
> to simplify the error handling, reduce the code.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
CCing Jason and Ping to Ack this for the Wacom driver.
> ---
> drivers/hid/wacom_sys.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 93f49b766376..3aed7ba249f7 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -892,10 +892,9 @@ static int wacom_add_shared_data(struct hid_device *hdev)
>
> wacom_wac->shared = &data->shared;
>
> - retval = devm_add_action(&hdev->dev, wacom_remove_shared_data, wacom);
> + retval = devm_add_action_or_reset(&hdev->dev, wacom_remove_shared_data, wacom);
> if (retval) {
> mutex_unlock(&wacom_udev_list_lock);
> - wacom_remove_shared_data(wacom);
> return retval;
> }
>
> --
> 2.25.1
>
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-10-07 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 12:59 [PATCH] HID: wacom: Make use of the helper function devm_add_action_or_reset() Cai Huoqing
2021-10-07 11:38 ` Jiri Kosina [this message]
[not found] ` <CANRwn3SZagP7uCSHVDGMPMqQiKyUQJSjq143_DA1y0UPvsmkAA@mail.gmail.com>
[not found] ` <DB6PR07MB4278FF50AB23B9B69411CA3B9BB19@DB6PR07MB4278.eurprd07.prod.outlook.com>
[not found] ` <CANRwn3TTgZ9+T7h81tNShvEB8QWkrbKLPrQSnviFKMHa8Zga_Q@mail.gmail.com>
2021-10-15 2:58 ` Cai Huoqing
2021-10-17 21:58 ` Ping Cheng
2021-10-18 4:53 ` Dmitry Torokhov
2021-10-18 15:26 ` Jiri Kosina
[not found] ` <CANRwn3Q_LksYwX5x+dKw9OzPcYBQr_N5=5bLpZgNPtd88Zqpfg@mail.gmail.com>
2021-10-26 16:56 ` Jason Gerecke
2021-10-27 8:15 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2110071338010.29107@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=caihuoqing@baidu.com \
--cc=jason.gerecke@wacom.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.cheng@wacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).