From: Jiri Kosina <jikos@kernel.org>
To: Jason Gerecke <killertofu@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Ping Cheng <pinglinux@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Linux Input <linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Aaron Skomra <skomra@gmail.com>,
"Dickens, Joshua" <joshua.dickens@wacom.com>,
Cai Huoqing <caihuoqing@baidu.com>
Subject: Re: [PATCH] HID: wacom: Make use of the helper function devm_add_action_or_reset()
Date: Wed, 27 Oct 2021 10:15:02 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2110271014090.12554@cbobk.fhfr.pm> (raw)
In-Reply-To: <CANRwn3TGkin=4aEKibUicmH-UtRz_SFz7+S6dAsTwXVxRzzi9g@mail.gmail.com>
On Tue, 26 Oct 2021, Jason Gerecke wrote:
> Following up on this. I took a second look at the shared struct, and
> believe that things should work fine during initialization and
> steady-state. There are, however, opportunities for e.g. one
> device/thread to be removed and set e.g. `shared->touch = NULL` while a
> second device/thread is attempting to send an event out of that device.
> This is going to be very rare and only on disconnect, which is probably
> why we've never received reports of real-world issues.
>
> This shared issue is present with or without the changes by Cai and
> myself. I would ask that these two patches be merged
Now applied. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-10-27 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 12:59 [PATCH] HID: wacom: Make use of the helper function devm_add_action_or_reset() Cai Huoqing
2021-10-07 11:38 ` Jiri Kosina
[not found] ` <CANRwn3SZagP7uCSHVDGMPMqQiKyUQJSjq143_DA1y0UPvsmkAA@mail.gmail.com>
[not found] ` <DB6PR07MB4278FF50AB23B9B69411CA3B9BB19@DB6PR07MB4278.eurprd07.prod.outlook.com>
[not found] ` <CANRwn3TTgZ9+T7h81tNShvEB8QWkrbKLPrQSnviFKMHa8Zga_Q@mail.gmail.com>
2021-10-15 2:58 ` Cai Huoqing
2021-10-17 21:58 ` Ping Cheng
2021-10-18 4:53 ` Dmitry Torokhov
2021-10-18 15:26 ` Jiri Kosina
[not found] ` <CANRwn3Q_LksYwX5x+dKw9OzPcYBQr_N5=5bLpZgNPtd88Zqpfg@mail.gmail.com>
2021-10-26 16:56 ` Jason Gerecke
2021-10-27 8:15 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2110271014090.12554@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=caihuoqing@baidu.com \
--cc=dmitry.torokhov@gmail.com \
--cc=joshua.dickens@wacom.com \
--cc=killertofu@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pinglinux@gmail.com \
--cc=skomra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).