From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/7] kbuild: remove wrong 'touch' in adjust_autoksyms.sh
Date: Thu, 15 Mar 2018 22:24:32 -0400 (EDT) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1803152224090.28583@knanqh.ubzr> (raw)
In-Reply-To: <1521166725-24157-3-git-send-email-yamada.masahiro@socionext.com>
On Fri, 16 Mar 2018, Masahiro Yamada wrote:
> The comment mentions it creates autoksyms.h in case it is missing,
> but the actual code touches it when it does exists.
>
> The build system creates it anyway because <linux/export.h> and
> <asm-generic/export.h> need it.
>
> The code would not have worked as intended, and people have not
> noticed it. This is a proof that we can simply remove it.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
> ---
>
> Changes in v2:
> - Remove the code instead of fixing it
>
> scripts/adjust_autoksyms.sh | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh
> index a162258..e0dd0d5 100755
> --- a/scripts/adjust_autoksyms.sh
> +++ b/scripts/adjust_autoksyms.sh
> @@ -48,9 +48,6 @@ case "${KCONFIG_CONFIG}" in
> . "./${KCONFIG_CONFIG}"
> esac
>
> -# In case it doesn't exist yet...
> -if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi
> -
> # Generate a new ksym list file with symbols needed by the current
> # set of modules.
> cat > "$new_ksyms_file" << EOT
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2018-03-16 2:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 2:18 [PATCH v2 0/7] kbuild: various fix, clean-up, improvements of CONFIG_TRIM_UNUSED_KSYMS Masahiro Yamada
2018-03-16 2:18 ` [PATCH v2 1/7] kbuild: clear LDFLAGS in the top Makefile Masahiro Yamada
2018-03-16 2:37 ` Nicolas Pitre
2018-03-16 2:18 ` [PATCH v2 2/7] kbuild: remove wrong 'touch' in adjust_autoksyms.sh Masahiro Yamada
2018-03-16 2:24 ` Nicolas Pitre [this message]
2018-03-16 2:18 ` [PATCH v2 3/7] kbuild: move 'scripts' target below Masahiro Yamada
2018-03-16 2:18 ` [PATCH v2 4/7] kbuild: restore touching autoksyms.h to the top Makefile Masahiro Yamada
2018-03-16 2:18 ` [PATCH v2 5/7] kbuild: move CONFIG_TRIM_UNUSED_KSYMS code unneeded for external module Masahiro Yamada
2018-03-16 2:18 ` [PATCH v2 6/7] kbuild: move include/config/ksym/* to include/ksym/* Masahiro Yamada
2018-03-16 2:36 ` Nicolas Pitre
2018-03-16 2:18 ` [PATCH v2 7/7] kbuild: link vmlinux only once for CONFIG_TRIM_UNUSED_KSYMS Masahiro Yamada
2018-03-16 2:32 ` Nicolas Pitre
2018-03-16 2:35 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1803152224090.28583@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).