From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/7] kbuild: clear LDFLAGS in the top Makefile
Date: Thu, 15 Mar 2018 22:37:27 -0400 (EDT) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1803152237070.28583@knanqh.ubzr> (raw)
In-Reply-To: <1521166725-24157-2-git-send-email-yamada.masahiro@socionext.com>
On Fri, 16 Mar 2018, Masahiro Yamada wrote:
> Currently LDFLAGS is not cleared, so same flags are accumulated in
> LDFLAGS when the top Makefile is recursively invoked.
>
> I found unneeded rebuild for ARCH=arm64 when CONFIG_TRIM_UNUSED_KSYMS
> is enabled. If include/generated/autoksyms.h is updated, the top
> Makefile is recursively invoked, then arch/arm64/Makefile adds one
> more '-maarch64linux'. Due to the command line change, modules are
> rebuilt needlessly.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
> ---
>
> Changes in v2: None
>
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index d9bb6dd6..ac8755d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -437,6 +437,7 @@ KBUILD_CFLAGS_KERNEL :=
> KBUILD_AFLAGS_MODULE := -DMODULE
> KBUILD_CFLAGS_MODULE := -DMODULE
> KBUILD_LDFLAGS_MODULE := -T $(srctree)/scripts/module-common.lds
> +LDFLAGS :=
> GCC_PLUGINS_CFLAGS :=
>
> export ARCH SRCARCH CONFIG_SHELL HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD CC
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2018-03-16 2:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 2:18 [PATCH v2 0/7] kbuild: various fix, clean-up, improvements of CONFIG_TRIM_UNUSED_KSYMS Masahiro Yamada
2018-03-16 2:18 ` [PATCH v2 1/7] kbuild: clear LDFLAGS in the top Makefile Masahiro Yamada
2018-03-16 2:37 ` Nicolas Pitre [this message]
2018-03-16 2:18 ` [PATCH v2 2/7] kbuild: remove wrong 'touch' in adjust_autoksyms.sh Masahiro Yamada
2018-03-16 2:24 ` Nicolas Pitre
2018-03-16 2:18 ` [PATCH v2 3/7] kbuild: move 'scripts' target below Masahiro Yamada
2018-03-16 2:18 ` [PATCH v2 4/7] kbuild: restore touching autoksyms.h to the top Makefile Masahiro Yamada
2018-03-16 2:18 ` [PATCH v2 5/7] kbuild: move CONFIG_TRIM_UNUSED_KSYMS code unneeded for external module Masahiro Yamada
2018-03-16 2:18 ` [PATCH v2 6/7] kbuild: move include/config/ksym/* to include/ksym/* Masahiro Yamada
2018-03-16 2:36 ` Nicolas Pitre
2018-03-16 2:18 ` [PATCH v2 7/7] kbuild: link vmlinux only once for CONFIG_TRIM_UNUSED_KSYMS Masahiro Yamada
2018-03-16 2:32 ` Nicolas Pitre
2018-03-16 2:35 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1803152237070.28583@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).