* [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
@ 2016-06-21 11:42 Rafał Miłecki
2016-06-21 12:22 ` Imre Kaloz
0 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2016-06-21 11:42 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rafał Miłecki, Hauke Mehrtens, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
open list:BROADCOM BCM5301X ARM ARCHITECTURE,
open list:BROADCOM BCM5301X ARM ARCHITECTURE,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
There is one GPIO controlling power for both USB ports.
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
arch/arm/boot/dts/bcm4709-netgear-r7000.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
index a22ed14..a76486b 100644
--- a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
+++ b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
@@ -104,3 +104,11 @@
&uart0 {
status = "okay";
};
+
+&usb2 {
+ vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
+
+&usb3 {
+ vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
+};
--
1.8.4.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
2016-06-21 11:42 [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000 Rafał Miłecki
@ 2016-06-21 12:22 ` Imre Kaloz
2016-06-21 12:26 ` Rafał Miłecki
0 siblings, 1 reply; 6+ messages in thread
From: Imre Kaloz @ 2016-06-21 12:22 UTC (permalink / raw)
To: Florian Fainelli, Rafał Miłecki
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Pawel Moll, Ian Campbell, Hauke Mehrtens, Russell King,
open list, Rob Herring,
open list:BROADCOM BCM5301X ARM ARCHITECTURE, Kumar Gala,
open list:BROADCOM BCM5301X ARM ARCHITECTURE
Is there any reason you are not handling this properly as a regulator with
usb-nop-xceiv?
Imre
On Tue, 21 Jun 2016 13:42:38 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
> There is one GPIO controlling power for both USB ports.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> arch/arm/boot/dts/bcm4709-netgear-r7000.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> index a22ed14..a76486b 100644
> --- a/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> +++ b/arch/arm/boot/dts/bcm4709-netgear-r7000.dts
> @@ -104,3 +104,11 @@
> &uart0 {
> status = "okay";
> };
> +
> +&usb2 {
> + vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&usb3 {
> + vcc-gpio = <&chipcommon 0 GPIO_ACTIVE_HIGH>;
> +};
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
2016-06-21 12:22 ` Imre Kaloz
@ 2016-06-21 12:26 ` Rafał Miłecki
2016-06-21 14:29 ` Imre Kaloz
0 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2016-06-21 12:26 UTC (permalink / raw)
To: Imre Kaloz
Cc: Florian Fainelli, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Pawel Moll, Ian Campbell, Hauke Mehrtens, Russell King,
open list, Rob Herring,
open list:BROADCOM BCM5301X ARM ARCHITECTURE, Kumar Gala,
open list:BROADCOM BCM5301X ARM ARCHITECTURE
On 21 June 2016 at 14:22, Imre Kaloz <kaloz@openwrt.org> wrote:
> Is there any reason you are not handling this properly as a regulator with
> usb-nop-xceiv?
We can't use USB NOP PHY as we need a specific PHY driver for Broadcom's USB.
I sent patch for this:
https://patchwork.kernel.org/patch/9148097/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
2016-06-21 12:26 ` Rafał Miłecki
@ 2016-06-21 14:29 ` Imre Kaloz
2016-06-21 15:23 ` Rafał Miłecki
0 siblings, 1 reply; 6+ messages in thread
From: Imre Kaloz @ 2016-06-21 14:29 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Florian Fainelli, Pawel Moll, Ian Campbell, Hauke Mehrtens,
Russell King, open list, Rob Herring,
open list:BROADCOM BCM5301X ARM ARCHITECTURE, Kumar Gala,
open list:BROADCOM BCM5301X ARM ARCHITECTURE
On Tue, 21 Jun 2016 14:26:11 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
> On 21 June 2016 at 14:22, Imre Kaloz <kaloz@openwrt.org> wrote:
>> Is there any reason you are not handling this properly as a regulator
>> with
>> usb-nop-xceiv?
>
> We can't use USB NOP PHY as we need a specific PHY driver for Broadcom's
> USB.
I see. That shouldn't stop you from addressing the regulator part, tho ;)
Imre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
2016-06-21 14:29 ` Imre Kaloz
@ 2016-06-21 15:23 ` Rafał Miłecki
2016-06-22 10:21 ` Imre Kaloz
0 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2016-06-21 15:23 UTC (permalink / raw)
To: Imre Kaloz
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Florian Fainelli, Pawel Moll, Ian Campbell, Hauke Mehrtens,
Russell King, open list, Rob Herring,
open list:BROADCOM BCM5301X ARM ARCHITECTURE, Kumar Gala,
open list:BROADCOM BCM5301X ARM ARCHITECTURE
On 21 June 2016 at 16:29, Imre Kaloz <kaloz@openwrt.org> wrote:
> On Tue, 21 Jun 2016 14:26:11 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
>
>> On 21 June 2016 at 14:22, Imre Kaloz <kaloz@openwrt.org> wrote:
>>>
>>> Is there any reason you are not handling this properly as a regulator
>>> with
>>> usb-nop-xceiv?
>>
>>
>> We can't use USB NOP PHY as we need a specific PHY driver for Broadcom's
>> USB.
>
>
> I see. That shouldn't stop you from addressing the regulator part, tho ;)
How? Be more specific please.
--
Rafał
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000
2016-06-21 15:23 ` Rafał Miłecki
@ 2016-06-22 10:21 ` Imre Kaloz
0 siblings, 0 replies; 6+ messages in thread
From: Imre Kaloz @ 2016-06-22 10:21 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Florian Fainelli, Pawel Moll, Ian Campbell, Hauke Mehrtens,
Russell King, open list, Rob Herring,
open list:BROADCOM BCM5301X ARM ARCHITECTURE, Kumar Gala,
open list:BROADCOM BCM5301X ARM ARCHITECTURE
On Tue, 21 Jun 2016 17:23:18 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
> On 21 June 2016 at 16:29, Imre Kaloz <kaloz@openwrt.org> wrote:
>> On Tue, 21 Jun 2016 14:26:11 +0200, Rafał Miłecki <zajec5@gmail.com>
>> wrote:
>>
>>> On 21 June 2016 at 14:22, Imre Kaloz <kaloz@openwrt.org> wrote:
>>>>
>>>> Is there any reason you are not handling this properly as a regulator
>>>> with
>>>> usb-nop-xceiv?
>>>
>>>
>>> We can't use USB NOP PHY as we need a specific PHY driver for
>>> Broadcom's
>>> USB.
>>
>>
>> I see. That shouldn't stop you from addressing the regulator part, tho
>> ;)
>
> How? Be more specific please.
>
Instead of blindly enabling a GPIO, you should define that GPIO line as a
fixed regulator and make the USB phy driver handle it. Take a look at
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7776ab70d75ff9857343e44e428744d81c30ce1b
for example.
Imre
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-22 10:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-21 11:42 [PATCH] ARM: BCM5301X: Set GPIO enabling USB power on Netgear R7000 Rafał Miłecki
2016-06-21 12:22 ` Imre Kaloz
2016-06-21 12:26 ` Rafał Miłecki
2016-06-21 14:29 ` Imre Kaloz
2016-06-21 15:23 ` Rafał Miłecki
2016-06-22 10:21 ` Imre Kaloz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).