linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Disk change messages
@ 2001-02-27 20:02 Petr Konecny
  2001-02-28 12:30 ` Pavel Machek
  0 siblings, 1 reply; 2+ messages in thread
From: Petr Konecny @ 2001-02-27 20:02 UTC (permalink / raw)
  To: linux-kernel

Hi,

I've been trying to use vold to automount CDs. The daemon tries to open
/dev/cdrom and if it succeeds it examines the media and mounts it under
/cdrom/volume_name.

The problem is that when there is no disk in the drive the following
message:
  VFS: Disk change detected on device ide1(22,0)
is written to system log during each open call.  Vold calls open every 5
seconds, so it's 17280 lines in log/day. I have been able to avoid these
messages by commenting out a line in drivers/ide/ide-cd.c (patch
included) and have not seen any problems yet.

I guess I have three questions:
 1. can this patch break things ? I suppose it could happen only
    if cdrom_saw_media_change was not called when the CD is changed.
 2. is it possible to avoid the message by modifying vold ? E.g. finding
    out that there is no media in the drive without calling open.
 3. is there a clean way to avoid these repeated messages ?

                                                Thanks, Petr

--- ide-cd.c    2001/02/22 22:30:02     1.1.1.11
+++ ide-cd.c    2001/02/27 19:51:58
@@ -601,7 +601,7 @@

                /* Check for tray open. */
                if (sense_key == NOT_READY) {
-                       cdrom_saw_media_change (drive);
+/*                     cdrom_saw_media_change (drive); */
                } else if (sense_key == UNIT_ATTENTION) {
                        /* Check for media change. */
                        cdrom_saw_media_change (drive);


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Disk change messages
  2001-02-27 20:02 Disk change messages Petr Konecny
@ 2001-02-28 12:30 ` Pavel Machek
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2001-02-28 12:30 UTC (permalink / raw)
  To: Petr Konecny; +Cc: linux-kernel

Hi!

> I've been trying to use vold to automount CDs. The daemon tries to open
> /dev/cdrom and if it succeeds it examines the media and mounts it under
> /cdrom/volume_name.
> 
> The problem is that when there is no disk in the drive the following
> message:
>   VFS: Disk change detected on device ide1(22,0)
> is written to system log during each open call.  Vold calls open every 5
> seconds, so it's 17280 lines in log/day. I have been able to avoid these
> messages by commenting out a line in drivers/ide/ide-cd.c (patch
> included) and have not seen any problems yet.
> 
> I guess I have three questions:
>  1. can this patch break things ? I suppose it could happen only

No.

>  2. is it possible to avoid the message by modifying vold ? E.g. finding
>     out that there is no media in the drive without calling open.

Don't think so.

>  3. is there a clean way to avoid these repeated messages ?

Syslogdshould sumarize "last message repeated 123456 times"
.

>                                                 Thanks, Petr
> 
> --- ide-cd.c    2001/02/22 22:30:02     1.1.1.11
> +++ ide-cd.c    2001/02/27 19:51:58
> @@ -601,7 +601,7 @@
> 
>                 /* Check for tray open. */
>                 if (sense_key == NOT_READY) {
> -                       cdrom_saw_media_change (drive);
> +/*                     cdrom_saw_media_change (drive); */
>                 } else if (sense_key == UNIT_ATTENTION) {
>                         /* Check for media change. */
>                         cdrom_saw_media_change (drive);
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt,
details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-03-01 20:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-02-27 20:02 Disk change messages Petr Konecny
2001-02-28 12:30 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).