From: "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>
To: "Huang, Kai" <kai.huang@intel.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"x86@kernel.org" <x86@kernel.org>, "bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"Reshetova, Elena" <elena.reshetova@intel.com>,
"Nakajima, Jun" <jun.nakajima@intel.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"sathyanarayanan.kuppuswamy@linux.intel.com"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"ashish.kalra@amd.com" <ashish.kalra@amd.com>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
"seanjc@google.com" <seanjc@google.com>,
"bhe@redhat.com" <bhe@redhat.com>,
"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>
Subject: Re: [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method
Date: Sat, 27 Jan 2024 20:15:59 +0200 [thread overview]
Message-ID: <r6u3m7ux2v7w3bg24dqmrolos4jna74nfeheudgxmxcn3iuets@qkuaj2son5mr> (raw)
In-Reply-To: <075348cdf2b4d3361db5c7d420f09a1c8935328e.camel@intel.com>
On Fri, Jan 26, 2024 at 02:21:30PM +0000, Huang, Kai wrote:
> > +static int __init acpi_mp_setup_reset(u64 reset_vector)
> > +{
> > + pgd_t *pgd;
> > + struct x86_mapping_info info = {
> > + .alloc_pgt_page = alloc_pgt_page,
> > + .free_pgt_page = free_pgt_page,
> > + .page_flag = __PAGE_KERNEL_LARGE_EXEC,
> > + .kernpg_flag = _KERNPG_TABLE_NOENC,
> > + };
>
> Nit: Reverse Christmas-tree style
>
> [...]
Okay, will fix if new version is required.
> >
> > -#define ACPI_MP_WAKE_COMMAND_WAKEUP 1
> > +#define ACPI_MP_WAKE_COMMAND_WAKEUP 1
>
> Nit: Is this change intended?
Yes. Changed to indentation with tabs.
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2024-01-27 18:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 12:55 [PATCHv6 00/16] x86/tdx: Add kexec support Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 01/16] x86/acpi: Extract ACPI MADT wakeup code into a separate file Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 02/16] x86/apic: Mark acpi_mp_wake_* variables as __ro_after_init Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 03/16] cpu/hotplug: Add support for declaring CPU offlining not supported Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 04/16] cpu/hotplug, x86/acpi: Disable CPU offlining for ACPI MADT wakeup Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 05/16] x86/kexec: Keep CR4.MCE set during kexec for TDX guest Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 06/16] x86/mm: Make x86_platform.guest.enc_status_change_*() return errno Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 07/16] x86/mm: Return correct level from lookup_address() if pte is none Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 08/16] x86/tdx: Account shared memory Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 09/16] x86/mm: Adding callbacks to prepare encrypted memory for kexec Kirill A. Shutemov
2024-01-29 7:22 ` Nikolay Borisov
2024-01-24 12:55 ` [PATCHv6 10/16] x86/tdx: Convert shared memory back to private on kexec Kirill A. Shutemov
2024-01-29 10:24 ` Kalra, Ashish
2024-01-29 10:36 ` Kirill A. Shutemov
2024-01-29 13:09 ` Kalra, Ashish
2024-01-29 13:34 ` Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 11/16] x86/mm: Make e820_end_ram_pfn() cover E820_TYPE_ACPI ranges Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 12/16] x86/acpi: Rename fields in acpi_madt_multiproc_wakeup structure Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 13/16] x86/acpi: Do not attempt to bring up secondary CPUs in kexec case Kirill A. Shutemov
2024-01-24 12:55 ` [PATCHv6 14/16] x86/smp: Add smp_ops.stop_this_cpu() callback Kirill A. Shutemov
2024-01-26 14:08 ` Huang, Kai
2024-01-24 12:55 ` [PATCHv6 15/16] x86/mm: Introduce kernel_ident_mapping_free() Kirill A. Shutemov
2024-01-26 14:10 ` Huang, Kai
2024-01-24 12:55 ` [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method Kirill A. Shutemov
2024-01-26 14:21 ` Huang, Kai
2024-01-27 18:15 ` kirill.shutemov [this message]
2024-01-26 20:03 ` Kuppuswamy Sathyanarayanan
2024-01-27 19:35 ` Kirill A. Shutemov
2024-01-30 13:43 ` [PATCHv6 00/16] x86/tdx: Add kexec support Paolo Bonzini
2024-01-30 13:55 ` Kirill A. Shutemov
2024-01-30 14:59 ` Paolo Bonzini
2024-01-30 15:15 ` Kirill A. Shutemov
2024-01-30 14:04 ` Huang, Kai
2024-01-31 7:31 ` Nikolay Borisov
2024-01-31 12:47 ` Baoquan He
2024-01-31 12:58 ` Nikolay Borisov
2024-01-31 13:07 ` Huang, Kai
2024-01-31 15:23 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=r6u3m7ux2v7w3bg24dqmrolos4jna74nfeheudgxmxcn3iuets@qkuaj2son5mr \
--to=kirill.shutemov@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=ashish.kalra@amd.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=elena.reshetova@intel.com \
--cc=jun.nakajima@intel.com \
--cc=kai.huang@intel.com \
--cc=kexec@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).