From: Takashi Iwai <tiwai@suse.de>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Mark Hills <mark@xwax.org>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
YueHaibing <yuehaibing@huawei.com>,
Giuliano Pochini <pochini@shiny.it>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] ALSA: echoaudio: Fix potential Oops in snd_echo_resume()
Date: Thu, 13 Aug 2020 11:22:17 +0200 [thread overview]
Message-ID: <s5h364qx5me.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200813074632.17022-1-dinghao.liu@zju.edu.cn>
On Thu, 13 Aug 2020 09:46:30 +0200,
Dinghao Liu wrote:
>
> Freeing chip on error may lead to an Oops at the next time
> the system goes to resume. Fix this by removing all
> snd_echo_free() calls on error.
>
> Fixes: 47b5d028fdce8 ("ALSA: Echoaudio - Add suspend support #2")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Applied, thanks.
Takashi
prev parent reply other threads:[~2020-08-13 9:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 7:46 [PATCH] [v2] ALSA: echoaudio: Fix potential Oops in snd_echo_resume() Dinghao Liu
2020-08-13 9:22 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h364qx5me.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@xwax.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=pochini@shiny.it \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).