Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

[Alex Dewar]

There's a mistake in this. The ID numbers are the wrong way round.

Alex

Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

[Alex Dewar]

My mistake -- I didn't read your changelog properly. Sorry!

On 24/08/2020 13:30, Alex Dewar wrote:
> There's a mistake in this. The ID numbers are the wrong way round.
>
> Alex

Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

[Takashi Iwai]

On Mon, 24 Aug 2020 14:31:17 +0200,
Alex Dewar wrote:
> 
> My mistake -- I didn't read your changelog properly. Sorry!

Would you resubmit the corrected fix patch?

Also, better to indicate the device id number in the patch
description.  It's confusing which entry you've corrected
intentionally for what, and documenting it would help understanding
it.


thanks,

Takashi

> 
> On 24/08/2020 13:30, Alex Dewar wrote:
> > There's a mistake in this. The ID numbers are the wrong way round.
> >
> > Alex
> 

Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

[Takashi Iwai]

On Tue, 25 Aug 2020 16:36:13 +0200,
Adrien Crivelli wrote:
> 
> [1  <text/plain; UTF-8 (7bit)>]
> 
> I believe the code is correct (even though the diff is confusing), but I can
> edit the commit message to also mention the model name.
> 
> Should I submit the patch here as a reply ? or should I create a brand new
> submission in a new thread ?

In a new thread please.


thanks,

Takashi

> 
> On Tue, 25 Aug 2020 at 17:00, Takashi Iwai <tiwai@suse.de> wrote:
> 
>     On Mon, 24 Aug 2020 14:31:17 +0200,
>     Alex Dewar wrote:
>     >
>     > My mistake -- I didn't read your changelog properly. Sorry!
>    
>     Would you resubmit the corrected fix patch?
>    
>     Also, better to indicate the device id number in the patch
>     description.  It's confusing which entry you've corrected
>     intentionally for what, and documenting it would help understanding
>     it.
> 
>     thanks,
>    
>     Takashi
>    
>     >
>     > On 24/08/2020 13:30, Alex Dewar wrote:
>     > > There's a mistake in this. The ID numbers are the wrong way round.
>     > >
>     > > Alex
>     >
> 
> 

[PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

[Adrien Crivelli]

The Galaxy Book Ion 15 inches uses the same ALC298 codec as other Samsung
laptops which have the no headphone sound bug. I confirmed on my own
hardware that this fixes the bug.

Commit e17f02d05 mixed up 13 inches and 15 inches models. This clarifies
the situation with the correct model names.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207423
Signed-off-by: Adrien Crivelli <adrien.crivelli@gmail.com>
---
 sound/pci/hda/patch_realtek.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a1fa983d2..98789691a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7695,7 +7695,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x144d, 0xc169, "Samsung Notebook 9 Pen (NP930SBE-K01US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
 	SND_PCI_QUIRK(0x144d, 0xc176, "Samsung Notebook 9 Pro (NP930MBE-K04US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
 	SND_PCI_QUIRK(0x144d, 0xc189, "Samsung Galaxy Flex Book (NT950QCG-X716)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
-	SND_PCI_QUIRK(0x144d, 0xc18a, "Samsung Galaxy Book Ion (NT950XCJ-X716A)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
+	SND_PCI_QUIRK(0x144d, 0xc18a, "Samsung Galaxy Book Ion (NP930XCJ-K01US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
+	SND_PCI_QUIRK(0x144d, 0xc830, "Samsung Galaxy Book Ion (NT950XCJ-X716A)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
 	SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8),
 	SND_PCI_QUIRK(0x144d, 0xc812, "Samsung Notebook Pen S (NT950SBE-X58)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
 	SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC),
-- 
2.25.1