From: Takashi Iwai <tiwai@suse.de>
To: "Con Kolivas" <con@kolivas.org>
Cc: <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>
Subject: Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.
Date: Fri, 09 Dec 2016 11:22:15 +0100 [thread overview]
Message-ID: <s5h7f79mmg8.wl-tiwai@suse.de> (raw)
In-Reply-To: <2208242.ISe40cRj8e@hex>
On Fri, 09 Dec 2016 05:15:57 +0100,
Con Kolivas wrote:
>
> The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the
> following warning.
>
> [ 6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
> cval->res is probably wrong.
> [ 6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
> 4608/7680/1
>
> Adding it to the list of devices in volume_control_quirks makes it work
> properly, fixing related typo.
>
> Signed-off-by: Con Kolivas <kernel@kolivas.org>
Applied (with Cc to stable), thanks.
Takashi
>
> ---
> sound/usb/mixer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
> index 2f8c388..4703cae 100644
> --- a/sound/usb/mixer.c
> +++ b/sound/usb/mixer.c
> @@ -932,9 +932,10 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval,
> case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
> case USB_ID(0x046d, 0x08ca): /* Logitech Quickcam Fusion */
> case USB_ID(0x046d, 0x0991):
> + case USB_ID(0x046d, 0x09a2): /* QuickCam Communicate Deluxe/S7500 */
> /* Most audio usb devices lie about volume resolution.
> * Most Logitech webcams have res = 384.
> - * Proboly there is some logitech magic behind this number --fishor
> + * Probably there is some logitech magic behind this number --fishor
> */
> if (!strcmp(kctl->id.name, "Mic Capture Volume")) {
> usb_audio_info(chip,
> --
> 2.7.4
>
>
>
next prev parent reply other threads:[~2016-12-09 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 4:15 [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks Con Kolivas
2016-12-09 10:22 ` Takashi Iwai [this message]
2016-12-09 20:35 ` Con Kolivas
2016-12-09 20:53 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7f79mmg8.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=con@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).