From: Takashi Iwai <tiwai@suse.de>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks.
Date: Fri, 09 Dec 2016 21:53:39 +0100 [thread overview]
Message-ID: <s5hwpf8259o.wl-tiwai@suse.de> (raw)
In-Reply-To: <3895233.t8xxWNsFQ1@hex>
On Fri, 09 Dec 2016 21:35:17 +0100,
Con Kolivas wrote:
>
> On Friday, 9 December 2016 11:22:15 AM AEDT Takashi Iwai wrote:
> > On Fri, 09 Dec 2016 05:15:57 +0100,
> >
> > Con Kolivas wrote:
> > > The Logitech QuickCam Communicate Deluxe/S7500 microphone fails with the
> > > following warning.
> > >
> > > [ 6.778995] usb 2-1.2.2.2: Warning! Unlikely big volume range (=3072),
> > > cval->res is probably wrong.
> > > [ 6.778996] usb 2-1.2.2.2: [5] FU [Mic Capture Volume] ch = 1, val =
> > > 4608/7680/1
> > >
> > > Adding it to the list of devices in volume_control_quirks makes it work
> > > properly, fixing related typo.
> > >
> > > Signed-off-by: Con Kolivas <kernel@kolivas.org>
> >
> > Applied (with Cc to stable), thanks.
>
> (Apologies for google mail defaulting to html, resending with a proper mail
> client)
>
> You're welcome. As there appear to be a lot of these devices from the same
> manufacturer with the same error, and there are likely a lot of devices out
> there that are missed from this whitelist, do you think it would be worthwhile
> changing the code to detect the combination of unlikely big volume range and
> usb vendor of 0x046d and automatically try using the volume_control_quirk on
> them instead of a discrete whitelist?
Yeah, it sounds like a good idea!
thanks,
Takashi
prev parent reply other threads:[~2016-12-09 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 4:15 [PATCH SND/USB]: Add QuickCam Communicate Deluxe/S7500 to volume_control_quirks Con Kolivas
2016-12-09 10:22 ` Takashi Iwai
2016-12-09 20:35 ` Con Kolivas
2016-12-09 20:53 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hwpf8259o.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).