From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Kevin Hilman <khilman@baylibre.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH RESEND 02/15] ASoC: meson: add axg fifo base driver
Date: Wed, 18 Jul 2018 17:39:11 +0200 [thread overview]
Message-ID: <s5ha7qoblk0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180718115054.GI5700@sirena.org.uk>
On Wed, 18 Jul 2018 13:50:54 +0200,
Mark Brown wrote:
>
> On Tue, Jul 17, 2018 at 05:42:51PM +0200, Jerome Brunet wrote:
>
> > + return !status ? IRQ_NONE : IRQ_HANDLED;
>
> Please just write normal conditional statements, it makes things a lot
> easier to read (the ! isn't helping either here).
... and there is the standard IRQ_RETVAL() macro for this purpose.
Takashi
next prev parent reply other threads:[~2018-07-18 15:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 15:42 [PATCH RESEND 00/15] ASoC: meson: add axg audio subsystem support Jerome Brunet
2018-07-17 15:42 ` [PATCH RESEND 01/15] ASoC: meson: add axg fifos DT binding documentation Jerome Brunet
2018-07-17 15:42 ` [PATCH RESEND 02/15] ASoC: meson: add axg fifo base driver Jerome Brunet
2018-07-18 11:50 ` Mark Brown
2018-07-18 15:39 ` Takashi Iwai [this message]
2018-07-19 7:55 ` [alsa-devel] " Jerome Brunet
2018-07-17 15:42 ` [PATCH RESEND 03/15] ASoC: meson: add axg frddr driver Jerome Brunet
2018-07-17 15:42 ` [PATCH RESEND 04/15] ASoC: meson: add axg toddr driver Jerome Brunet
2018-07-17 15:42 ` [PATCH RESEND 05/15] ASoC: meson: add axg spdif output DT bindings documentation Jerome Brunet
2018-07-17 15:42 ` [PATCH RESEND 06/15] ASoC: meson: add axg spdif output Jerome Brunet
2018-07-17 15:42 ` [PATCH RESEND 07/15] ASoC: meson: add axg tdm formatters DT bindings documentation Jerome Brunet
2018-07-17 15:42 ` [PATCH RESEND 08/15] ASoC: meson: add axg tdm interface " Jerome Brunet
2018-07-17 15:42 ` [PATCH RESEND 09/15] ASoC: meson: add tdm formatter base driver Jerome Brunet
2018-07-17 15:42 ` [PATCH RESEND 10/15] ASoC: meson: add tdm interface driver Jerome Brunet
2018-07-17 15:43 ` [PATCH RESEND 11/15] ASoC: meson: add tdm output driver Jerome Brunet
2018-07-17 15:43 ` [PATCH RESEND 12/15] ASoC: meson: add tdm input driver Jerome Brunet
2018-07-17 15:43 ` [PATCH RESEND 13/15] ASoC: export snd_soc_of_get_slot_mask Jerome Brunet
2018-07-17 15:43 ` [PATCH RESEND 14/15] ASoC: meson: add axg sound card DT bindings documentation Jerome Brunet
2018-07-17 15:43 ` [PATCH RESEND 15/15] ASoC: meson: add axg sound card support Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5ha7qoblk0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).