* [PATCH] ALSA: sb: Remove extra brackets
@ 2021-03-12 9:36 Xu Wang
2021-03-12 13:14 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2021-03-12 9:36 UTC (permalink / raw)
To: tiwai, perex, joe, jgg, chao; +Cc: linux-kernel
Remove extra brackets.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
sound/isa/sb/sb16_csp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/isa/sb/sb16_csp.c b/sound/isa/sb/sb16_csp.c
index 8635a2b6b36b..2c292bf0f5ae 100644
--- a/sound/isa/sb/sb16_csp.c
+++ b/sound/isa/sb/sb16_csp.c
@@ -769,7 +769,7 @@ static int snd_sb_csp_autoload(struct snd_sb_csp * p, snd_pcm_format_t pcm_sfmt,
p->running = 0; /* clear autoloaded flag */
p->mode = 0;
- return (err);
+ return err;
} else {
p->running = SNDRV_SB_CSP_ST_AUTO; /* set autoloaded flag */
p->acc_width = SNDRV_SB_CSP_SAMPLE_16BIT; /* only 16 bit data */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: sb: Remove extra brackets
2021-03-12 9:36 [PATCH] ALSA: sb: Remove extra brackets Xu Wang
@ 2021-03-12 13:14 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2021-03-12 13:14 UTC (permalink / raw)
To: Xu Wang; +Cc: tiwai, perex, joe, jgg, chao, linux-kernel
On Fri, 12 Mar 2021 10:36:25 +0100,
Xu Wang wrote:
>
> Remove extra brackets.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Thanks for the patch. But this kind of change alone makes little
benefit, as it doesn't improve the readability significantly.
So I'd take such a change only if it's really needed, e.g. if it's a
preliminary work for the further real fixes.
Takashi
> ---
> sound/isa/sb/sb16_csp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/isa/sb/sb16_csp.c b/sound/isa/sb/sb16_csp.c
> index 8635a2b6b36b..2c292bf0f5ae 100644
> --- a/sound/isa/sb/sb16_csp.c
> +++ b/sound/isa/sb/sb16_csp.c
> @@ -769,7 +769,7 @@ static int snd_sb_csp_autoload(struct snd_sb_csp * p, snd_pcm_format_t pcm_sfmt,
>
> p->running = 0; /* clear autoloaded flag */
> p->mode = 0;
> - return (err);
> + return err;
> } else {
> p->running = SNDRV_SB_CSP_ST_AUTO; /* set autoloaded flag */
> p->acc_width = SNDRV_SB_CSP_SAMPLE_16BIT; /* only 16 bit data */
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-12 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 9:36 [PATCH] ALSA: sb: Remove extra brackets Xu Wang
2021-03-12 13:14 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).