linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: don't try to get Outlaw RR2150 sample rate
@ 2015-05-30  9:15 Eric Wong
  2015-05-30 12:17 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2015-05-30  9:15 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: alsa-devel, linux-kernel, Eric Wong, Joe Turner

This quirk allows us to avoid the noisy:

	current rate 0 is different from the runtime rate

message every time playback starts.  While USB DAC in the RR2150
supports reading the sample rate, it never returns a sample rate
other than zero in my observation with common sample rates.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Cc: Joe Turner <joe@oampo.co.uk>
Cc: Takashi Iwai <tiwai@suse.de>
---
 sound/usb/quirks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 32631a8..2ea5b33 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1118,6 +1118,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
 	case USB_ID(0x045E, 0x075D): /* MS Lifecam Cinema  */
 	case USB_ID(0x045E, 0x076D): /* MS Lifecam HD-5000 */
 	case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
+	case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
 		return true;
 	}
 	return false;
-- 
EW


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: usb-audio: don't try to get Outlaw RR2150 sample rate
  2015-05-30  9:15 [PATCH] ALSA: usb-audio: don't try to get Outlaw RR2150 sample rate Eric Wong
@ 2015-05-30 12:17 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2015-05-30 12:17 UTC (permalink / raw)
  To: Eric Wong; +Cc: alsa-devel, linux-kernel, Joe Turner

At Sat, 30 May 2015 09:15:39 +0000,
Eric Wong wrote:
> 
> This quirk allows us to avoid the noisy:
> 
> 	current rate 0 is different from the runtime rate
> 
> message every time playback starts.  While USB DAC in the RR2150
> supports reading the sample rate, it never returns a sample rate
> other than zero in my observation with common sample rates.
> 
> Signed-off-by: Eric Wong <normalperson@yhbt.net>
> Cc: Joe Turner <joe@oampo.co.uk>
> Cc: Takashi Iwai <tiwai@suse.de>

Applied (with Cc to stable), thanks.


Takashi

> ---
>  sound/usb/quirks.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 32631a8..2ea5b33 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -1118,6 +1118,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
>  	case USB_ID(0x045E, 0x075D): /* MS Lifecam Cinema  */
>  	case USB_ID(0x045E, 0x076D): /* MS Lifecam HD-5000 */
>  	case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
> +	case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
>  		return true;
>  	}
>  	return false;
> -- 
> EW
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-30 12:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-30  9:15 [PATCH] ALSA: usb-audio: don't try to get Outlaw RR2150 sample rate Eric Wong
2015-05-30 12:17 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).