linux-next: build failure after merge of the final tree (sound tree related)

linux-next: build failure after merge of the final tree (sound tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

Hi all,

After merging the final tree, today's linux-next build (i386 defconfig)
failed like this:

sound/pci/hda/patch_sigmatel.c: In function 'stac92xx_update_led_status':
sound/pci/hda/patch_sigmatel.c:5075:3: error: implicit declaration of function 'stac_vrefout_set' [-Werror=implicit-function-declaration]

Caused by commit 2faa3bf15ba6 ("ALSA: hda - Rewrite the mute-LED hook
with vmaster hook in patch_sigmatel.c").  CONFIG_SND_HDA_POWER_SAVE is
not set for this build.

I reverted that commit for today (and commits d2f344b5e0a9 "ALSA: hda -
Add "Mute-LED Mode" enum control" and f29735cbef4e "ALSA: hda - Add
expose_enum_ctl flag to snd_hda_add_vmaster_hook()" which conflict with
the revert).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (sound tree related)

[Takashi Iwai]

At Wed, 14 Mar 2012 18:05:08 +1100,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (i386 defconfig)
> failed like this:
> 
> sound/pci/hda/patch_sigmatel.c: In function 'stac92xx_update_led_status':
> sound/pci/hda/patch_sigmatel.c:5075:3: error: implicit declaration of function 'stac_vrefout_set' [-Werror=implicit-function-declaration]
> 
> Caused by commit 2faa3bf15ba6 ("ALSA: hda - Rewrite the mute-LED hook
> with vmaster hook in patch_sigmatel.c").  CONFIG_SND_HDA_POWER_SAVE is
> not set for this build.
> 
> I reverted that commit for today (and commits d2f344b5e0a9 "ALSA: hda -
> Add "Mute-LED Mode" enum control" and f29735cbef4e "ALSA: hda - Add
> expose_enum_ctl flag to snd_hda_add_vmaster_hook()" which conflict with
> the revert).

Oops, fixed now.


thanks,

Takashi

Re: linux-next: build failure after merge of the final tree (sound tree related)

[Takashi Iwai]

At Tue, 29 Oct 2013 01:42:34 +1100,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (i386 defconfig)
> failed like this:
> 
> sound/built-in.o: In function `snd_free_dev_iram':
> (.text+0x17028): undefined reference to `gen_pool_free'
> 
> Presumably caused by commit 055032142c42 ("ALSA: Add SoC on-chip internal
> ram support for DMA buffer allocation") from the sound tree.
> 
> I have left this broken for today.

The proper fix has been pushed now to for-next branch.


thanks,

Takashi

---
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] ALSA: memalloc: Yet another ifdef CONFIG_GENERIC_ALLOCATOR
 protection

I obviously forgot to merge the right version...

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/core/memalloc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c
index 51a7921..809fd79 100644
--- a/sound/core/memalloc.c
+++ b/sound/core/memalloc.c
@@ -159,6 +159,7 @@ static void snd_free_dev_pages(struct device *dev, size_t size, void *ptr,
 	dma_free_coherent(dev, PAGE_SIZE << pg, ptr, dma);
 }
 
+#ifdef CONFIG_GENERIC_ALLOCATOR
 /**
  * snd_malloc_dev_iram - allocate memory from on-chip internal ram
  * @dmab: buffer allocation record to store the allocated data
@@ -198,6 +199,7 @@ void snd_free_dev_iram(struct snd_dma_buffer *dmab)
 	if (pool && dmab->area)
 		gen_pool_free(pool, (unsigned long)dmab->area, dmab->bytes);
 }
+#endif /* CONFIG_GENERIC_ALLOCATOR */
 #endif /* CONFIG_HAS_DMA */
 
 /*
-- 
1.8.4.1

linux-next: build failure after merge of the final tree (sound tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hi all,

After merging the final tree, today's linux-next build (i386 defconfig)
failed like this:

sound/built-in.o: In function `snd_free_dev_iram':
(.text+0x17028): undefined reference to `gen_pool_free'

Presumably caused by commit 055032142c42 ("ALSA: Add SoC on-chip internal
ram support for DMA buffer allocation") from the sound tree.

I have left this broken for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (sound tree related)

[Takashi Iwai]

At Thu, 18 Oct 2012 14:16:44 +1100,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from sound/pci/ice1712/psc724.c:29:0:
> sound/pci/ice1712/ice1712.h: In function 'snd_ice1712_write':
> sound/pci/ice1712/ice1712.h:501:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
> sound/pci/ice1712/ice1712.h: In function 'snd_ice1712_read':
> sound/pci/ice1712/ice1712.h:508:2: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]
> 
> Caused by commit 77b0b254af72 ("ALSA: ice1712: Add Philips PSC724
> Ultimate Edge").  Probably some Kconfig dependency missing?

It must be the missing inclusion of linux/io.h.  It's included
implicitly on some archs, so I couldn't catch it.  Sorry.

Fixed now on for-next branch of sound git tree.


thanks,

Takashi

> 
> I have reverted that commit (and the following commit a2af050f8df6 "ALSA:
> ice17xx: Constify strings and string arrays") for today.
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> [2  <application/pgp-signature (7bit)>]
> 

linux-next: build failure after merge of the final tree (sound tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from sound/pci/ice1712/psc724.c:29:0:
sound/pci/ice1712/ice1712.h: In function 'snd_ice1712_write':
sound/pci/ice1712/ice1712.h:501:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
sound/pci/ice1712/ice1712.h: In function 'snd_ice1712_read':
sound/pci/ice1712/ice1712.h:508:2: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration]

Caused by commit 77b0b254af72 ("ALSA: ice1712: Add Philips PSC724
Ultimate Edge").  Probably some Kconfig dependency missing?

I have reverted that commit (and the following commit a2af050f8df6 "ALSA:
ice17xx: Constify strings and string arrays") for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (sound tree related)

[Takashi Iwai]

At Fri, 24 Aug 2012 17:20:18 +1000,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (i386 defconfig)
> failed like this:
> 
> sound/pci/hda/hda_codec.c: In function 'snd_hda_codec_new':
> sound/pci/hda/hda_codec.c:1323:7: error: 'struct hda_codec' has no member named 'd3_stop_clk'
> sound/pci/hda/hda_codec.c:1326:12: error: 'struct hda_codec' has no member named 'd3_stop_clk'
> sound/pci/hda/hda_codec.c: In function 'hda_set_power_state':
> sound/pci/hda/hda_codec.c:3547:7: error: 'struct hda_codec' has no member named 'd3_stop_clk_ok'
> sound/pci/hda/hda_codec.c:3573:11: error: 'struct hda_codec' has no member named 'd3_stop_clk'
> sound/pci/hda/hda_codec.c:3574:8: error: 'struct hda_codec' has no member named 'd3_stop_clk_ok'
> 
> Caused by commit b8dfc4624162 ("ALSA: hda - add runtime PM support").
> CONFIG_SND_HDA_POWER_SAVE is not set for this build.
> 
> I have reverted that commit for today.

This should have been fixed now.  Sorry for inconvenience.


Takashi

linux-next: build failure after merge of the final tree (sound tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

Hi all,

After merging the final tree, today's linux-next build (i386 defconfig)
failed like this:

sound/pci/hda/hda_codec.c: In function 'snd_hda_codec_new':
sound/pci/hda/hda_codec.c:1323:7: error: 'struct hda_codec' has no member named 'd3_stop_clk'
sound/pci/hda/hda_codec.c:1326:12: error: 'struct hda_codec' has no member named 'd3_stop_clk'
sound/pci/hda/hda_codec.c: In function 'hda_set_power_state':
sound/pci/hda/hda_codec.c:3547:7: error: 'struct hda_codec' has no member named 'd3_stop_clk_ok'
sound/pci/hda/hda_codec.c:3573:11: error: 'struct hda_codec' has no member named 'd3_stop_clk'
sound/pci/hda/hda_codec.c:3574:8: error: 'struct hda_codec' has no member named 'd3_stop_clk_ok'

Caused by commit b8dfc4624162 ("ALSA: hda - add runtime PM support").
CONFIG_SND_HDA_POWER_SAVE is not set for this build.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (sound tree related)

[Takashi Iwai]

At Tue, 1 Nov 2011 20:24:52 +1100,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> In file included from sound/pci/intel8x0.c:46:0:
> arch/powerpc/include/asm/kvm_para.h: In function 'kvm_arch_para_features':
> arch/powerpc/include/asm/kvm_para.h:166:22: error: 'KVM_HC_FEATURES' undeclared (first use in this function)
> 
> Caused by commit 228cf79376f1 ("ALSA: intel8x0: Improve performance in
> virtual environment").  It should probably be including linux/kvm_para.h
> instead of asm/kvm_para.h.
> 
> I have reverted that commit for today.

OK, fixed it now.  Thanks for your hint!


Takashi

linux-next: build failure after merge of the final tree (sound tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from sound/pci/intel8x0.c:46:0:
arch/powerpc/include/asm/kvm_para.h: In function 'kvm_arch_para_features':
arch/powerpc/include/asm/kvm_para.h:166:22: error: 'KVM_HC_FEATURES' undeclared (first use in this function)

Caused by commit 228cf79376f1 ("ALSA: intel8x0: Improve performance in
virtual environment").  It should probably be including linux/kvm_para.h
instead of asm/kvm_para.h.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (sound tree related)

[Takashi Iwai]

At Tue, 28 Jun 2011 16:50:39 +1000,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (i386 defconfig)
> failed like this:
> 
> sound/pci/hda/patch_via.c:185:28: error: field 'loopback' has incomplete type
> sound/pci/hda/patch_via.c:187:22: error: array type has incomplete element type
> sound/pci/hda/patch_via.c: In function 'is_aa_path_mute':
> sound/pci/hda/patch_via.c:891:39: error: dereferencing pointer to incomplete type
> sound/pci/hda/patch_via.c:891:51: error: dereferencing pointer to incomplete type
> sound/pci/hda/patch_via.c:892:11: error: dereferencing pointer to incomplete type
> sound/pci/hda/patch_via.c: In function 'add_loopback_list':
> sound/pci/hda/patch_via.c:2004:29: warning: type defaults to 'int' in type name
> sound/pci/hda/patch_via.c:2004:29: warning: type defaults to 'int' in type name
> sound/pci/hda/patch_via.c:2004:29: error: negative width in bit-field '<anonymous>'
> sound/pci/hda/patch_via.c:2007:6: error: dereferencing pointer to incomplete type
> sound/pci/hda/patch_via.c:2008:6: error: dereferencing pointer to incomplete type
> sound/pci/hda/patch_via.c:2009:6: error: dereferencing pointer to incomplete type
> 
> Caused by commit ada509ec00e4 ("ALSA: hda - Simplify analog-low-current
> mode check for VIA codecs") which removed the CONFIG_SND_HDA_POWER_SAVE
> protection of the usage, but not the definition in
> sound/pci/hda/hda_local.h.
> 
> I have added the below patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 28 Jun 2011 16:46:09 +1000
> Subject: [PATCH] ALSA: hda - remove SND_HDA_POWER_SAVE protection of struct
>  hda_loopback_check
> 
> to fix build problems when it is disabled.
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Oh, sorry for overlook.  Now I applied your fix to sound tree.

thanks,

Takashi

> ---
>  sound/pci/hda/hda_local.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_local.h b/sound/pci/hda/hda_local.h
> index b333bf4..88b277e 100644
> --- a/sound/pci/hda/hda_local.h
> +++ b/sound/pci/hda/hda_local.h
> @@ -565,7 +565,6 @@ int snd_hda_get_bool_hint(struct hda_codec *codec, const char *key)
>   * power-management
>   */
>  
> -#ifdef CONFIG_SND_HDA_POWER_SAVE
>  void snd_hda_schedule_power_save(struct hda_codec *codec);
>  
>  struct hda_amp_list {
> @@ -582,7 +581,6 @@ struct hda_loopback_check {
>  int snd_hda_check_amp_list_power(struct hda_codec *codec,
>  				 struct hda_loopback_check *check,
>  				 hda_nid_t nid);
> -#endif /* CONFIG_SND_HDA_POWER_SAVE */
>  
>  /*
>   * AMP control callbacks
> -- 
> 1.7.5.4
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 

linux-next: build failure after merge of the final tree (sound tree related)

[Stephen Rothwell]

Hi all,

After merging the final tree, today's linux-next build (i386 defconfig)
failed like this:

sound/pci/hda/patch_via.c:185:28: error: field 'loopback' has incomplete type
sound/pci/hda/patch_via.c:187:22: error: array type has incomplete element type
sound/pci/hda/patch_via.c: In function 'is_aa_path_mute':
sound/pci/hda/patch_via.c:891:39: error: dereferencing pointer to incomplete type
sound/pci/hda/patch_via.c:891:51: error: dereferencing pointer to incomplete type
sound/pci/hda/patch_via.c:892:11: error: dereferencing pointer to incomplete type
sound/pci/hda/patch_via.c: In function 'add_loopback_list':
sound/pci/hda/patch_via.c:2004:29: warning: type defaults to 'int' in type name
sound/pci/hda/patch_via.c:2004:29: warning: type defaults to 'int' in type name
sound/pci/hda/patch_via.c:2004:29: error: negative width in bit-field '<anonymous>'
sound/pci/hda/patch_via.c:2007:6: error: dereferencing pointer to incomplete type
sound/pci/hda/patch_via.c:2008:6: error: dereferencing pointer to incomplete type
sound/pci/hda/patch_via.c:2009:6: error: dereferencing pointer to incomplete type

Caused by commit ada509ec00e4 ("ALSA: hda - Simplify analog-low-current
mode check for VIA codecs") which removed the CONFIG_SND_HDA_POWER_SAVE
protection of the usage, but not the definition in
sound/pci/hda/hda_local.h.

I have added the below patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 28 Jun 2011 16:46:09 +1000
Subject: [PATCH] ALSA: hda - remove SND_HDA_POWER_SAVE protection of struct
 hda_loopback_check

to fix build problems when it is disabled.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/pci/hda/hda_local.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/hda_local.h b/sound/pci/hda/hda_local.h
index b333bf4..88b277e 100644
--- a/sound/pci/hda/hda_local.h
+++ b/sound/pci/hda/hda_local.h
@@ -565,7 +565,6 @@ int snd_hda_get_bool_hint(struct hda_codec *codec, const char *key)
  * power-management
  */
 
-#ifdef CONFIG_SND_HDA_POWER_SAVE
 void snd_hda_schedule_power_save(struct hda_codec *codec);
 
 struct hda_amp_list {
@@ -582,7 +581,6 @@ struct hda_loopback_check {
 int snd_hda_check_amp_list_power(struct hda_codec *codec,
 				 struct hda_loopback_check *check,
 				 hda_nid_t nid);
-#endif /* CONFIG_SND_HDA_POWER_SAVE */
 
 /*
  * AMP control callbacks
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the final tree (sound tree related)

[Takashi Iwai]

At Tue, 14 Jun 2011 16:03:09 +1000,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (i386 defconfig)
> failed like this:
> 
> sound/pci/hda/snd-hda-codec-realtek.o: In function `snd_hda_detach_beep_device':
> (.text+0xb6d0): multiple definition of `snd_hda_detach_beep_device'
> sound/pci/hda/snd-hda-codec.o:(.text+0xba0): first defined here
> sound/pci/hda/snd-hda-codec-analog.o: In function `snd_hda_detach_beep_device':
> (.text+0x33e0): multiple definition of `snd_hda_detach_beep_device'
> sound/pci/hda/snd-hda-codec.o:(.text+0xba0): first defined here
> sound/pci/hda/snd-hda-codec-idt.o: In function `snd_hda_detach_beep_device':
> (.text+0x6560): multiple definition of `snd_hda_detach_beep_device'
> sound/pci/hda/snd-hda-codec.o:(.text+0xba0): first defined here
> sound/pci/hda/snd-hda-codec-conexant.o: In function `snd_hda_detach_beep_device':
> (.text+0x40d0): multiple definition of `snd_hda_detach_beep_device'
> sound/pci/hda/snd-hda-codec.o:(.text+0xba0): first defined here
> 
> Caused by commit 2308f4add3de ("ALSA: hda - Fix beep_device compilation
> warnings").
> 
> I have reverted that commit for today.

Oops, it was a simple missing static-inline in the patch.
Fixed now with the following commit.
Sorry for inconvenience.


Takashi

---
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] ALSA: hda - Fix missing static inline to beep dummy function

The commit 2308f4add3de9f6c9c9f02e49461e94d84bb200a missed static inline
thus it resulted in multiple-definitions error at linking.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/hda_beep.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/pci/hda/hda_beep.h b/sound/pci/hda/hda_beep.h
index 4967eab..55f0647 100644
--- a/sound/pci/hda/hda_beep.h
+++ b/sound/pci/hda/hda_beep.h
@@ -54,7 +54,7 @@ static inline int snd_hda_attach_beep_device(struct hda_codec *codec, int nid)
 {
 	return 0;
 }
-void snd_hda_detach_beep_device(struct hda_codec *codec)
+static inline void snd_hda_detach_beep_device(struct hda_codec *codec)
 {
 }
 #endif
-- 
1.7.5.3

linux-next: build failure after merge of the final tree (sound tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]

Hi all,

After merging the final tree, today's linux-next build (i386 defconfig)
failed like this:

sound/pci/hda/snd-hda-codec-realtek.o: In function `snd_hda_detach_beep_device':
(.text+0xb6d0): multiple definition of `snd_hda_detach_beep_device'
sound/pci/hda/snd-hda-codec.o:(.text+0xba0): first defined here
sound/pci/hda/snd-hda-codec-analog.o: In function `snd_hda_detach_beep_device':
(.text+0x33e0): multiple definition of `snd_hda_detach_beep_device'
sound/pci/hda/snd-hda-codec.o:(.text+0xba0): first defined here
sound/pci/hda/snd-hda-codec-idt.o: In function `snd_hda_detach_beep_device':
(.text+0x6560): multiple definition of `snd_hda_detach_beep_device'
sound/pci/hda/snd-hda-codec.o:(.text+0xba0): first defined here
sound/pci/hda/snd-hda-codec-conexant.o: In function `snd_hda_detach_beep_device':
(.text+0x40d0): multiple definition of `snd_hda_detach_beep_device'
sound/pci/hda/snd-hda-codec.o:(.text+0xba0): first defined here

Caused by commit 2308f4add3de ("ALSA: hda - Fix beep_device compilation
warnings").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the final tree (sound tree related)

[Takashi Iwai]

At Wed, 16 Mar 2011 17:39:28 +1100,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> sound/firewire/fcp.c: In function 'fcp_avc_transaction':
> sound/firewire/fcp.c:103: error: implicit declaration of function 'msleep'
> 
> Caused by commit 31ef9134eb52 ("ALSA: add LaCie FireWire Speakers/Griffin
> FireWave Surround driver").  See Rule 1 from
> Documentation/SubmitChecklist.
> 
> I have added this patch for today:
> 
> >From d238d290ba37e4a31929e6d3f6a08c187b537628 Mon Sep 17 00:00:00 2001
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 16 Mar 2011 17:35:53 +1100
> Subject: [PATCH] ALSA: msleep needs delay.h
> 
> fixes this error:
> 
> sound/firewire/fcp.c: In function 'fcp_avc_transaction':
> sound/firewire/fcp.c:103: error: implicit declaration of function 'msleep'
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Thanks, fixed now in sound git tree.


Takashi

> ---
>  sound/firewire/fcp.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/firewire/fcp.c b/sound/firewire/fcp.c
> index c20bd9c..ec578b5 100644
> --- a/sound/firewire/fcp.c
> +++ b/sound/firewire/fcp.c
> @@ -13,6 +13,7 @@
>  #include <linux/sched.h>
>  #include <linux/spinlock.h>
>  #include <linux/wait.h>
> +#include <linux/delay.h>
>  #include "fcp.h"
>  #include "lib.h"
>  
> -- 
> 1.7.4.1
> 
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 

linux-next: build failure after merge of the final tree (sound tree related)

[Stephen Rothwell]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

sound/firewire/fcp.c: In function 'fcp_avc_transaction':
sound/firewire/fcp.c:103: error: implicit declaration of function 'msleep'

Caused by commit 31ef9134eb52 ("ALSA: add LaCie FireWire Speakers/Griffin
FireWave Surround driver").  See Rule 1 from
Documentation/SubmitChecklist.

I have added this patch for today:

>From d238d290ba37e4a31929e6d3f6a08c187b537628 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 16 Mar 2011 17:35:53 +1100
Subject: [PATCH] ALSA: msleep needs delay.h

fixes this error:

sound/firewire/fcp.c: In function 'fcp_avc_transaction':
sound/firewire/fcp.c:103: error: implicit declaration of function 'msleep'

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/firewire/fcp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/firewire/fcp.c b/sound/firewire/fcp.c
index c20bd9c..ec578b5 100644
--- a/sound/firewire/fcp.c
+++ b/sound/firewire/fcp.c
@@ -13,6 +13,7 @@
 #include <linux/sched.h>
 #include <linux/spinlock.h>
 #include <linux/wait.h>
+#include <linux/delay.h>
 #include "fcp.h"
 #include "lib.h"
 
-- 
1.7.4.1


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the final tree (sound tree related)

[Takashi Iwai]

At Tue, 11 Jan 2011 13:20:30 +1100,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> sound/pci/oxygen/xonar_dg.c: In function 'dg_output_enable':
> sound/pci/oxygen/xonar_dg.c:138: error: implicit declaration of function 'msleep'
> 
> Caused by commit 66410bfdf14f7c2ad3b2d4a8adeab41d368b6f05 ("ALSA: oxygen:
> add Xonar DG support").
> 
> See Rule 1 in Documentation/SubmitChecklist.
> 
> I added the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 11 Jan 2011 13:17:16 +1100
> Subject: [PATCH] ALSA: include delay.h for msleep in Xonar DG support
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Thanks Stephen, applied the patch now to sound git tree.


Takashi

> ---
>  sound/pci/oxygen/xonar_dg.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/oxygen/xonar_dg.c b/sound/pci/oxygen/xonar_dg.c
> index cc610ac1..dd45cf4 100644
> --- a/sound/pci/oxygen/xonar_dg.c
> +++ b/sound/pci/oxygen/xonar_dg.c
> @@ -40,6 +40,7 @@
>   */
>  
>  #include <linux/pci.h>
> +#include <linux/delay.h>
>  #include <sound/control.h>
>  #include <sound/core.h>
>  #include <sound/info.h>
> -- 
> 1.7.2.3
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 

linux-next: build failure after merge of the final tree (sound tree related)

[Stephen Rothwell]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

sound/pci/oxygen/xonar_dg.c: In function 'dg_output_enable':
sound/pci/oxygen/xonar_dg.c:138: error: implicit declaration of function 'msleep'

Caused by commit 66410bfdf14f7c2ad3b2d4a8adeab41d368b6f05 ("ALSA: oxygen:
add Xonar DG support").

See Rule 1 in Documentation/SubmitChecklist.

I added the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 11 Jan 2011 13:17:16 +1100
Subject: [PATCH] ALSA: include delay.h for msleep in Xonar DG support

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 sound/pci/oxygen/xonar_dg.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/pci/oxygen/xonar_dg.c b/sound/pci/oxygen/xonar_dg.c
index cc610ac1..dd45cf4 100644
--- a/sound/pci/oxygen/xonar_dg.c
+++ b/sound/pci/oxygen/xonar_dg.c
@@ -40,6 +40,7 @@
  */
 
 #include <linux/pci.h>
+#include <linux/delay.h>
 #include <sound/control.h>
 #include <sound/core.h>
 #include <sound/info.h>
-- 
1.7.2.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: linux-next: build failure after merge of the final tree (sound tree related)

[Takashi Iwai]

At Tue, 21 Sep 2010 16:40:25 +1000,
Stephen Rothwell wrote:
> 
> Hi ,
> 
> After merging the final tree, today's linux-next build (i386 defconfig)
> failed like this:
> 
> sound/pci/hda/patch_realtek.c: In function 'alc_resume':
> sound/pci/hda/patch_realtek.c:4131: error: 'struct hda_codec_ops' has no member named 'check_power_status'
> sound/pci/hda/patch_realtek.c:4132: error: 'struct hda_codec_ops' has no member named 'check_power_status'
> sound/pci/hda/patch_realtek.c: In function 'alc269_resume':
> sound/pci/hda/patch_realtek.c:14706: error: 'struct hda_codec_ops' has no member named 'check_power_status'
> sound/pci/hda/patch_realtek.c:14707: error: 'struct hda_codec_ops' has no member named 'check_power_status'
> 
> Caused by commit 0ec33d1f952934ea3251cefc6d108b47818eedd0 ("ALSA: hda -
> Refactor ALC269 power-ups/downs in PM callbacks").  I have reverted that
> commit for today.

Thanks.  This should have been fixed now on sound git tree.


Takashi

linux-next: build failure after merge of the final tree (sound tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

Hi ,

After merging the final tree, today's linux-next build (i386 defconfig)
failed like this:

sound/pci/hda/patch_realtek.c: In function 'alc_resume':
sound/pci/hda/patch_realtek.c:4131: error: 'struct hda_codec_ops' has no member named 'check_power_status'
sound/pci/hda/patch_realtek.c:4132: error: 'struct hda_codec_ops' has no member named 'check_power_status'
sound/pci/hda/patch_realtek.c: In function 'alc269_resume':
sound/pci/hda/patch_realtek.c:14706: error: 'struct hda_codec_ops' has no member named 'check_power_status'
sound/pci/hda/patch_realtek.c:14707: error: 'struct hda_codec_ops' has no member named 'check_power_status'

Caused by commit 0ec33d1f952934ea3251cefc6d108b47818eedd0 ("ALSA: hda -
Refactor ALC269 power-ups/downs in PM callbacks").  I have reverted that
commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]