linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ALSA: pcm: Fix trailing semicolon
@ 2018-01-15 18:18 Luis de Bethencourt
  2018-01-15 19:18 ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Luis de Bethencourt @ 2018-01-15 18:18 UTC (permalink / raw)
  To: linux-kernel
  Cc: alsa-devel, Joe Perches, Jaroslav Kysela, Takashi Iwai,
	Takashi Sakamoto, Ubuntu

From: Ubuntu <luisbg@kernel.org>

The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.

Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
---


Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].

Best regards 
Luis


[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 sound/core/pcm_native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 3f13e8da0812..51104df924e1 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
 int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
 			   struct vm_area_struct *area)
 {
-	struct snd_pcm_runtime *runtime = substream->runtime;;
+	struct snd_pcm_runtime *runtime = substream->runtime;
 
 	area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
 	return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
-- 
2.15.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: pcm: Fix trailing semicolon
  2018-01-15 18:18 [PATCH] ALSA: pcm: Fix trailing semicolon Luis de Bethencourt
@ 2018-01-15 19:18 ` Takashi Iwai
  2018-01-16 13:28   ` Luis de Bethencourt
  0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2018-01-15 19:18 UTC (permalink / raw)
  To: Luis de Bethencourt
  Cc: linux-kernel, alsa-devel, Joe Perches, Jaroslav Kysela, Takashi Sakamoto

On Mon, 15 Jan 2018 19:18:57 +0100,
Luis de Bethencourt wrote:
> 
> From: Ubuntu <luisbg@kernel.org>

Is this from address intentional?  It'd be taken as is via git-am.


thanks,

Takashi

> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
> ---
> 
> 
> Hi,
> 
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
> 
> Best regards 
> Luis
> 
> 
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
> 
>  sound/core/pcm_native.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index 3f13e8da0812..51104df924e1 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
>  int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
>  			   struct vm_area_struct *area)
>  {
> -	struct snd_pcm_runtime *runtime = substream->runtime;;
> +	struct snd_pcm_runtime *runtime = substream->runtime;
>  
>  	area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
>  	return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
> -- 
> 2.15.1
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: pcm: Fix trailing semicolon
  2018-01-15 19:18 ` Takashi Iwai
@ 2018-01-16 13:28   ` Luis de Bethencourt
  0 siblings, 0 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2018-01-16 13:28 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: linux-kernel, alsa-devel, Joe Perches, Jaroslav Kysela, Takashi Sakamoto

On 01/15/2018 07:18 PM, Takashi Iwai wrote:
> On Mon, 15 Jan 2018 19:18:57 +0100,
> Luis de Bethencourt wrote:
>>
>> From: Ubuntu <luisbg@kernel.org>
> 
> Is this from address intentional?  It'd be taken as is via git-am.
> 
> 
> thanks,
> 
> Takashi
> 
>> The trailing semicolon is an empty statement that does no operation.
>> Removing it since it doesn't do anything.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
>> ---
>>
>>
>> Hi,
>>
>> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
>> suggested I fix it treewide [0].
>>
>> Best regards 
>> Luis
>>
>>
>> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
>> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>>
>>  sound/core/pcm_native.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
>> index 3f13e8da0812..51104df924e1 100644
>> --- a/sound/core/pcm_native.c
>> +++ b/sound/core/pcm_native.c
>> @@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
>>  int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
>>  			   struct vm_area_struct *area)
>>  {
>> -	struct snd_pcm_runtime *runtime = substream->runtime;;
>> +	struct snd_pcm_runtime *runtime = substream->runtime;
>>  
>>  	area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
>>  	return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
>> -- 
>> 2.15.1
>>
>>

Hi Takashi,

Sorry. Not sure how git send-email added that line to the commit message.
I have sent a v2 correcting it.

Thanks,
Luis

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-16 13:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-15 18:18 [PATCH] ALSA: pcm: Fix trailing semicolon Luis de Bethencourt
2018-01-15 19:18 ` Takashi Iwai
2018-01-16 13:28   ` Luis de Bethencourt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).