* ALSA Maestro driver spinlock bug.
@ 2005-01-05 1:56 Dave Jones
2005-01-05 13:31 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2005-01-05 1:56 UTC (permalink / raw)
To: Matze Braun, Takashi Iwai; +Cc: linux-kernel
One of our Fedora users reported a bug that showed up
with spinlock debugging enabled.
sound/pci/es1968.c: es1968_measure_clock()
At line 1811, we acquire &chip->reg_lock
and then call snd_es1968_bob_inc(), which
calls snd_es1968_bob_start(), which tries to
acquire the same lock at line 885.
It barfs as a result. Is it safe to move
the snd_es1968_bob_inc() call before we
take the lock ?
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ALSA Maestro driver spinlock bug.
2005-01-05 1:56 ALSA Maestro driver spinlock bug Dave Jones
@ 2005-01-05 13:31 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2005-01-05 13:31 UTC (permalink / raw)
To: Dave Jones; +Cc: Matze Braun, linux-kernel
At Tue, 4 Jan 2005 20:56:10 -0500,
Dave Jones wrote:
>
> One of our Fedora users reported a bug that showed up
> with spinlock debugging enabled.
>
> sound/pci/es1968.c: es1968_measure_clock()
>
> At line 1811, we acquire &chip->reg_lock
> and then call snd_es1968_bob_inc(), which
> calls snd_es1968_bob_start(), which tries to
> acquire the same lock at line 885.
>
> It barfs as a result. Is it safe to move
> the snd_es1968_bob_inc() call before we
> take the lock ?
Already fixed in the recent ALSA version.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-05 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-05 1:56 ALSA Maestro driver spinlock bug Dave Jones
2005-01-05 13:31 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).