[PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

[PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

[Akshay Bhat]

From: Ken Lin <ken.lin@advantech.com.tw>

Avoid getting sample rate on B850V3 CP2114 as it is unsupported and
causes noisy "current rate is different from the runtime rate" messages
when playback starts.

Signed-off-by: Ken Lin <ken.lin@advantech.com.tw>
Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
---
 sound/usb/quirks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 6adde45..e5a1133 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1139,6 +1139,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
 	case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
 	case USB_ID(0x0556, 0x0014): /* Phoenix Audio TMX320VC */
 	case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
+	case USB_ID(0x1901, 0x0191): /* GE B850V3 CP2114 audio interface */
 	case USB_ID(0x1de7, 0x0013): /* Phoenix Audio MT202exe */
 	case USB_ID(0x1de7, 0x0014): /* Phoenix Audio TMX320 */
 	case USB_ID(0x1de7, 0x0114): /* Phoenix Audio MT202pcs */
-- 
2.8.1

Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

[Akshay Bhat]

Hi,

On Fri, Aug 12, 2016 at 2:08 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> From: Ken Lin <ken.lin@advantech.com.tw>
>
> Avoid getting sample rate on B850V3 CP2114 as it is unsupported and
> causes noisy "current rate is different from the runtime rate" messages
> when playback starts.
>
> Signed-off-by: Ken Lin <ken.lin@advantech.com.tw>
> Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> ---

Any feedback on the patch? If not can it be applied? Thanks.

Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

[Takashi Iwai]

On Mon, 29 Aug 2016 16:10:03 +0200,
Akshay Bhat wrote:
> 
> Hi,
> 
> On Fri, Aug 12, 2016 at 2:08 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> > From: Ken Lin <ken.lin@advantech.com.tw>
> >
> > Avoid getting sample rate on B850V3 CP2114 as it is unsupported and
> > causes noisy "current rate is different from the runtime rate" messages
> > when playback starts.
> >
> > Signed-off-by: Ken Lin <ken.lin@advantech.com.tw>
> > Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> > ---
> 
> Any feedback on the patch? If not can it be applied? Thanks.

It's already included in 4.8-rc4.  I thought I replied it, but it
seems to be forgotten, as this was received during my vacation,
sorry.


Takashi

Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

[Akshay Bhat]

On 08/29/2016 10:13 AM, Takashi Iwai wrote:
> On Mon, 29 Aug 2016 16:10:03 +0200,
> Akshay Bhat wrote:
>>
>> Hi,
>>
>> On Fri, Aug 12, 2016 at 2:08 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
>>> From: Ken Lin <ken.lin@advantech.com.tw>
>>>
>>> Avoid getting sample rate on B850V3 CP2114 as it is unsupported and
>>> causes noisy "current rate is different from the runtime rate" messages
>>> when playback starts.
>>>
>>> Signed-off-by: Ken Lin <ken.lin@advantech.com.tw>
>>> Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
>>> ---
>>
>> Any feedback on the patch? If not can it be applied? Thanks.
>
> It's already included in 4.8-rc4.  I thought I replied it, but it
> seems to be forgotten, as this was received during my vacation,
> sorry.
>
>
> Takashi
>

Thank you Takashi. I don't see it as part of 4.8-rc4 yet (unless I am 
looking at the wrong tree).

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/usb/quirks.c?id=refs/tags/v4.8-rc4#n1127

Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

[Takashi Iwai]

On Mon, 29 Aug 2016 16:45:58 +0200,
Akshay Bhat wrote:
> 
> 
> 
> On 08/29/2016 10:13 AM, Takashi Iwai wrote:
> > On Mon, 29 Aug 2016 16:10:03 +0200,
> > Akshay Bhat wrote:
> >>
> >> Hi,
> >>
> >> On Fri, Aug 12, 2016 at 2:08 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> >>> From: Ken Lin <ken.lin@advantech.com.tw>
> >>>
> >>> Avoid getting sample rate on B850V3 CP2114 as it is unsupported and
> >>> causes noisy "current rate is different from the runtime rate" messages
> >>> when playback starts.
> >>>
> >>> Signed-off-by: Ken Lin <ken.lin@advantech.com.tw>
> >>> Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> >>> ---
> >>
> >> Any feedback on the patch? If not can it be applied? Thanks.
> >
> > It's already included in 4.8-rc4.  I thought I replied it, but it
> > seems to be forgotten, as this was received during my vacation,
> > sorry.
> >
> >
> > Takashi
> >
> 
> Thank you Takashi. I don't see it as part of 4.8-rc4 yet (unless I am
> looking at the wrong tree).
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/usb/quirks.c?id=refs/tags/v4.8-rc4#n1127

Gah, then it was a different one.  Obviously I overlooked your patch
during my vacation.  Will put it to the queue.

But, this message should appear only once in the recent version.  Does
it still annoy as appearing repeatedly at all...?


thanks,

Takashi

Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

[Akshay Bhat]

On 08/29/2016 10:49 AM, Takashi Iwai wrote:
>
> Gah, then it was a different one.  Obviously I overlooked your patch
> during my vacation.  Will put it to the queue.
>
> But, this message should appear only once in the recent version.  Does
> it still annoy as appearing repeatedly at all...?
>

Hi Takashi,

Thanks for adding it in the queue. You are correct, I believe when we 
last tested it on 4.7 the message appeared once per playback, so the 
commit message might be a bit misleading.

Thanks,
Akshay

Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114

[Takashi Iwai]

On Tue, 30 Aug 2016 17:06:13 +0200,
Akshay Bhat wrote:
> 
> 
> 
> On 08/29/2016 10:49 AM, Takashi Iwai wrote:
> >
> > Gah, then it was a different one.  Obviously I overlooked your patch
> > during my vacation.  Will put it to the queue.
> >
> > But, this message should appear only once in the recent version.  Does
> > it still annoy as appearing repeatedly at all...?
> >
> 
> Hi Takashi,
> 
> Thanks for adding it in the queue. You are correct, I believe when we
> last tested it on 4.7 the message appeared once per playback, so the
> commit message might be a bit misleading.

Don't mind, as this is a stable patch and it's indeed appearing
repeatedly in older kernels to be backported.


Takashi