linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Add quirk for Samsung Notebook
@ 2020-05-10  3:28 Mike Pozulp
  2020-05-10 10:03 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Pozulp @ 2020-05-10  3:28 UTC (permalink / raw)
  Cc: Mike Pozulp, Jaroslav Kysela, Takashi Iwai, Kailang Yang,
	Hui Wang, Jian-Hong Pan, Tomas Espeleta, Sergey Bostandzhyan,
	Michał Mirosław, Chris Chiu, moderated list:SOUND,
	open list

Some models of the Samsung Notebook 9 have very quiet and distorted
headphone output. This quirk changes the VREF value of the ALC298
codec NID 0x1a from default HIZ to new 100.

Signed-off-by: Mike Pozulp <pozulp.kernel@gmail.com>
---
 sound/pci/hda/patch_realtek.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 63e1a56f705b..9b14ed5c75d7 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5923,6 +5923,7 @@ enum {
 	ALC294_FIXUP_ASUS_DUAL_SPK,
 	ALC285_FIXUP_THINKPAD_HEADSET_JACK,
 	ALC294_FIXUP_ASUS_HPE,
+	ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET,
 };
 
 static const struct hda_fixup alc269_fixups[] = {
@@ -7061,6 +7062,13 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC
 	},
+	[ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET] = {
+		.type = HDA_FIXUP_VERBS,
+		.v.verbs = (const struct hda_verb[]) {
+			{ 0x1a, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc5 },
+			{ }
+		},
+	},
 };
 
 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -7336,6 +7344,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
 	SND_PCI_QUIRK(0x1d72, 0x1901, "RedmiBook 14", ALC256_FIXUP_ASUS_HEADSET_MIC),
 	SND_PCI_QUIRK(0x10ec, 0x118c, "Medion EE4254 MD62100", ALC256_FIXUP_MEDION_HEADSET_NO_PRESENCE),
+	SND_PCI_QUIRK(0x144d, 0xc169, "Samsung Notebook 9 Pen (NP930SBE-K01US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
+	SND_PCI_QUIRK(0x144d, 0xc176, "Samsung Notebook 9 Pro (NP930MBE-K04US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
 
 #if 0
 	/* Below is a quirk table taken from the old code.
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Notebook
  2020-05-10  3:28 [PATCH] ALSA: hda/realtek: Add quirk for Samsung Notebook Mike Pozulp
@ 2020-05-10 10:03 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-05-10 10:03 UTC (permalink / raw)
  To: Mike Pozulp
  Cc: Jaroslav Kysela, Takashi Iwai, Kailang Yang, Hui Wang,
	Jian-Hong Pan, Tomas Espeleta, Sergey Bostandzhyan,
	Michał Mirosław, Chris Chiu, moderated list:SOUND,
	open list

On Sun, 10 May 2020 05:28:37 +0200,
Mike Pozulp wrote:
> 
> Some models of the Samsung Notebook 9 have very quiet and distorted
> headphone output. This quirk changes the VREF value of the ALC298
> codec NID 0x1a from default HIZ to new 100.
> 
> Signed-off-by: Mike Pozulp <pozulp.kernel@gmail.com>

Applied after rebasing to 5.7 and arranging the entry order.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-10 10:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-10  3:28 [PATCH] ALSA: hda/realtek: Add quirk for Samsung Notebook Mike Pozulp
2020-05-10 10:03 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).