* [PATCH] ALSA: hda: default enable CA0132 DSP support
@ 2020-03-29 5:30 Rouven Czerwinski
2020-03-29 7:45 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Rouven Czerwinski @ 2020-03-29 5:30 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai; +Cc: Rouven Czerwinski, alsa-devel, linux-kernel
From: Rouven Czerwinski <rouven@czerwinskis.de>
If SND_HDA_CODEC_CA0132 is enabled, the DSP support should be enabled as
well. Disabled DSP support leads to a hanging alsa system and no sound
output on the card otherwise. Tested on:
06:00.0 Audio device: Creative Labs Sound Core3D [Sound Blaster Recon3D / Z-Series] (rev 01)
Signed-off-by: Rouven Czerwinski <rouven@czerwinskis.de>
---
sound/pci/hda/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/Kconfig b/sound/pci/hda/Kconfig
index bd48335d09d7..e1d3082a4fe9 100644
--- a/sound/pci/hda/Kconfig
+++ b/sound/pci/hda/Kconfig
@@ -184,6 +184,7 @@ comment "Set to Y if you want auto-loading the codec driver"
config SND_HDA_CODEC_CA0132_DSP
bool "Support new DSP code for CA0132 codec"
depends on SND_HDA_CODEC_CA0132
+ default y
select SND_HDA_DSP_LOADER
select FW_LOADER
help
base-commit: e595dd94515ed6bc5ba38fce0f9598db8c0ee9a9
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda: default enable CA0132 DSP support
2020-03-29 5:30 [PATCH] ALSA: hda: default enable CA0132 DSP support Rouven Czerwinski
@ 2020-03-29 7:45 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-03-29 7:45 UTC (permalink / raw)
To: Rouven Czerwinski
Cc: Jaroslav Kysela, Takashi Iwai, Rouven Czerwinski, alsa-devel,
linux-kernel
On Sun, 29 Mar 2020 07:30:15 +0200,
Rouven Czerwinski wrote:
>
> From: Rouven Czerwinski <rouven@czerwinskis.de>
>
> If SND_HDA_CODEC_CA0132 is enabled, the DSP support should be enabled as
> well. Disabled DSP support leads to a hanging alsa system and no sound
> output on the card otherwise. Tested on:
>
> 06:00.0 Audio device: Creative Labs Sound Core3D [Sound Blaster Recon3D / Z-Series] (rev 01)
>
> Signed-off-by: Rouven Czerwinski <rouven@czerwinskis.de>
OK, since the DSP support has been improved a lot in comparison with
the early stage, so it makes sense. I believe most of distros have
set already this to y, and it won't be any big impact.
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-29 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-29 5:30 [PATCH] ALSA: hda: default enable CA0132 DSP support Rouven Czerwinski
2020-03-29 7:45 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).