From: Takashi Iwai <tiwai@suse.de>
To: " Wasko, Michal " <michal.wasko@linux.intel.com>
Cc: <alsa-devel@alsa-project.org>,
Hariprasad Kelam <hariprasad.kelam@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Allison Randal <allison@lohutok.net>,
Jaroslav Kysela <perex@perex.cz>,
Richard Fontana <rfontana@redhat.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] sound: pci: emu10k1: Remove unneeded variable "change"
Date: Sat, 13 Jul 2019 19:44:17 +0200 [thread overview]
Message-ID: <s5hzhlhg77y.wl-tiwai@suse.de> (raw)
In-Reply-To: <d92d60c5-2a59-0d1f-05fa-a8ab13f6bdd0@linux.intel.com>
On Fri, 12 Jul 2019 10:06:23 +0200,
Wasko, Michal wrote:
>
>
> On 7/11/2019 7:17 PM, Hariprasad Kelam wrote:
>
> fix below issue reported by coccicheck
> sound/pci/emu10k1/emu10k1x.c:1077:5-11: Unneeded variable: "change".
> Return "0" on line 1092
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
>
> Since the function always return 0 and you perform code clean-up then
> maybe it would be a good idea to just change function to void instead
> of returning int value which does not seem to have use.
No, it's a callback function.
Takashi
next prev parent reply other threads:[~2019-07-13 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 17:17 [PATCH] sound: pci: emu10k1: Remove unneeded variable "change" Hariprasad Kelam
[not found] ` <d92d60c5-2a59-0d1f-05fa-a8ab13f6bdd0@linux.intel.com>
2019-07-13 17:44 ` Takashi Iwai [this message]
2019-07-15 6:57 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzhlhg77y.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=hariprasad.kelam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.wasko@linux.intel.com \
--cc=perex@perex.cz \
--cc=rfontana@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).