* [PATCH] irq: annotate implicit fall through
@ 2019-01-14 20:36 Mathieu Malaterre
2019-01-15 9:46 ` [tip:irq/core] genirq: Correctly " tip-bot for Mathieu Malaterre
0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Malaterre @ 2019-01-14 20:36 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Mathieu Malaterre, linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warning (W=1).
In this particular case add a ‘-’ so as to match the regular expression
expected by GCC.
This commit remove the following warning:
kernel/irq/handle.c:167:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
kernel/irq/handle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 38554bc35375..6df5ddfdb0f8 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -166,7 +166,7 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc, unsigned int *flags
__irq_wake_thread(desc, action);
- /* Fall through to add to randomness */
+ /* Fall through - to add to randomness */
case IRQ_HANDLED:
*flags |= action->flags;
break;
--
2.19.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:irq/core] genirq: Correctly annotate implicit fall through
2019-01-14 20:36 [PATCH] irq: annotate implicit fall through Mathieu Malaterre
@ 2019-01-15 9:46 ` tip-bot for Mathieu Malaterre
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Mathieu Malaterre @ 2019-01-15 9:46 UTC (permalink / raw)
To: linux-tip-commits; +Cc: hpa, linux-kernel, malat, mingo, tglx
Commit-ID: 01cdfa912f1004c463586f52f1dfcbec1274b1f2
Gitweb: https://git.kernel.org/tip/01cdfa912f1004c463586f52f1dfcbec1274b1f2
Author: Mathieu Malaterre <malat@debian.org>
AuthorDate: Mon, 14 Jan 2019 21:36:33 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 15 Jan 2019 10:40:53 +0100
genirq: Correctly annotate implicit fall through
There is a plan to build the kernel with -Wimplicit-fallthrough. The
fallthrough in __handle_irq_event_percpu() has a fallthrough annotation
which is followed by an additional comment and is not recognized by GCC.
Separate the 'fall through' and the rest of the comment with a dash so the
regular expression used by GCC matches.
Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190114203633.18557-1-malat@debian.org
---
kernel/irq/handle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 38554bc35375..6df5ddfdb0f8 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -166,7 +166,7 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc, unsigned int *flags
__irq_wake_thread(desc, action);
- /* Fall through to add to randomness */
+ /* Fall through - to add to randomness */
case IRQ_HANDLED:
*flags |= action->flags;
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-15 9:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 20:36 [PATCH] irq: annotate implicit fall through Mathieu Malaterre
2019-01-15 9:46 ` [tip:irq/core] genirq: Correctly " tip-bot for Mathieu Malaterre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).